René's URL Explorer Experiment


Title: fix: Return feature_view_metadata from the REST feature server by Zhuoxi2000 · Pull Request #6927 · feast-dev/feast · GitHub

Open Graph Title: fix: Return feature_view_metadata from the REST feature server by Zhuoxi2000 · Pull Request #6927 · feast-dev/feast

X Title: fix: Return feature_view_metadata from the REST feature server by Zhuoxi2000 · Pull Request #6927 · feast-dev/feast

Description: What this PR does / why we need it: GetOnlineFeaturesRequest and GetOnlineDocumentsRequest accept include_feature_view_version_metadata, and the feature server passes it on to the store. The store fills metadata.feature_view_metadata on the response proto. The REST layer then dropped the field, so over HTTP the flag had no effect. This PR fixes all three places where the field was lost: feast/feature_server_utils.py: _metadata_to_dict now emits feature_view_metadata when it is non-empty. It uses the same shape as MessageToDict(preserving_proto_field_name=True), so a default name/version is omitted, as the module docstring promises. When the flag is not set, the output is unchanged. feast/feature_server.py: adds FeatureViewMetadataResponse and a feature_view_metadata field to OnlineFeaturesMetadataResponse, so the OpenAPI schema documents what the endpoint returns. feast/infra/online_stores/remote.py: _build_online_response_from_json parses feature_view_metadata back into the proto. A client that uses RemoteOnlineStore with include_feature_view_version_metadata=True already sends the flag, and now gets the metadata back. The flag was added in #6101. The response model from #6142 already filtered the field out, and #6015 then dropped it from the custom dict builder, so it has never come back over REST. Which issue(s) this PR fixes: Fixes #6922 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change New tests: test_feature_server_utils.py::TestFeatureViewVersionMetadata: checks that convert_response_to_dict matches MessageToDict for feature_view_metadata (version 2 and version 0), and that the key is absent when the metadata was not requested. test_feature_server.py::test_get_online_features_returns_feature_view_version_metadata: pushes rows, then calls POST /get-online-features with the flag and checks the field is in the response. test_remote_online_store.py::test_build_online_response_feature_view_metadata: checks that RemoteOnlineStore round-trips the field into the proto. cd sdk/python python -m pytest tests/unit/test_feature_server_utils.py tests/unit/test_feature_server.py \ tests/unit/infra/online_store/test_remote_online_store.py \ -k 'FeatureViewVersionMetadata or version_metadata or feature_view_metadata' Before (master @ 810391f with only the tests applied): 4 failed, 2 passed. After: 6 passed. All three test files: 126 passed. ruff check and ruff format --check (ruff 0.16.9) pass on the changed files. mypy adds no new errors. Misc The remote.py change is limited to the response-parsing helper. It should not conflict with the open PRs that touch the request and write paths of RemoteOnlineStore. AI assistance: this change was drafted with an AI coding assistant (Claude) and verified locally with the tests above.

Open Graph Description: What this PR does / why we need it: GetOnlineFeaturesRequest and GetOnlineDocumentsRequest accept include_feature_view_version_metadata, and the feature server passes it on to the store. The store ...

X Description: What this PR does / why we need it: GetOnlineFeaturesRequest and GetOnlineDocumentsRequest accept include_feature_view_version_metadata, and the feature server passes it on to the store. The store ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6927

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:dbff5aee-6d91-5eaf-3af8-5b716c84f9c9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id860E:C7386:FA78E1:155B6E2:6AFE99C4
html-safe-nonceca8b592c5bb2ab4e4fe2e58d3bf582c0c6e607b05955abf09ba2c03397a42445
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjBFOkM3Mzg2OkZBNzhFMToxNTVCNkUyOjZBRkU5OUM0IiwidmlzaXRvcl9pZCI6IjY1Nzg5ODI4NjIzMDM2OTczNDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac02ba56d6ba512acecdca214e0c02aeaf5a88659ecd90c7ed68e63f4a3aaa3113
hovercard-subject-tagpull_request:4710987000
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6927/files
twitter:imagehttps://avatars.githubusercontent.com/u/113824357?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/113824357?s=400&v=4
og:image:altWhat this PR does / why we need it: GetOnlineFeaturesRequest and GetOnlineDocumentsRequest accept include_feature_view_version_metadata, and the feature server passes it on to the store. The store ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6927/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6927%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6927%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6927/files
Reloadhttps://github.com/feast-dev/feast/pull/6927/files
Reloadhttps://github.com/feast-dev/feast/pull/6927/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Zhuoxi2000:fix-rest-drops-fv-version-metadatahttps://github.com/Zhuoxi2000/feast/tree/fix-rest-drops-fv-version-metadata
Conversation 2 https://github.com/feast-dev/feast/pull/6927
Commits 2 https://github.com/feast-dev/feast/pull/6927/commits
Checks 27 https://github.com/feast-dev/feast/pull/6927/checks
Files changed https://github.com/feast-dev/feast/pull/6927/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6927/files
fix: Return feature_view_metadata from the REST feature server https://github.com/feast-dev/feast/pull/6927/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6927/files
c903c0e fix: Return feature_view_metadata from the REST feature server Zhuoxi2000 Oct 1, 2026 https://github.com/feast-dev/feast/pull/6927/commits/c903c0eb7ecc9e46929fd2afb9b3d41db8923347
cfae311 Merge branch 'master' into fix-rest-drops-fv-version-metadata haoxu0 Oct 2, 2026 https://github.com/feast-dev/feast/pull/6927/commits/cfae31106bd0b4cb8f07de5e077cdd2be508d227
Clear filters https://github.com/feast-dev/feast/pull/6927/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6927/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6927/files
feature_server.py https://github.com/feast-dev/feast/pull/6927/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
feature_server_utils.py https://github.com/feast-dev/feast/pull/6927/files#diff-c511d4ec0a1018abb05459f0cb01ca639b5f4089abbc3be5773c5d599ba64101
remote.py https://github.com/feast-dev/feast/pull/6927/files#diff-18c802bf316b380e9ad6c1f16e00416ef95fa998564e8a3a6488f1a149dcbcf6
test_remote_online_store.py https://github.com/feast-dev/feast/pull/6927/files#diff-8da3cbcb06e433272082c1f54769c3b28c2c0e950ff1e9bfb0aa7e94d6858095
test_feature_server.py https://github.com/feast-dev/feast/pull/6927/files#diff-28c8f509b5d19e3c5c6ffe15fa5d7bac9a945beebfefc6cb904df0ca2799c18a
test_feature_server_utils.py https://github.com/feast-dev/feast/pull/6927/files#diff-a69939c75c6c8fab6dca227011b4c12b6e0aa70c7507d3e46d59e03904b09156
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_server.pyhttps://github.com/feast-dev/feast/pull/6927/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
View file https://github.com/Zhuoxi2000/feast/blob/cfae31106bd0b4cb8f07de5e077cdd2be508d227/sdk/python/feast/feature_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6927/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6927/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/6927/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_server_utils.pyhttps://github.com/feast-dev/feast/pull/6927/files#diff-c511d4ec0a1018abb05459f0cb01ca639b5f4089abbc3be5773c5d599ba64101
View file https://github.com/Zhuoxi2000/feast/blob/cfae31106bd0b4cb8f07de5e077cdd2be508d227/sdk/python/feast/feature_server_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6927/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6927/files#diff-c511d4ec0a1018abb05459f0cb01ca639b5f4089abbc3be5773c5d599ba64101
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/remote.pyhttps://github.com/feast-dev/feast/pull/6927/files#diff-18c802bf316b380e9ad6c1f16e00416ef95fa998564e8a3a6488f1a149dcbcf6
View file https://github.com/Zhuoxi2000/feast/blob/cfae31106bd0b4cb8f07de5e077cdd2be508d227/sdk/python/feast/infra/online_stores/remote.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6927/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6927/files#diff-18c802bf316b380e9ad6c1f16e00416ef95fa998564e8a3a6488f1a149dcbcf6
https://github.com/feast-dev/feast/pull/6927/files#diff-18c802bf316b380e9ad6c1f16e00416ef95fa998564e8a3a6488f1a149dcbcf6
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/online_store/test_remote_online_store.pyhttps://github.com/feast-dev/feast/pull/6927/files#diff-8da3cbcb06e433272082c1f54769c3b28c2c0e950ff1e9bfb0aa7e94d6858095
View file https://github.com/Zhuoxi2000/feast/blob/cfae31106bd0b4cb8f07de5e077cdd2be508d227/sdk/python/tests/unit/infra/online_store/test_remote_online_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6927/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6927/files#diff-8da3cbcb06e433272082c1f54769c3b28c2c0e950ff1e9bfb0aa7e94d6858095
https://github.com/feast-dev/feast/pull/6927/files#diff-8da3cbcb06e433272082c1f54769c3b28c2c0e950ff1e9bfb0aa7e94d6858095
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_feature_server.pyhttps://github.com/feast-dev/feast/pull/6927/files#diff-28c8f509b5d19e3c5c6ffe15fa5d7bac9a945beebfefc6cb904df0ca2799c18a
View file https://github.com/Zhuoxi2000/feast/blob/cfae31106bd0b4cb8f07de5e077cdd2be508d227/sdk/python/tests/unit/test_feature_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6927/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6927/files#diff-28c8f509b5d19e3c5c6ffe15fa5d7bac9a945beebfefc6cb904df0ca2799c18a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_feature_server_utils.pyhttps://github.com/feast-dev/feast/pull/6927/files#diff-a69939c75c6c8fab6dca227011b4c12b6e0aa70c7507d3e46d59e03904b09156
View file https://github.com/Zhuoxi2000/feast/blob/cfae31106bd0b4cb8f07de5e077cdd2be508d227/sdk/python/tests/unit/test_feature_server_utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6927/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6927/files#diff-a69939c75c6c8fab6dca227011b4c12b6e0aa70c7507d3e46d59e03904b09156
Please reload this pagehttps://github.com/feast-dev/feast/pull/6927/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.