René's URL Explorer Experiment


Title: feat: Add LanceFormat table format with version/tag pinning by haoxu0 · Pull Request #6925 · feast-dev/feast · GitHub

Open Graph Title: feat: Add LanceFormat table format with version/tag pinning by haoxu0 · Pull Request #6925 · feast-dev/feast

X Title: feat: Add LanceFormat table format with version/tag pinning by haoxu0 · Pull Request #6925 · feast-dev/feast

Description: Adds Lance to the existing TableFormat abstraction from #5650, rather than introducing a separate data source. Addresses the core of #6899. Why TableFormat and not a new source TableFormat already models Iceberg, Delta and Hudi as formats a source can carry, with catalog/namespace addressing and a properties bag. Lance fits that shape exactly, so it needs no new source class, no new offline store, and no changes to any existing consumer. LanceFormat( catalog="my_catalog", namespace="my_namespace", version=3, # or tag="candidate" ) It works with SparkSource unchanged SparkSource already drives its reader generically: reader = spark_session.read.format(self.table_format.format_type.value) for key, value in self.table_format.properties.items(): reader = reader.option(key, value) So mirroring the pin into properties is what makes this fall out for free. Verified: SparkSource accepted it : LanceFormat spark .format(...) value : lance reader .option(...) pairs : lance.catalog = polaris_dev lance.namespace = ml_features lance.version = 3 SparkSource proto rt : LanceFormat version = 3 Pin semantics version / tag is the Lance-shaped instance of #5782. Two invariants: version >= 1 is enforced. Lance dataset versions start at 1 and the proto treats 0 as unset, so without the guard version=0 would not round-trip — to_proto/from_proto read 0 as absent. Rejecting it keeps the Python and proto semantics in agreement rather than silently dropping a pin. version and tag are mutually exclusive, since a tag already resolves to a version. On the broader question @jfw-ppi raised in #5782 — whether a pin can change the response shape — the position I'd argue for is that a pin selects data, never shape: the declared FeatureView schema stays the contract, and a pinned version whose schema disagrees should fail explicitly. That belongs in whatever consumes the pin, so it is not in this PR, but the format carries enough information to enforce it. Proto regeneration, deliberately constrained Two things worth flagging, both about not doing the obvious thing. 1. Generated with grpcio-tools==1.62.3, not the pinned 1.84.0. Regenerating with the pinned toolchain emits gencode that opens with: _runtime_version.ValidateProtobufRuntimeVersion(_runtime_version.Domain.PUBLIC, 7, 35, 1, ...) pyproject.toml declares protobuf>=4.24.0. That call would hard-fail for anyone on protobuf 4/5/6 — and google.protobuf.runtime_version does not exist in 4.x at all, so it is an ImportError on that one module while every other proto still imports. Using 1.62.3 emits 4.25.1-level gencode, matching every other checked-in proto, and keeps the declared floor honest. Worth noting independently: the checked-in protos are at gencode 4.25.1 while the requirements pin grpcio-tools==1.84.0 / protobuf==7.36.2, so a full regeneration on master today would touch ~70 files and raise the effective protobuf floor. That looks like something to decide on purpose rather than as a side effect of a feature PR. 2. DataSource_pb2 is left untouched on purpose. Regenerating also rewrites DataSource_pb2.py/.pyi (~125 lines), but that churn is pre-existing — I verified it reproduces on pristine master with no changes at all. The checked-in copy is missing _CONNECTIONREF_PARAMSENTRY entries, i.e. it is stale against DataSource.proto. Happy to fix that separately; it does not belong here. Net result is 5 files, and only DataFormat_pb2 regenerated. Scope This adds the format descriptor. It does not add a Lance reader or offline store — that is the follow-on discussed in #6899, and it is why the tests here cover LanceFormat semantics rather than reading real datasets (no new test dependency on pylance). Also explicitly not proposing Lance as an online store: it is a format plus indexes, not a low-latency KV service, and its write path is columnar while online_write_batch is row-oriented proto. Testing 11 new tests in test_table_format.py (24 total in the file): creation, minimal construction, version pin, tag pin, version < 1 rejection, version+tag rejection, dict/json/proto round-trips, unpinned not coming back as version 0, and factory dispatch. test_table_format.py — 24 passed test_utils.py, test_data_sources.py, test_types.py — 52 passed, 1 skipped mypy feast/table_format.py — clean, no issues ruff check / ruff format --check — clean Related: #6899, #5782, #5650, #6499

Open Graph Description: Adds Lance to the existing TableFormat abstraction from #5650, rather than introducing a separate data source. Addresses the core of #6899. Why TableFormat and not a new source TableFormat already ...

X Description: Adds Lance to the existing TableFormat abstraction from #5650, rather than introducing a separate data source. Addresses the core of #6899. Why TableFormat and not a new source TableFormat already ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6925

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eb5dbe76-0374-0df7-5057-40198019b652
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1A8:A7C31:EC71FC:137682F:6AFE98B2
html-safe-nonce9785b5d317272b9223c99046c3328194dad2b5e2f9c14f2ce234ee22c09b2f59
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUE4OkE3QzMxOkVDNzFGQzoxMzc2ODJGOjZBRkU5OEIyIiwidmlzaXRvcl9pZCI6IjI2NjYyMDAyODA0OTU3MjQ3MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbb8b9f50e1f5bb8133172f7738c9895f1d9b35f8fbb8956578777d0fb9330ceb
hovercard-subject-tagpull_request:4709193530
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6925/files
twitter:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
og:image:altAdds Lance to the existing TableFormat abstraction from #5650, rather than introducing a separate data source. Addresses the core of #6899. Why TableFormat and not a new source TableFormat already ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6925/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6925%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6925%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6925/files
Reloadhttps://github.com/feast-dev/feast/pull/6925/files
Reloadhttps://github.com/feast-dev/feast/pull/6925/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
haoxu0:feat/lance-table-formathttps://github.com/haoxu0/feast/tree/feat/lance-table-format
Conversation 2 https://github.com/feast-dev/feast/pull/6925
Commits 1 https://github.com/feast-dev/feast/pull/6925/commits
Checks 23 https://github.com/feast-dev/feast/pull/6925/checks
Files changed https://github.com/feast-dev/feast/pull/6925/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6925/files
feat: Add LanceFormat table format with version/tag pinning https://github.com/feast-dev/feast/pull/6925/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6925/files
9afb378 feat: Add LanceFormat table format with version/tag pinning haoxu0 Oct 1, 2026 https://github.com/feast-dev/feast/pull/6925/commits/9afb378277df28fdc5b31d5f1ed87ac957bc7ee2
Clear filters https://github.com/feast-dev/feast/pull/6925/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6925/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6925/files
DataFormat.proto https://github.com/feast-dev/feast/pull/6925/files#diff-b52828424311fbb1fda5668bad9d1a4bf3570dc24d7ec2b2fe7561d69297d00a
DataFormat_pb2.py https://github.com/feast-dev/feast/pull/6925/files#diff-ca6734d75df99badce8eac8ac48a515081df1b09646cfbc743a2250f411b7655
DataFormat_pb2.pyi https://github.com/feast-dev/feast/pull/6925/files#diff-acfee15e103d1faed236b1320605ff2ce791d765e0e2a3f61a3f37aa59ced73b
table_format.py https://github.com/feast-dev/feast/pull/6925/files#diff-c606ac419c145fe4da16b76d9305f514e72cc0805d40e133f169f19065016451
test_table_format.py https://github.com/feast-dev/feast/pull/6925/files#diff-d94157ddf7c779947b78366046dae98d9a989ccd242992d78567bdf30f085f6b
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L9
protos/feast/core/DataFormat.protohttps://github.com/feast-dev/feast/pull/6925/files#diff-b52828424311fbb1fda5668bad9d1a4bf3570dc24d7ec2b2fe7561d69297d00a
View file https://github.com/haoxu0/feast/blob/9afb378277df28fdc5b31d5f1ed87ac957bc7ee2/protos/feast/core/DataFormat.proto
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6925/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6925/files#diff-b52828424311fbb1fda5668bad9d1a4bf3570dc24d7ec2b2fe7561d69297d00a
https://github.com/feast-dev/feast/pull/6925/files#diff-b52828424311fbb1fda5668bad9d1a4bf3570dc24d7ec2b2fe7561d69297d00a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/protos/feast/core/DataFormat_pb2.pyhttps://github.com/feast-dev/feast/pull/6925/files#diff-ca6734d75df99badce8eac8ac48a515081df1b09646cfbc743a2250f411b7655
View file https://github.com/haoxu0/feast/blob/9afb378277df28fdc5b31d5f1ed87ac957bc7ee2/sdk/python/feast/protos/feast/core/DataFormat_pb2.py
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/feast-dev/feast/pull/6925/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/protos/feast/core/DataFormat_pb2.pyihttps://github.com/feast-dev/feast/pull/6925/files#diff-acfee15e103d1faed236b1320605ff2ce791d765e0e2a3f61a3f37aa59ced73b
View file https://github.com/haoxu0/feast/blob/9afb378277df28fdc5b31d5f1ed87ac957bc7ee2/sdk/python/feast/protos/feast/core/DataFormat_pb2.pyi
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6925/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6925/files#diff-acfee15e103d1faed236b1320605ff2ce791d765e0e2a3f61a3f37aa59ced73b
https://github.com/feast-dev/feast/pull/6925/files#diff-acfee15e103d1faed236b1320605ff2ce791d765e0e2a3f61a3f37aa59ced73b
Please reload this pagehttps://github.com/feast-dev/feast/pull/6925/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6925/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.