René's URL Explorer Experiment


Title: fix: Report Dask monitoring read errors instead of no data by ericdelorefice · Pull Request #6920 · feast-dev/feast · GitHub

Open Graph Title: fix: Report Dask monitoring read errors instead of no data by ericdelorefice · Pull Request #6920 · feast-dev/feast

X Title: fix: Report Dask monitoring read errors instead of no data by ericdelorefice · Pull Request #6920 · feast-dev/feast

Description: What this PR does / why we need it: Problem DaskOfflineStore.get_monitoring_max_timestamp wraps pq.read_table in except Exception: return None, and None means "this source has no data". So a file that exists but cannot be read, or a storage error while reading it, is reported the same way as an empty source. The callers act on that: MonitoringService logs "No data found for feature view '%s', skipping" and skips the feature view, so an unreadable source looks like an empty one. The baseline and compute paths pass the result as max_event_timestamp to _save_computed_metrics and _compute_for_feature_view, so the metrics are saved with no max_event_timestamp when the read failed. compute_monitoring_metrics in the same store reads the same file without a handler, so it raises for the same failure. Reproduction A real parquet file in a temp repo, on master: file with two rows -> 2026-09-30 12:00:00+00:00 path that was never written -> None file containing b"not a parquet" -> None read_table raising OSError -> None Change Only FileNotFoundError returns None, since a source nothing has been written to has no data to monitor. Any other error reaches the caller, where MonitoringService already catches it per feature view and logs "Failed to auto-compute metrics for feature view". I checked that a missing local path raises FileNotFoundError from pq.read_table with pyarrow 25.0.1. pyarrow's remote filesystems report a missing path the same way, but I did not run this against S3 or GCS. Verification New tests/unit/infra/offline_stores/test_dask_monitoring_max_timestamp.py, 4 tests. On master the corrupt-file and storage-error tests fail (DID NOT RAISE), and the 2 controls pass, a readable file and a missing path. With the change all 4 pass. tests/unit/monitoring and test_dask_non_entity.py give the same 10 failures with and without the change, all in tests that need optional backends I don't have installed (BigQuery and others). ruff check and ruff format --check are clean. mypy reports 3 errors in dask.py at lines 183, 184 and 363, the same 3 as on master. Which issue(s) this PR fixes: None filed. Same class of fix as #6918, which does this for Trino's query_monitoring_metrics. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change

Open Graph Description: What this PR does / why we need it: Problem DaskOfflineStore.get_monitoring_max_timestamp wraps pq.read_table in except Exception: return None, and None means "this source has no data". S...

X Description: What this PR does / why we need it: Problem DaskOfflineStore.get_monitoring_max_timestamp wraps pq.read_table in except Exception: return None, and None means "this source has no data&...

Opengraph URL: https://github.com/feast-dev/feast/pull/6920

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f0358741-339a-1fb0-9850-7aaeeb7151cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD24:2A4404:F5774A:143F755:6AFE99B7
html-safe-nonce161e0a22c4e048f115169b5212a9be23ec48d3c7d20915c16c016cabdb7d2096
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDI0OjJBNDQwNDpGNTc3NEE6MTQzRjc1NTo2QUZFOTlCNyIsInZpc2l0b3JfaWQiOiIyNjUxODc5MzkwNjUyMDQ1NzUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb06f4753b519a63d610962a52cdb1e23b0674dde567cef627c0f5869e91b4acf
hovercard-subject-tagpull_request:4703631489
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6920/files
twitter:imagehttps://avatars.githubusercontent.com/u/114540347?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/114540347?s=400&v=4
og:image:altWhat this PR does / why we need it: Problem DaskOfflineStore.get_monitoring_max_timestamp wraps pq.read_table in except Exception: return None, and None means "this source has no data". S...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6920/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6920%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6920%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6920/files
Reloadhttps://github.com/feast-dev/feast/pull/6920/files
Reloadhttps://github.com/feast-dev/feast/pull/6920/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ericdelorefice:dask-monitoring-read-errorshttps://github.com/ericdelorefice/feast/tree/dask-monitoring-read-errors
Conversation 1 https://github.com/feast-dev/feast/pull/6920
Commits 1 https://github.com/feast-dev/feast/pull/6920/commits
Checks 23 https://github.com/feast-dev/feast/pull/6920/checks
Files changed https://github.com/feast-dev/feast/pull/6920/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6920/files
fix: Report Dask monitoring read errors instead of no data https://github.com/feast-dev/feast/pull/6920/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6920/files
134f2b5 fix: Report Dask monitoring read errors instead of no data ericdelorefice Oct 1, 2026 https://github.com/feast-dev/feast/pull/6920/commits/134f2b54519a8b95448514f7ddb326799d9230f4
Clear filters https://github.com/feast-dev/feast/pull/6920/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6920/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6920/files
dask.py https://github.com/feast-dev/feast/pull/6920/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
test_dask_monitoring_max_timestamp.py https://github.com/feast-dev/feast/pull/6920/files#diff-67ff14758fd7860dbb251f5fba0dfbfded01a835ef3ed3254d52f5467e761363
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/dask.pyhttps://github.com/feast-dev/feast/pull/6920/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
View file https://github.com/ericdelorefice/feast/blob/134f2b54519a8b95448514f7ddb326799d9230f4/sdk/python/feast/infra/offline_stores/dask.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6920/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6920/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6920/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/offline_stores/test_dask_monitoring_max_timestamp.pyhttps://github.com/feast-dev/feast/pull/6920/files#diff-67ff14758fd7860dbb251f5fba0dfbfded01a835ef3ed3254d52f5467e761363
View file https://github.com/ericdelorefice/feast/blob/134f2b54519a8b95448514f7ddb326799d9230f4/sdk/python/tests/unit/infra/offline_stores/test_dask_monitoring_max_timestamp.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6920/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/6920/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.