Title: fix: Report Dask monitoring read errors instead of no data by ericdelorefice · Pull Request #6920 · feast-dev/feast · GitHub
Open Graph Title: fix: Report Dask monitoring read errors instead of no data by ericdelorefice · Pull Request #6920 · feast-dev/feast
X Title: fix: Report Dask monitoring read errors instead of no data by ericdelorefice · Pull Request #6920 · feast-dev/feast
Description: What this PR does / why we need it: Problem DaskOfflineStore.get_monitoring_max_timestamp wraps pq.read_table in except Exception: return None, and None means "this source has no data". So a file that exists but cannot be read, or a storage error while reading it, is reported the same way as an empty source. The callers act on that: MonitoringService logs "No data found for feature view '%s', skipping" and skips the feature view, so an unreadable source looks like an empty one. The baseline and compute paths pass the result as max_event_timestamp to _save_computed_metrics and _compute_for_feature_view, so the metrics are saved with no max_event_timestamp when the read failed. compute_monitoring_metrics in the same store reads the same file without a handler, so it raises for the same failure. Reproduction A real parquet file in a temp repo, on master: file with two rows -> 2026-09-30 12:00:00+00:00 path that was never written -> None file containing b"not a parquet" -> None read_table raising OSError -> None Change Only FileNotFoundError returns None, since a source nothing has been written to has no data to monitor. Any other error reaches the caller, where MonitoringService already catches it per feature view and logs "Failed to auto-compute metrics for feature view". I checked that a missing local path raises FileNotFoundError from pq.read_table with pyarrow 25.0.1. pyarrow's remote filesystems report a missing path the same way, but I did not run this against S3 or GCS. Verification New tests/unit/infra/offline_stores/test_dask_monitoring_max_timestamp.py, 4 tests. On master the corrupt-file and storage-error tests fail (DID NOT RAISE), and the 2 controls pass, a readable file and a missing path. With the change all 4 pass. tests/unit/monitoring and test_dask_non_entity.py give the same 10 failures with and without the change, all in tests that need optional backends I don't have installed (BigQuery and others). ruff check and ruff format --check are clean. mypy reports 3 errors in dask.py at lines 183, 184 and 363, the same 3 as on master. Which issue(s) this PR fixes: None filed. Same class of fix as #6918, which does this for Trino's query_monitoring_metrics. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change
Open Graph Description: What this PR does / why we need it: Problem DaskOfflineStore.get_monitoring_max_timestamp wraps pq.read_table in except Exception: return None, and None means "this source has no data". S...
X Description: What this PR does / why we need it: Problem DaskOfflineStore.get_monitoring_max_timestamp wraps pq.read_table in except Exception: return None, and None means "this source has no data&...
Opengraph URL: https://github.com/feast-dev/feast/pull/6920
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f0358741-339a-1fb0-9850-7aaeeb7151cb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DD24:2A4404:F5774A:143F755:6AFE99B7 |
| html-safe-nonce | 161e0a22c4e048f115169b5212a9be23ec48d3c7d20915c16c016cabdb7d2096 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDI0OjJBNDQwNDpGNTc3NEE6MTQzRjc1NTo2QUZFOTlCNyIsInZpc2l0b3JfaWQiOiIyNjUxODc5MzkwNjUyMDQ1NzUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b06f4753b519a63d610962a52cdb1e23b0674dde567cef627c0f5869e91b4acf |
| hovercard-subject-tag | pull_request:4703631489 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6920/files |
| twitter:image | https://avatars.githubusercontent.com/u/114540347?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/114540347?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Problem DaskOfflineStore.get_monitoring_max_timestamp wraps pq.read_table in except Exception: return None, and None means "this source has no data". S... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width