René's URL Explorer Experiment


Title: fix: Raise Trino monitoring query errors other than a missing table by ericdelorefice · Pull Request #6918 · feast-dev/feast · GitHub

Open Graph Title: fix: Raise Trino monitoring query errors other than a missing table by ericdelorefice · Pull Request #6918 · feast-dev/feast

X Title: fix: Raise Trino monitoring query errors other than a missing table by ericdelorefice · Pull Request #6918 · feast-dev/feast

Description: What this PR does / why we need it: Problem TrinoOfflineStore.query_monitoring_metrics catches every TrinoQueryError, logs it at debug level and returns []. The test for it, test_query_monitoring_metrics_handles_query_error, uses TABLE_NOT_FOUND, and that case is right: no table means no metrics yet. But the handler also returns [] for ACCESS_DENIED, a syntax error or an internal error. ensure_monitoring_tables in the same file already draws this line. It accepts COLUMN_ALREADY_EXISTS and raises everything else, and test_ensure_monitoring_tables_raises_on_permission_error pins that. An empty list has real consequences in the callers: MonitoringService calls _ensure_monitoring_tables() right before querying, so on that path the table exists and the handler only ever hides real errors behind an empty result. DQMJobManager.get_job returns None for [], and update_status returns early when the job is None. A failed read while marking a job running, completed or failed drops the status update without an error, and the job stays in its old state. Reproduction A mocked client raising TrinoQueryError({"errorName": "ACCESS_DENIED", ...}), on master: query_monitoring_metrics(...) returns [] and nothing is raised. The same for SYNTAX_ERROR and GENERIC_INTERNAL_ERROR. Change TABLE_NOT_FOUND and SCHEMA_NOT_FOUND still return [], since either means the monitoring table has not been created yet. Any other TrinoQueryError is logged and re-raised, the same as in ensure_monitoring_tables. Verification Two new tests in test_trino_monitoring.py. One covers SCHEMA_NOT_FOUND returning []. The other, parametrized over ACCESS_DENIED, SYNTAX_ERROR and GENERIC_INTERNAL_ERROR, checks that the error is raised. On master the 3 parametrized cases fail and the 2 not-found cases pass, including the existing TABLE_NOT_FOUND test. With the change, the Trino offline store tests are 28 passed. ruff check and ruff format --check are clean. Which issue(s) this PR fixes: None filed. The reproduction is above. This follows the Trino monitoring support added in #6779. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change

Open Graph Description: What this PR does / why we need it: Problem TrinoOfflineStore.query_monitoring_metrics catches every TrinoQueryError, logs it at debug level and returns []. The test for it, test_query_monitoring_m...

X Description: What this PR does / why we need it: Problem TrinoOfflineStore.query_monitoring_metrics catches every TrinoQueryError, logs it at debug level and returns []. The test for it, test_query_monitoring_m...

Opengraph URL: https://github.com/feast-dev/feast/pull/6918

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c872c948-31fd-d5e9-c355-131715680c83
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8FA:5B76F:F87148:1520DC2:6AFE98A3
html-safe-noncefc91ff628a282d30e58d54336f886481e4b670b6131db5027d0e2f75f338aab5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEZBOjVCNzZGOkY4NzE0ODoxNTIwREMyOjZBRkU5OEEzIiwidmlzaXRvcl9pZCI6IjQzMTU5NTcwNzc4NDg1MjkwNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2a92462a4aa6c4b142e688738d4cc761dc6673681825f416dd18f6541604b8a3
hovercard-subject-tagpull_request:4701645705
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6918/files
twitter:imagehttps://avatars.githubusercontent.com/u/114540347?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/114540347?s=400&v=4
og:image:altWhat this PR does / why we need it: Problem TrinoOfflineStore.query_monitoring_metrics catches every TrinoQueryError, logs it at debug level and returns []. The test for it, test_query_monitoring_m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6918/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6918%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6918%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6918/files
Reloadhttps://github.com/feast-dev/feast/pull/6918/files
Reloadhttps://github.com/feast-dev/feast/pull/6918/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ericdelorefice:trino-monitoring-errorshttps://github.com/ericdelorefice/feast/tree/trino-monitoring-errors
Conversation 1 https://github.com/feast-dev/feast/pull/6918
Commits 1 https://github.com/feast-dev/feast/pull/6918/commits
Checks 23 https://github.com/feast-dev/feast/pull/6918/checks
Files changed https://github.com/feast-dev/feast/pull/6918/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918/files
fix: Raise Trino monitoring query errors other than a missing table https://github.com/feast-dev/feast/pull/6918/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6918/files
cb584b6 fix: Raise Trino monitoring query errors other than a missing table ericdelorefice Oct 1, 2026 https://github.com/feast-dev/feast/pull/6918/commits/cb584b6fd8ca823014a2ac6030f8f117b3135649
Clear filters https://github.com/feast-dev/feast/pull/6918/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918/files
test_trino_monitoring.py https://github.com/feast-dev/feast/pull/6918/files#diff-beac26ca51f3d14a5a2f8aff075bb6c1b5a307534ef89209672683371088da4a
trino.py https://github.com/feast-dev/feast/pull/6918/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
...hon/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_monitoring.pyhttps://github.com/feast-dev/feast/pull/6918/files#diff-beac26ca51f3d14a5a2f8aff075bb6c1b5a307534ef89209672683371088da4a
View file https://github.com/ericdelorefice/feast/blob/cb584b6fd8ca823014a2ac6030f8f117b3135649/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/tests/test_trino_monitoring.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6918/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6918/files#diff-beac26ca51f3d14a5a2f8aff075bb6c1b5a307534ef89209672683371088da4a
https://github.com/feast-dev/feast/pull/6918/files#diff-beac26ca51f3d14a5a2f8aff075bb6c1b5a307534ef89209672683371088da4a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.pyhttps://github.com/feast-dev/feast/pull/6918/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
View file https://github.com/ericdelorefice/feast/blob/cb584b6fd8ca823014a2ac6030f8f117b3135649/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6918/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6918/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6918/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.