René's URL Explorer Experiment


Title: fix: Raise Trino monitoring query errors other than a missing table by ericdelorefice · Pull Request #6918 · feast-dev/feast · GitHub

Open Graph Title: fix: Raise Trino monitoring query errors other than a missing table by ericdelorefice · Pull Request #6918 · feast-dev/feast

X Title: fix: Raise Trino monitoring query errors other than a missing table by ericdelorefice · Pull Request #6918 · feast-dev/feast

Description: The Open Source Feature Store for AI/ML. Contribute to feast-dev/feast development by creating an account on GitHub.

Open Graph Description: What this PR does / why we need it: Problem TrinoOfflineStore.query_monitoring_metrics catches every TrinoQueryError, logs it at debug level and returns []. The test for it, test_query_monitoring_m...

X Description: What this PR does / why we need it: Problem TrinoOfflineStore.query_monitoring_metrics catches every TrinoQueryError, logs it at debug level and returns []. The test for it, test_query_monitoring_m...

Opengraph URL: https://github.com/feast-dev/feast/pull/6918

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:23334734-afa3-9d9f-ab1e-6d7eb1ebe86b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9CCA:3FDE19:2BA19F:3A3FB5:6AFE96CA
html-safe-nonceaaca999c219171f8361990ee98b4bdbb855c67e314716fe6a798fa2219870674
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0NBOjNGREUxOToyQkExOUY6M0EzRkI1OjZBRkU5NkNBIiwidmlzaXRvcl9pZCI6IjE3NzA2NDE5NjUxMTM1NzkyMTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdd411eb9ac000cf6d0ed9b99ae27f57605ee156869277741122412abd8212f80
hovercard-subject-tagpull_request:4701645705
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/6918/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/711c059a3bbd2f04a10ef348638374256a3c4ad9d60f060765aca4d195599886/feast-dev/feast/pull/6918
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/711c059a3bbd2f04a10ef348638374256a3c4ad9d60f060765aca4d195599886/feast-dev/feast/pull/6918
og:image:altWhat this PR does / why we need it: Problem TrinoOfflineStore.query_monitoring_metrics catches every TrinoQueryError, logs it at debug level and returns []. The test for it, test_query_monitoring_m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericdelorefice
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6918#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6918
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6918
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6918
Reloadhttps://github.com/feast-dev/feast/pull/6918
Reloadhttps://github.com/feast-dev/feast/pull/6918
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ericdelorefice:trino-monitoring-errorshttps://github.com/ericdelorefice/feast/tree/trino-monitoring-errors
Conversationhttps://github.com/feast-dev/feast/pull/6918
Commits1 (1)https://github.com/feast-dev/feast/pull/6918/commits
Checkshttps://github.com/feast-dev/feast/pull/6918/checks
Files changedhttps://github.com/feast-dev/feast/pull/6918/files
fix: Raise Trino monitoring query errors other than a missing tablehttps://github.com/feast-dev/feast/pull/6918#top
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ericdelorefice:trino-monitoring-errorshttps://github.com/ericdelorefice/feast/tree/trino-monitoring-errors
https://github.com/ericdelorefice
ericdeloreficehttps://github.com/ericdelorefice
Oct 1, 2026https://github.com/feast-dev/feast/pull/6918#issue-5659770863
#6779https://github.com/feast-dev/feast/pull/6779
conventional commitshttps://www.conventionalcommits.org/
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918
https://github.com/ericdelorefice
ericdeloreficehttps://github.com/ericdelorefice
code ownerhttps://github.com/feast-dev/feast/blob/374f1d7aa00b340ee04e4b0cb9b3422c94e788f9/CODEOWNERS#L10
October 1, 2026 09:09https://github.com/feast-dev/feast/pull/6918#event-32237466754
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Oct 1, 2026https://github.com/feast-dev/feast/pull/6918#issuecomment-5928392251
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUwNjk5NDMsIm5iZiI6MTc5NTA2OTY0MywicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMTE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTExOVQwNjI3MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MjJkOWFlMDAyMmUxNmYyNmZiNDZlY2E4NTgxZWY2MjQ3NjYyM2FhZmZjMWJjMTRhODlkOTQyYTYzNmRhY2E5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.WQaIIfYXfaLABKE9Aypf8SCPoJ-RYrBhO4ZKTwXE7lE
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
fe27230https://app.codecov.io/gh/feast-dev/feast/commit/fe27230aaa191dce549d231c0b3963d88cbba89b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
cb584b6https://app.codecov.io/gh/feast-dev/feast/commit/cb584b6fd8ca823014a2ac6030f8f117b3135649?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Files with missing lineshttps://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
...ffline_stores/contrib/trino_offline_store/trino.pyhttps://app.codecov.io/gh/feast-dev/feast/pull/6918?src=pr&el=tree&filepath=sdk%2Fpython%2Ffeast%2Finfra%2Foffline_stores%2Fcontrib%2Ftrino_offline_store%2Ftrino.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9vZmZsaW5lX3N0b3Jlcy9jb250cmliL3RyaW5vX29mZmxpbmVfc3RvcmUvdHJpbm8ucHk=
4 Missing ⚠️ https://app.codecov.io/gh/feast-dev/feast/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/feast-dev/feast/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Flaghttps://app.codecov.io/gh/feast-dev/feast/pull/6918/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
go-feature-serverhttps://app.codecov.io/gh/feast-dev/feast/pull/6918/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
python-unithttps://app.codecov.io/gh/feast-dev/feast/pull/6918/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Files with missing lineshttps://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
...ffline_stores/contrib/trino_offline_store/trino.pyhttps://app.codecov.io/gh/feast-dev/feast/pull/6918?src=pr&el=tree&filepath=sdk%2Fpython%2Ffeast%2Finfra%2Foffline_stores%2Fcontrib%2Ftrino_offline_store%2Ftrino.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9vZmZsaW5lX3N0b3Jlcy9jb250cmliL3RyaW5vX29mZmxpbmVfc3RvcmUvdHJpbm8ucHk=
Continue to review full report in Codecov by Harnesshttps://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
fe27230...cb584b6https://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Oct 1, 2026https://github.com/feast-dev/feast/pull/6918#event-32239760658
https://github.com/ericdelorefice
ericdeloreficehttps://github.com/ericdelorefice
Oct 1, 2026 https://github.com/feast-dev/feast/pull/6918#ref-pullrequest-5662150370
fix: Report Dask monitoring read errors instead of no data #6920 https://github.com/feast-dev/feast/pull/6920
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
Oct 1, 2026 https://github.com/feast-dev/feast/pull/6918#pullrequestreview-5379252197
View reviewed changes https://github.com/feast-dev/feast/pull/6918/files/cb584b6fd8ca823014a2ac6030f8f117b3135649
https://github.com/ericdelorefice
https://github.com/ntkathole
fix: Raise Trino monitoring query errors other than a missing tablehttps://github.com/feast-dev/feast/pull/6918/commits/cb584b6fd8ca823014a2ac6030f8f117b3135649
cb584b6https://github.com/feast-dev/feast/pull/6918/commits/cb584b6fd8ca823014a2ac6030f8f117b3135649
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
force-pushedhttps://github.com/feast-dev/feast/compare/cd3265e02b5766c7767520291e4a849bde10d2ab..cb584b6fd8ca823014a2ac6030f8f117b3135649
cd3265ehttps://github.com/feast-dev/feast/commit/cd3265e02b5766c7767520291e4a849bde10d2ab
cb584b6https://github.com/feast-dev/feast/commit/cb584b6fd8ca823014a2ac6030f8f117b3135649
Compare https://github.com/feast-dev/feast/compare/cd3265e02b5766c7767520291e4a849bde10d2ab..cb584b6fd8ca823014a2ac6030f8f117b3135649
October 1, 2026 12:33https://github.com/feast-dev/feast/pull/6918#event-32251134196
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
6161766https://github.com/feast-dev/feast/commit/61617666751e3512e71449bc76a39b983b54de39
Oct 1, 2026https://github.com/feast-dev/feast/pull/6918#event-32251145684
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6918
https://github.com/ntkathole
ntkathole https://github.com/ntkathole
https://github.com/feast-dev/feast/pull/6918/files/cb584b6fd8ca823014a2ac6030f8f117b3135649
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Please reload this pagehttps://github.com/feast-dev/feast/pull/6918
https://github.com/ericdelorefice
https://github.com/codecov-commenter
https://github.com/ntkathole
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.