| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:23334734-afa3-9d9f-ab1e-6d7eb1ebe86b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9CCA:3FDE19:2BA19F:3A3FB5:6AFE96CA |
| html-safe-nonce | aaca999c219171f8361990ee98b4bdbb855c67e314716fe6a798fa2219870674 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Q0NBOjNGREUxOToyQkExOUY6M0EzRkI1OjZBRkU5NkNBIiwidmlzaXRvcl9pZCI6IjE3NzA2NDE5NjUxMTM1NzkyMTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | dd411eb9ac000cf6d0ed9b99ae27f57605ee156869277741122412abd8212f80 |
| hovercard-subject-tag | pull_request:4701645705 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/6918/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/711c059a3bbd2f04a10ef348638374256a3c4ad9d60f060765aca4d195599886/feast-dev/feast/pull/6918 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/711c059a3bbd2f04a10ef348638374256a3c4ad9d60f060765aca4d195599886/feast-dev/feast/pull/6918 |
| og:image:alt | What this PR does / why we need it:
Problem
TrinoOfflineStore.query_monitoring_metrics catches every TrinoQueryError, logs it at debug level and returns []. The test for it, test_query_monitoring_m... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ericdelorefice |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-cache |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/feast-dev/feast/pull/6918#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6918 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6918 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/6918 |
| Reload | https://github.com/feast-dev/feast/pull/6918 |
| Reload | https://github.com/feast-dev/feast/pull/6918 |
| feast-dev | https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
| Code | https://github.com/feast-dev/feast |
| Issues223 (223) | https://github.com/feast-dev/feast/issues |
| Pull requests143 (143) | https://github.com/feast-dev/feast/pulls |
| Discussions | https://github.com/feast-dev/feast/discussions |
| Actions | https://github.com/feast-dev/feast/actions |
| Security and quality1 (1) | https://github.com/feast-dev/feast/security |
| Insights | https://github.com/feast-dev/feast/insights |
| https://github.com/feast-dev/feast |
| ntkathole | https://github.com/ntkathole |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| ericdelorefice:trino-monitoring-errors | https://github.com/ericdelorefice/feast/tree/trino-monitoring-errors |
| Conversation | https://github.com/feast-dev/feast/pull/6918 |
| Commits1 (1) | https://github.com/feast-dev/feast/pull/6918/commits |
| Checks | https://github.com/feast-dev/feast/pull/6918/checks |
| Files changed | https://github.com/feast-dev/feast/pull/6918/files |
| fix: Raise Trino monitoring query errors other than a missing table | https://github.com/feast-dev/feast/pull/6918#top |
| ntkathole | https://github.com/ntkathole |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| ericdelorefice:trino-monitoring-errors | https://github.com/ericdelorefice/feast/tree/trino-monitoring-errors |
|
| https://github.com/ericdelorefice |
| ericdelorefice | https://github.com/ericdelorefice |
| Oct 1, 2026 | https://github.com/feast-dev/feast/pull/6918#issue-5659770863 |
| #6779 | https://github.com/feast-dev/feast/pull/6779 |
| conventional commits | https://www.conventionalcommits.org/ |
| Please reload this page | https://github.com/feast-dev/feast/pull/6918 |
| https://github.com/ericdelorefice |
| ericdelorefice | https://github.com/ericdelorefice |
| code owner | https://github.com/feast-dev/feast/blob/374f1d7aa00b340ee04e4b0cb9b3422c94e788f9/CODEOWNERS#L10 |
| October 1, 2026 09:09 | https://github.com/feast-dev/feast/pull/6918#event-32237466754 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Oct 1, 2026 | https://github.com/feast-dev/feast/pull/6918#issuecomment-5928392251 |
| Please reload this page | https://github.com/feast-dev/feast/pull/6918 |
| https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUwNjk5NDMsIm5iZiI6MTc5NTA2OTY0MywicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMTE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTExOVQwNjI3MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MjJkOWFlMDAyMmUxNmYyNmZiNDZlY2E4NTgxZWY2MjQ3NjYyM2FhZmZjMWJjMTRhODlkOTQyYTYzNmRhY2E5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.WQaIIfYXfaLABKE9Aypf8SCPoJ-RYrBhO4ZKTwXE7lE |
| Codecov | https://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| fe27230 | https://app.codecov.io/gh/feast-dev/feast/commit/fe27230aaa191dce549d231c0b3963d88cbba89b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| cb584b6 | https://app.codecov.io/gh/feast-dev/feast/commit/cb584b6fd8ca823014a2ac6030f8f117b3135649?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Files with missing lines | https://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| ...ffline_stores/contrib/trino_offline_store/trino.py | https://app.codecov.io/gh/feast-dev/feast/pull/6918?src=pr&el=tree&filepath=sdk%2Fpython%2Ffeast%2Finfra%2Foffline_stores%2Fcontrib%2Ftrino_offline_store%2Ftrino.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9vZmZsaW5lX3N0b3Jlcy9jb250cmliL3RyaW5vX29mZmxpbmVfc3RvcmUvdHJpbm8ucHk= |
| 4 Missing ⚠️ | https://app.codecov.io/gh/feast-dev/feast/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Codecov GitHub app | https://github.com/apps/codecov/installations/select_target |
| https://app.codecov.io/gh/feast-dev/feast/pull/6918?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Flag | https://app.codecov.io/gh/feast-dev/feast/pull/6918/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| go-feature-server | https://app.codecov.io/gh/feast-dev/feast/pull/6918/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| python-unit | https://app.codecov.io/gh/feast-dev/feast/pull/6918/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Files with missing lines | https://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| ...ffline_stores/contrib/trino_offline_store/trino.py | https://app.codecov.io/gh/feast-dev/feast/pull/6918?src=pr&el=tree&filepath=sdk%2Fpython%2Ffeast%2Finfra%2Foffline_stores%2Fcontrib%2Ftrino_offline_store%2Ftrino.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9vZmZsaW5lX3N0b3Jlcy9jb250cmliL3RyaW5vX29mZmxpbmVfc3RvcmUvdHJpbm8ucHk= |
| Continue to review full report in Codecov by Harness | https://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Codecov | https://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| fe27230...cb584b6 | https://app.codecov.io/gh/feast-dev/feast/pull/6918?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| comment docs | https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/feast-dev/feast/pull/6918 |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Oct 1, 2026 | https://github.com/feast-dev/feast/pull/6918#event-32239760658 |
| https://github.com/ericdelorefice |
| ericdelorefice | https://github.com/ericdelorefice |
|
Oct 1, 2026
| https://github.com/feast-dev/feast/pull/6918#ref-pullrequest-5662150370 |
|
fix: Report Dask monitoring read errors instead of no data
#6920
| https://github.com/feast-dev/feast/pull/6920 |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
|
Oct 1, 2026
| https://github.com/feast-dev/feast/pull/6918#pullrequestreview-5379252197 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/6918/files/cb584b6fd8ca823014a2ac6030f8f117b3135649 |
|
| https://github.com/ericdelorefice |
|
| https://github.com/ntkathole |
| fix: Raise Trino monitoring query errors other than a missing table | https://github.com/feast-dev/feast/pull/6918/commits/cb584b6fd8ca823014a2ac6030f8f117b3135649 |
| cb584b6 | https://github.com/feast-dev/feast/pull/6918/commits/cb584b6fd8ca823014a2ac6030f8f117b3135649 |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
| force-pushed | https://github.com/feast-dev/feast/compare/cd3265e02b5766c7767520291e4a849bde10d2ab..cb584b6fd8ca823014a2ac6030f8f117b3135649 |
| cd3265e | https://github.com/feast-dev/feast/commit/cd3265e02b5766c7767520291e4a849bde10d2ab |
| cb584b6 | https://github.com/feast-dev/feast/commit/cb584b6fd8ca823014a2ac6030f8f117b3135649 |
|
Compare
| https://github.com/feast-dev/feast/compare/cd3265e02b5766c7767520291e4a849bde10d2ab..cb584b6fd8ca823014a2ac6030f8f117b3135649 |
| October 1, 2026 12:33 | https://github.com/feast-dev/feast/pull/6918#event-32251134196 |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
| 6161766 | https://github.com/feast-dev/feast/commit/61617666751e3512e71449bc76a39b983b54de39 |
| Oct 1, 2026 | https://github.com/feast-dev/feast/pull/6918#event-32251145684 |
| Please reload this page | https://github.com/feast-dev/feast/pull/6918 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6918 |
|
| https://github.com/ntkathole |
|
ntkathole
| https://github.com/ntkathole |
|
| https://github.com/feast-dev/feast/pull/6918/files/cb584b6fd8ca823014a2ac6030f8f117b3135649 |
| Please reload this page | https://github.com/feast-dev/feast/pull/6918 |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Please reload this page | https://github.com/feast-dev/feast/pull/6918 |
|
| https://github.com/ericdelorefice |
|
| https://github.com/codecov-commenter |
|
| https://github.com/ntkathole |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |