René's URL Explorer Experiment


Title: feat: Make Milvus index and search params configurable by simonhearne · Pull Request #6917 · feast-dev/feast · GitHub

Open Graph Title: feat: Make Milvus index and search params configurable by simonhearne · Pull Request #6917 · feast-dev/feast

X Title: feat: Make Milvus index and search params configurable by simonhearne · Pull Request #6917 · feast-dev/feast

Description: The Open Source Feature Store for AI/ML. Contribute to feast-dev/feast development by creating an account on GitHub.

Open Graph Description: What this PR does / why we need it: Milvus search params were hard-coded to {"nprobe": 10} and index params to {"nlist": nlist}. index_type: AUTOINDEX (the only option on Zilliz...

X Description: What this PR does / why we need it: Milvus search params were hard-coded to {"nprobe": 10} and index params to {"nlist": nlist}. index_type: AUTOINDEX (the only ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6917

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5d7f067b-9aa0-16d9-0759-2fbe0f5811c0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC396:1EECAE:E07F70:1323824:6AFE9215
html-safe-nonce62e335ece1704c75fd6b3b567f4c488500078a4e3f4171635c905a878f343c97
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzk2OjFFRUNBRTpFMDdGNzA6MTMyMzgyNDo2QUZFOTIxNSIsInZpc2l0b3JfaWQiOiIzNDQ4NjkwNTYyNDQ4NjU4OTY1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac316d3974cc181187d5bf79b4490e0dd924cde27fb00fff5c0894cf0e7341a5b2
hovercard-subject-tagpull_request:4701239789
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/6917/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f0c94660b92bffadbbc3ab88e5efcc4d8700e18bb492d4fa714231c922e4b95c/feast-dev/feast/pull/6917
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f0c94660b92bffadbbc3ab88e5efcc4d8700e18bb492d4fa714231c922e4b95c/feast-dev/feast/pull/6917
og:image:altWhat this PR does / why we need it: Milvus search params were hard-coded to {"nprobe": 10} and index params to {"nlist": nlist}. index_type: AUTOINDEX (the only option on Zilliz...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesimonhearne
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6917#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6917
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6917
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6917
Reloadhttps://github.com/feast-dev/feast/pull/6917
Reloadhttps://github.com/feast-dev/feast/pull/6917
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
simonhearne:feat/milvus-index-search-paramshttps://github.com/simonhearne/feast/tree/feat/milvus-index-search-params
Conversationhttps://github.com/feast-dev/feast/pull/6917
Commits1 (1)https://github.com/feast-dev/feast/pull/6917/commits
Checkshttps://github.com/feast-dev/feast/pull/6917/checks
Files changedhttps://github.com/feast-dev/feast/pull/6917/files
feat: Make Milvus index and search params configurablehttps://github.com/feast-dev/feast/pull/6917#top
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
simonhearne:feat/milvus-index-search-paramshttps://github.com/simonhearne/feast/tree/feat/milvus-index-search-params
https://github.com/simonhearne
simonhearnehttps://github.com/simonhearne
Oct 1, 2026https://github.com/feast-dev/feast/pull/6917#issue-5659285395
conventional commitshttps://www.conventionalcommits.org/
#6882https://github.com/feast-dev/feast/pull/6882
#6895https://github.com/feast-dev/feast/pull/6895
Please reload this pagehttps://github.com/feast-dev/feast/pull/6917
https://github.com/simonhearne
simonhearnehttps://github.com/simonhearne
code ownerhttps://github.com/feast-dev/feast/blob/374f1d7aa00b340ee04e4b0cb9b3422c94e788f9/CODEOWNERS#L4
October 1, 2026 08:28https://github.com/feast-dev/feast/pull/6917#event-32234690855
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Oct 1, 2026https://github.com/feast-dev/feast/pull/6917#issuecomment-5927771759
Please reload this pagehttps://github.com/feast-dev/feast/pull/6917
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUwNjg3MzcsIm5iZiI6MTc5NTA2ODQzNywicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMTE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTExOVQwNjA3MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYTI2YzQwNjFhZmYxNzBhMTc5YTY2ZDFkNjA1MmE1MWEzZTI0NmY1OTZlOGYzOTUzYzMxMThhZGEyNTliZTM2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.MK3ehG1WHN5LNvA6Dul1C9a_rK76KXRnulUIyGHBnDM
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6917?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
fe27230https://app.codecov.io/gh/feast-dev/feast/commit/fe27230aaa191dce549d231c0b3963d88cbba89b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
c48b65dhttps://app.codecov.io/gh/feast-dev/feast/commit/c48b65d2dfd6ed12738bd05bb33cf73bb4a3e98e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/feast-dev/feast/pull/6917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Flaghttps://app.codecov.io/gh/feast-dev/feast/pull/6917/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
go-feature-serverhttps://app.codecov.io/gh/feast-dev/feast/pull/6917/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
fe27230https://app.codecov.io/gh/feast-dev/feast/commit/fe27230aaa191dce549d231c0b3963d88cbba89b?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
python-unithttps://app.codecov.io/gh/feast-dev/feast/pull/6917/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Click herehttps://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Files with missing lineshttps://app.codecov.io/gh/feast-dev/feast/pull/6917?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
.../infra/online_stores/milvus_online_store/milvus.pyhttps://app.codecov.io/gh/feast-dev/feast/pull/6917?src=pr&el=tree&filepath=sdk%2Fpython%2Ffeast%2Finfra%2Fonline_stores%2Fmilvus_online_store%2Fmilvus.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9vbmxpbmVfc3RvcmVzL21pbHZ1c19vbmxpbmVfc3RvcmUvbWlsdnVzLnB5
Continue to review full report in Codecov by Harnesshttps://app.codecov.io/gh/feast-dev/feast/pull/6917?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6917?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
6161766...c48b65dhttps://app.codecov.io/gh/feast-dev/feast/pull/6917?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/feast-dev/feast/pull/6917
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
force-pushedhttps://github.com/feast-dev/feast/compare/fe65208ad26510d3a91f986df2c954f219deb61f..37bbcb95c7d9ef0d99a9f4ecd4e7f7307a487ea0
fe65208https://github.com/feast-dev/feast/commit/fe65208ad26510d3a91f986df2c954f219deb61f
37bbcb9https://github.com/feast-dev/feast/commit/37bbcb95c7d9ef0d99a9f4ecd4e7f7307a487ea0
Compare https://github.com/feast-dev/feast/compare/fe65208ad26510d3a91f986df2c954f219deb61f..37bbcb95c7d9ef0d99a9f4ecd4e7f7307a487ea0
October 1, 2026 09:43https://github.com/feast-dev/feast/pull/6917#event-32239775032
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Oct 1, 2026https://github.com/feast-dev/feast/pull/6917#event-32239789468
https://github.com/simonhearne
https://github.com/claude
https://github.com/ntkathole
feat: Make Milvus index and search params configurablehttps://github.com/feast-dev/feast/pull/6917/commits/c48b65d2dfd6ed12738bd05bb33cf73bb4a3e98e
c48b65dhttps://github.com/feast-dev/feast/pull/6917/commits/c48b65d2dfd6ed12738bd05bb33cf73bb4a3e98e
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
force-pushedhttps://github.com/feast-dev/feast/compare/37bbcb95c7d9ef0d99a9f4ecd4e7f7307a487ea0..c48b65d2dfd6ed12738bd05bb33cf73bb4a3e98e
37bbcb9https://github.com/feast-dev/feast/commit/37bbcb95c7d9ef0d99a9f4ecd4e7f7307a487ea0
c48b65dhttps://github.com/feast-dev/feast/commit/c48b65d2dfd6ed12738bd05bb33cf73bb4a3e98e
Compare https://github.com/feast-dev/feast/compare/37bbcb95c7d9ef0d99a9f4ecd4e7f7307a487ea0..c48b65d2dfd6ed12738bd05bb33cf73bb4a3e98e
October 1, 2026 12:34https://github.com/feast-dev/feast/pull/6917#event-32251171567
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
ef743ffhttps://github.com/feast-dev/feast/commit/ef743ff9e49af3e1dac30da69a18eee0df908334
Oct 1, 2026https://github.com/feast-dev/feast/pull/6917#event-32251323630
Please reload this pagehttps://github.com/feast-dev/feast/pull/6917
feat: Add consistency_level to the Milvus online store config #6921 https://github.com/feast-dev/feast/pull/6921
feat: Support Milvus partition keys in the Milvus online store #6940 https://github.com/feast-dev/feast/pull/6940
https://github.com/simonhearne
simonhearnehttps://github.com/simonhearne
Oct 16, 2026 https://github.com/feast-dev/feast/pull/6917#ref-pullrequest-5881410688
feat: Add native_numeric_types to the Milvus online store #7025 https://github.com/feast-dev/feast/pull/7025
feat: Add row deletion to the Milvus online store #7082 https://github.com/feast-dev/feast/pull/7082
feat: Add num_partitions and partition_key_isolation to the Milvus online store #7083 https://github.com/feast-dev/feast/pull/7083
fix: Break event timestamp ties by created timestamp in Milvus write batches #7084 https://github.com/feast-dev/feast/pull/7084
feat: Add a schema check and mutation timeout to the Milvus online store #7118 https://github.com/feast-dev/feast/pull/7118
fix: Round-trip every Feast type and null in the Milvus online store #7119 https://github.com/feast-dev/feast/pull/7119
feat: Add native complex types and scalar index tags to the Milvus online store #7120 https://github.com/feast-dev/feast/pull/7120
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6917
Please reload this pagehttps://github.com/feast-dev/feast/pull/6917
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Please reload this pagehttps://github.com/feast-dev/feast/pull/6917
https://github.com/simonhearne
https://github.com/codecov-commenter
https://github.com/ntkathole
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.