René's URL Explorer Experiment


Title: fix: Make vector length validation reachable, schema-driven and vectorized by haoxu0 · Pull Request #6909 · feast-dev/feast · GitHub

Open Graph Title: fix: Make vector length validation reachable, schema-driven and vectorized by haoxu0 · Pull Request #6909 · feast-dev/feast

X Title: fix: Make vector length validation reachable, schema-driven and vectorized by haoxu0 · Pull Request #6909 · feast-dev/feast

Description: Fixes three of the five items in #6907. 1. Validation was unreachable from the batch path _validate_vector_features had a single call site, inside _get_feature_view_and_df_for_online_write. So: entry point before after write_to_online_store validated validated materialize not validated validated materialize_incremental not validated validated Embedding workloads are overwhelmingly batch, so the path actually carrying vectors at volume was the unvalidated one. Rather than patch each engine, this uses the one place they all funnel through: utils._convert_arrow_to_proto. The local, spark, ray, flink, kubernetes and aws_lambda engines plus PassthroughProvider all call it, so a single Arrow-level check in _convert_arrow_fv_to_proto covers all of them. The new _validate_vector_field_lengths is O(1) for fixed_size_list (compares type.list_size) and one vectorized pass for list/large_list, so it is cheap enough to leave on unconditionally. Null rows are tolerated. A non-list column carrying a declared vector_length is an error. One known gap: the snowflake compute engine builds its rows directly rather than via _convert_arrow_to_proto, so it is not covered. Happy to extend if preferred, but it needs a different seam. 2. The check assumed the vector was the first feature if feature_view.features and feature_view.features[0].vector_index: Declaring any field ahead of the vector field silently disabled validation entirely. Both validators now resolve the field with _get_feature_view_vector_field_metadata(), which scans feature_view.schema, raises on more than one vector field, and is already used in three other places in feature_store.py. There are regression tests for this on both paths. 3. iterrows() did not scale Replaced with a single pass over the column. Measured on 200k rows: before (iterrows): 1.508s after: 0.025s (~60x) The row index and both distinct failure messages are preserved. Deliberately not included #6907 items 3 and 5 are behaviour decisions rather than clear-cut fixes, so they are left for discussion there: requiring vector_length when vector_index=True (today vector_length=0 is the default and means "skip") whether Field.__eq__ should compare vector_index and vector_search_metric, which are currently commented out Testing New sdk/python/tests/unit/test_vector_length_validation.py, 16 tests across both validators: fixed-size and variable-size lists, first offending row reporting, vector field not first, unset vector_length, null rows, missing column, non-list type, RecordBatch input, and numpy vectors. No behaviour change for feature views that do not set vector_length, since 0 still short-circuits. Verified no regressions against master by running the relevant suites on both sides: test_utils.py, test_vector_store.py, test_vector_store_utils.py, test_doc_embedder.py, test_precomputed_feature_vectors.py, plus the new file — 121 passed online_store/test_online_retrieval.py and test_on_demand_python_transformation.py — identical results on both sides across 3 runs each (one pre-existing failure from Torch not being installed locally) mypy feast/utils.py feast/feature_store.py — same 2 pre-existing errors before and after ruff check and ruff format --check clean

Open Graph Description: Fixes three of the five items in #6907. 1. Validation was unreachable from the batch path _validate_vector_features had a single call site, inside _get_feature_view_and_df_for_online_write. So: ...

X Description: Fixes three of the five items in #6907. 1. Validation was unreachable from the batch path _validate_vector_features had a single call site, inside _get_feature_view_and_df_for_online_write. So: ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6909

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d5206279-19bb-e40f-d272-90350267ea03
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB47E:3C4BAF:2B754A:3C096F:6AFE9837
html-safe-nonce97ba222598f52d4c5b9cf19d4db199053f9ef19b11ea821a63e36c9f0817eb41
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDdFOjNDNEJBRjoyQjc1NEE6M0MwOTZGOjZBRkU5ODM3IiwidmlzaXRvcl9pZCI6IjQxMzcxNzgxMTQ5NjQ3NTY1MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8985408982405cb00506344afa6d71d17e4ecdf52bef06abda4fd940682a2fc1
hovercard-subject-tagpull_request:4694108108
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6909/files
twitter:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/20422210?s=400&v=4
og:image:altFixes three of the five items in #6907. 1. Validation was unreachable from the batch path _validate_vector_features had a single call site, inside _get_feature_view_and_df_for_online_write. So: ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6909/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6909%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6909%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6909/files
Reloadhttps://github.com/feast-dev/feast/pull/6909/files
Reloadhttps://github.com/feast-dev/feast/pull/6909/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
haoxu0:fix/vector-length-validationhttps://github.com/haoxu0/feast/tree/fix/vector-length-validation
Conversation 8 https://github.com/feast-dev/feast/pull/6909
Commits 2 https://github.com/feast-dev/feast/pull/6909/commits
Checks 23 https://github.com/feast-dev/feast/pull/6909/checks
Files changed https://github.com/feast-dev/feast/pull/6909/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6909/files
fix: Make vector length validation reachable, schema-driven and vectorized https://github.com/feast-dev/feast/pull/6909/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6909/files
c2cbfeb fix: Make vector length validation reachable, schema-driven and vecto… haoxu0 Sep 30, 2026 https://github.com/feast-dev/feast/pull/6909/commits/c2cbfeb7aaa53113c0457bf3898cd6680ed59009
2aa437b fix: Address review feedback on vector length validation haoxu0 Oct 1, 2026 https://github.com/feast-dev/feast/pull/6909/commits/2aa437bbedf02a09eeeda5d9254d9ab0a9da7cf4
Clear filters https://github.com/feast-dev/feast/pull/6909/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6909/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6909/files
feature_store.py https://github.com/feast-dev/feast/pull/6909/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
utils.py https://github.com/feast-dev/feast/pull/6909/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
test_vector_length_validation.py https://github.com/feast-dev/feast/pull/6909/files#diff-446773ebddf62487e5431b1e31032d3c56af1b00acb3766ab9e8b81aac2b59b9
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_store.pyhttps://github.com/feast-dev/feast/pull/6909/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
View file https://github.com/haoxu0/feast/blob/2aa437bbedf02a09eeeda5d9254d9ab0a9da7cf4/sdk/python/feast/feature_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6909/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6909/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/pull/6909/files#diff-ff4e2a65c8c29b7971edc77a61a7e970d410d77d9f173f72714d1bb49e2509a2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/utils.pyhttps://github.com/feast-dev/feast/pull/6909/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
View file https://github.com/haoxu0/feast/blob/2aa437bbedf02a09eeeda5d9254d9ab0a9da7cf4/sdk/python/feast/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6909/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6909/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6909/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6909/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6909/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
Please reload this pagehttps://github.com/feast-dev/feast/pull/6909/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6909/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.