René's URL Explorer Experiment


Title: fix: Serve aliased on demand feature views in feature services by breken-ai · Pull Request #6901 · feast-dev/feast · GitHub

Open Graph Title: fix: Serve aliased on demand feature views in feature services by breken-ai · Pull Request #6901 · feast-dev/feast

X Title: fix: Serve aliased on demand feature views in feature services by breken-ai · Pull Request #6901 · feast-dev/feast

Description: What this PR does / why we need it: If an on demand feature view is added to a FeatureService under an alias, its features are silently missing from online responses. service = FeatureService( name="driver_service", features=[driver_stats_fv, scaled.with_name("scaled_alias")], ) store.get_online_features(entity_rows=[{"driver_id": 1001}], features=service) # -> {"driver_id": [...], "conv_rate": [...]} # conv_rate_x10 from the aliased ODFV is missing, no error raised The feature service's refs use the projection name, so they read scaled_alias:conv_rate_x10. _group_feature_refs and _get_feature_views_to_use resolve that ref through projection.name_to_use(). _augment_response_with_on_demand_transforms is different: it keys requested_odfv_map by odfv.name, which is scaled. The aliased ref never matches, the transform is skipped, and the requested feature is dropped from the response. Pandas and python modes are both affected. with_name is the public aliasing API for ODFVs (#1872), and the same function already builds full names from projection.name_to_use(), so aliases are meant to work here. The fix keys the map by projection.name_alias when one is set and falls back to odfv.name. Versioned refs are unchanged, because _parse_feature_ref strips @vN before the lookup. Which issue(s) this PR fixes: No existing issue. I searched open issues and PRs for ODFV aliases and with_name in feature services and didn't find a match. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change New test_feature_service_serves_aliased_odfv_features[pandas|python] in tests/unit/test_on_demand_pandas_transformation.py. It serves a feature service that holds odfv.with_name(...) and checks the default names in both modes and the full names (scaled_alias__conv_rate_x10) in pandas mode. On master (3667772) both cases fail with KeyError: 'conv_rate_x10'. With this change both pass. The ODFV, feature service, online response, versioning and feature store unit files (17 files) give 232 passed. The same 5 tests fail with and without the change: three TestOnDemandTransformationsWithWrites tests hit the UDF globals NameError tracked in #6815, and two tensor tests need torch. ruff check, ruff format --check and mypy feast/utils.py are clean. Misc This PR only fixes online serving. get_historical_features with the same aliased feature service fails loudly with Could not find feature view from reference scaled_alias:conv_rate_x10, because offline stores re-fetch ODFVs from the registry by name. That is part of the ODFV handling cleanup in #5890. The python mode full-name case is fixed separately in #6900. This change was prepared with an AI coding assistant, and the tests and checks above were run locally.

Open Graph Description: What this PR does / why we need it: If an on demand feature view is added to a FeatureService under an alias, its features are silently missing from online responses. service = FeatureService( ...

X Description: What this PR does / why we need it: If an on demand feature view is added to a FeatureService under an alias, its features are silently missing from online responses. service = FeatureService( ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6901

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b1d4f099-dbc5-deee-d729-d9ef0eefc1dc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD5D0:2A16C9:130524F:193E14F:6AFEAD9A
html-safe-nonceebb483f66baace7b62e825e34e8dba0ebe7fbf74d19881ac7037fd3c02172ff6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENUQwOjJBMTZDOToxMzA1MjRGOjE5M0UxNEY6NkFGRUFEOUEiLCJ2aXNpdG9yX2lkIjoiMjI4OTc1MjIwMzc5NzExNDI2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9815867d01edcfec5f2f7117c07c72bd4eb899be12864a67b10cf646d13b07fa
hovercard-subject-tagpull_request:4685062570
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6901/files
twitter:imagehttps://avatars.githubusercontent.com/u/312387581?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/312387581?s=400&v=4
og:image:altWhat this PR does / why we need it: If an on demand feature view is added to a FeatureService under an alias, its features are silently missing from online responses. service = FeatureService( ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6901/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6901%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6901%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6901/files
Reloadhttps://github.com/feast-dev/feast/pull/6901/files
Reloadhttps://github.com/feast-dev/feast/pull/6901/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
breken-ai:fix/odfv-alias-online-featureshttps://github.com/breken-ai/feast/tree/fix/odfv-alias-online-features
Conversation 2 https://github.com/feast-dev/feast/pull/6901
Commits 1 https://github.com/feast-dev/feast/pull/6901/commits
Checks 1 https://github.com/feast-dev/feast/pull/6901/checks
Files changed https://github.com/feast-dev/feast/pull/6901/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6901/files
fix: Serve aliased on demand feature views in feature services https://github.com/feast-dev/feast/pull/6901/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6901/files
95a4ef6 fix: Serve aliased on demand feature views in feature services breken-ai Sep 30, 2026 https://github.com/feast-dev/feast/pull/6901/commits/95a4ef6229b9fcda1829450cf27c9fa4a69a3bc5
Clear filters https://github.com/feast-dev/feast/pull/6901/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6901/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6901/files
utils.py https://github.com/feast-dev/feast/pull/6901/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
test_on_demand_pandas_transformation.py https://github.com/feast-dev/feast/pull/6901/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/utils.pyhttps://github.com/feast-dev/feast/pull/6901/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
View file https://github.com/breken-ai/feast/blob/95a4ef6229b9fcda1829450cf27c9fa4a69a3bc5/sdk/python/feast/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6901/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6901/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6901/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_on_demand_pandas_transformation.pyhttps://github.com/feast-dev/feast/pull/6901/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
View file https://github.com/breken-ai/feast/blob/95a4ef6229b9fcda1829450cf27c9fa4a69a3bc5/sdk/python/tests/unit/test_on_demand_pandas_transformation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6901/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6901/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/pull/6901/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/pull/6901/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.