René's URL Explorer Experiment


Title: fix: Return python mode ODFV features with full feature names by breken-ai · Pull Request #6900 · feast-dev/feast · GitHub

Open Graph Title: fix: Return python mode ODFV features with full feature names by breken-ai · Pull Request #6900 · feast-dev/feast

X Title: fix: Return python mode ODFV features with full feature names by breken-ai · Pull Request #6900 · feast-dev/feast

Description: What this PR does / why we need it: Online serving drops python mode on demand feature views when full_feature_names=True. store.get_online_features( entity_rows=[{"driver_id": 1001}], features=["driver_hourly_stats:conv_rate", "python_view:conv_rate_plus_acc"], full_feature_names=True, ) # -> {"driver_id": [...], "driver_hourly_stats__conv_rate": [...]} # python_view__conv_rate_plus_acc is missing, no error raised In _augment_response_with_on_demand_transforms, a full-name request looks for "__". The pandas path gets that name because transform_arrow renames its outputs. The python path uses transform_dict, which returns the UDF's short output names. Nothing matches, so selected_subset is empty and the feature disappears from the response. Batch and singleton=True python ODFVs are both affected. A model client that asks for full names gets a KeyError or a silently missing input, and the same request in pandas mode works. The fix adds a full_feature_names parameter to OnDemandFeatureView.transform_dict, as suggested in review. A new _postprocess_feature_dict renames outputs the same way _postprocess_arrow_table does, so transform_dict, transform_arrow and transform_ibis all name their outputs consistently for any caller. The online path passes full_feature_names through. The declared schema type is also looked up under the full name. Without that, full-name values fell back to type inference instead of the declared dtype. Which issue(s) this PR fixes: No existing issue. I searched open issues and PRs for full_feature_names with python mode or ODFVs and didn't find a match. This PR also adds the alias + python mode + full_feature_names coverage requested by @ntkathole on #6901. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Branch rebased on master @ 9d42729 (includes #6901). test_python_views_with_full_feature_names (test_on_demand_python_transformation.py): requests a pandas ODFV, a batch python ODFV and a singleton python ODFV with full_feature_names=True. On the original base (3667772), only pandas_view__conv_rate_plus_acc_pandas came back and both python outputs were missing. Passes with this change. The aliased test below shows the same python mode gap on current master @ 9d42729. test_feature_service_serves_aliased_odfv_features[pandas|python|python_singleton] (test_on_demand_pandas_transformation.py): an ODFV added to a feature service with with_name("scaled_alias"), served with default and full names, so this covers alias + python mode + full_feature_names together. On master (has #6901, not this fix): [pandas] passes; [python] and [python_singleton] fail with Right contains one more item: 'scaled_alias__conv_rate_x10'. With #6901's alias lookup reverted on this branch: all three fail with KeyError: 'conv_rate_x10'. With this change: all three pass. test_transform_dict_full_feature_names[batch|singleton]: calls transform_dict directly and checks short names by default, plus_one__val_plus_one with full_feature_names=True, and alias__val_plus_one after with_name("alias"). It fails against the first revision of this PR (TypeError: transform_dict() got an unexpected keyword argument 'full_feature_names') and passes now. Across the ODFV, transformation, feature service, online response, versioning, utils and feature store unit files, this branch gives 184 passed and master gives 180. Both have the same 7 failures and 7 collection errors locally: missing torch, the TestOnDemandTransformationsWithWrites UDF globals NameError tracked in #6815, two serve_registry tests, and two modules that need deps not installed here. ruff check, ruff format --check and mypy feast/on_demand_feature_view.py feast/utils.py are clean. Misc This change was prepared with an AI coding assistant, and the tests and checks above were run locally.

Open Graph Description: What this PR does / why we need it: Online serving drops python mode on demand feature views when full_feature_names=True. store.get_online_features( entity_rows=[{"driver_id": 1001}]...

X Description: What this PR does / why we need it: Online serving drops python mode on demand feature views when full_feature_names=True. store.get_online_features( entity_rows=[{"driver_id"...

Opengraph URL: https://github.com/feast-dev/feast/pull/6900

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7ed9d4f5-15af-434a-1d6a-d8a576b0dc2e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA05E:F9808:135B517:199F997:6AFEAC04
html-safe-nonce9f835ce89892dae1a85642ed48b4b8dd8cf46c60be4a2d5a1c9614a2da750ebd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDVFOkY5ODA4OjEzNUI1MTc6MTk5Rjk5Nzo2QUZFQUMwNCIsInZpc2l0b3JfaWQiOiI1ODgyMjMxODc4NjA5NDQ3OTQwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5d24e09fdb36288d02fc691c54b66351b15d154fec677213993bae8dddf23721
hovercard-subject-tagpull_request:4685023389
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6900/files
twitter:imagehttps://avatars.githubusercontent.com/u/312387581?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/312387581?s=400&v=4
og:image:altWhat this PR does / why we need it: Online serving drops python mode on demand feature views when full_feature_names=True. store.get_online_features( entity_rows=[{"driver_id": 1001}]...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6900/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6900%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6900%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6900/files
Reloadhttps://github.com/feast-dev/feast/pull/6900/files
Reloadhttps://github.com/feast-dev/feast/pull/6900/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
breken-aihttps://github.com/breken-ai
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
breken-ai:fix/python-odfv-full-feature-nameshttps://github.com/breken-ai/feast/tree/fix/python-odfv-full-feature-names
Conversation 2 https://github.com/feast-dev/feast/pull/6900
Commits 2 https://github.com/feast-dev/feast/pull/6900/commits
Checks 25 https://github.com/feast-dev/feast/pull/6900/checks
Files changed https://github.com/feast-dev/feast/pull/6900/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6900/files
fix: Return python mode ODFV features with full feature names https://github.com/feast-dev/feast/pull/6900/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6900/files
78eb277 fix: Return python mode ODFV features with full feature names breken-ai Sep 30, 2026 https://github.com/feast-dev/feast/pull/6900/commits/78eb277253ecfd1f90348aa44814c06dcc1ef51c
6976dbb fix: Rename python mode ODFV outputs inside transform_dict breken-ai Oct 8, 2026 https://github.com/feast-dev/feast/pull/6900/commits/6976dbb2d77675e720b5d67d91b4fef91bdf604d
Clear filters https://github.com/feast-dev/feast/pull/6900/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6900/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6900/files
on_demand_feature_view.py https://github.com/feast-dev/feast/pull/6900/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
utils.py https://github.com/feast-dev/feast/pull/6900/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
test_on_demand_pandas_transformation.py https://github.com/feast-dev/feast/pull/6900/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
test_on_demand_python_transformation.py https://github.com/feast-dev/feast/pull/6900/files#diff-46d1f82f026e0c5d18f4e6ab7edf6e1f24132925324ac962fd26efe32683c41b
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/on_demand_feature_view.pyhttps://github.com/feast-dev/feast/pull/6900/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
View file https://github.com/feast-dev/feast/blob/6976dbb2d77675e720b5d67d91b4fef91bdf604d/sdk/python/feast/on_demand_feature_view.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6900/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6900/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/6900/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/pull/6900/files#diff-eae3cfbedbd8b8c1e67b1f4b031c342b423fad9c69648ea58bc4ba3d7be83ac0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/utils.pyhttps://github.com/feast-dev/feast/pull/6900/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
View file https://github.com/feast-dev/feast/blob/6976dbb2d77675e720b5d67d91b4fef91bdf604d/sdk/python/feast/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6900/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6900/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6900/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6900/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6900/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_on_demand_pandas_transformation.pyhttps://github.com/feast-dev/feast/pull/6900/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
View file https://github.com/feast-dev/feast/blob/6976dbb2d77675e720b5d67d91b4fef91bdf604d/sdk/python/tests/unit/test_on_demand_pandas_transformation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6900/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6900/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/pull/6900/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/pull/6900/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/pull/6900/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_on_demand_python_transformation.pyhttps://github.com/feast-dev/feast/pull/6900/files#diff-46d1f82f026e0c5d18f4e6ab7edf6e1f24132925324ac962fd26efe32683c41b
View file https://github.com/feast-dev/feast/blob/6976dbb2d77675e720b5d67d91b4fef91bdf604d/sdk/python/tests/unit/test_on_demand_python_transformation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6900/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6900/files#diff-46d1f82f026e0c5d18f4e6ab7edf6e1f24132925324ac962fd26efe32683c41b
https://github.com/feast-dev/feast/pull/6900/files#diff-46d1f82f026e0c5d18f4e6ab7edf6e1f24132925324ac962fd26efe32683c41b
https://github.com/feast-dev/feast/pull/6900/files#diff-46d1f82f026e0c5d18f4e6ab7edf6e1f24132925324ac962fd26efe32683c41b
https://github.com/feast-dev/feast/pull/6900/files#diff-46d1f82f026e0c5d18f4e6ab7edf6e1f24132925324ac962fd26efe32683c41b
Please reload this pagehttps://github.com/feast-dev/feast/pull/6900/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.