| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9f2b7581-bcf4-7e14-ca04-dcc3a2259ec2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A9B0:342711:2CEFA5:3BF891:6AFE987F |
| html-safe-nonce | d2ff2adac134887b6e802b6a1fe416363e5d8858476c4775404e53cab54e54fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUIwOjM0MjcxMToyQ0VGQTU6M0JGODkxOjZBRkU5ODdGIiwidmlzaXRvcl9pZCI6IjEzODcwMjExMDgzNDcwNTAxMTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5e5a76f9dd05c94f034a163e85dfdc60520fe886980f0392c20d9201db229307 |
| hovercard-subject-tag | pull_request:4682820519 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6898/files |
| twitter:image | https://avatars.githubusercontent.com/u/8094255?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8094255?s=400&v=4 |
| og:image:alt | What this PR does / why we need it:
Adds Trino as a native Feast compute engine (type: trino.engine or type: trino), enabling DAG-based historical feature retrieval and materialization directly via... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/6898/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6898%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6898%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/6898/files |
| Reload | https://github.com/feast-dev/feast/pull/6898/files |
| Reload | https://github.com/feast-dev/feast/pull/6898/files |
| feast-dev | https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
| Code | https://github.com/feast-dev/feast |
| Issues223 (223) | https://github.com/feast-dev/feast/issues |
| Pull requests143 (143) | https://github.com/feast-dev/feast/pulls |
| Discussions | https://github.com/feast-dev/feast/discussions |
| Actions | https://github.com/feast-dev/feast/actions |
| Security and quality1 (1) | https://github.com/feast-dev/feast/security |
| Insights | https://github.com/feast-dev/feast/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| ntkathole | https://github.com/ntkathole |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| Marcus-Rosti:mrosti/trino-compute | https://github.com/Marcus-Rosti/feast/tree/mrosti/trino-compute |
|
Conversation
15
| https://github.com/feast-dev/feast/pull/6898 |
|
Commits
10
| https://github.com/feast-dev/feast/pull/6898/commits |
|
Checks
23
| https://github.com/feast-dev/feast/pull/6898/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/6898/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/6898/files |
|
feat: Add Trino compute engine for batch retrieval and materialization
| https://github.com/feast-dev/feast/pull/6898/files#top |
|
Show all changes
10 commits
| https://github.com/feast-dev/feast/pull/6898/files |
|
7e6b80e
feat: Adds Trino as a compute engine
Marcus-Rosti Sep 29, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/7e6b80e5439b6ef78ad5320b3f810b3eba995319 |
|
45ae953
fix: Join entity_df during backfill
Marcus-Rosti Oct 2, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/45ae95376aa49bdb2267efbbfbcbe40e7cb2d326 |
|
297224e
fix: Exclude internal _feast_rn column from Trino dedup output
Marcus-Rosti Oct 2, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/297224e880b878010b313750ddb35417e63fb169 |
|
2c3e632
fix: Adds a trino write type (append/merge/overwrite)
Marcus-Rosti Oct 3, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/2c3e632997847e8b182653efaebb0d4fdaafc983 |
|
1d799d5
fix: Throw an error when semicolons are present in filters
Marcus-Rosti Oct 6, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/1d799d5d5955b6b0c00db3a543f6eae2ed0561c1 |
|
efcc389
fix: Throw error when client is not configured
Marcus-Rosti Oct 6, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/efcc38977314109eef5bd8186ef0e092f1dd80b6 |
|
6c3e2ef
fix: Implements a trino integration test
Marcus-Rosti Oct 6, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/6c3e2efac706231db1b3509198403cab2a8aeed6 |
|
ac3364c
fix: More efficient streaming for pyarrow
Marcus-Rosti Oct 6, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/ac3364c64e3e1b4192592ec3760babf99d938294 |
|
42b6a7d
fix: Qualified select statements
Marcus-Rosti Oct 6, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/42b6a7d0de266a5712191659487a968ca31cce2d |
|
ecb671a
fix: Validate Trino client configuration in historical retrieval
Marcus-Rosti Oct 6, 2026
| https://github.com/feast-dev/feast/pull/6898/commits/ecb671ac005c0002a227a984d97fcc43b4366984 |
|
Clear filters
| https://github.com/feast-dev/feast/pull/6898/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/6898/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/6898/files |
|
compute-engine.md
| https://github.com/feast-dev/feast/pull/6898/files#diff-3a2432cc9f8bed7a94a0fad37ede430a0b9a1b9ed6c05f71c1ceb850da6d1c95 |
|
trino.md
| https://github.com/feast-dev/feast/pull/6898/files#diff-b6feeec8a4b24c019e343385f1d80fe36f35f17ab208e15b0757fd27f3d52165 |
|
model.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-702e08391378ad77548e5d3795efc4d213b1b1abfbe61287b944728ebb2ecdf1 |
|
__init__.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-7edd808146013669a992b7380effc4362e7d7491abd1ad27fed6d0ce53faddf0 |
|
compute.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-72dbd4100b72b967e7059a93ea6a877857f838fa6ff149eac18bbd3603118edf |
|
feature_builder.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-3bf7e5ebf62fe2e6d41588b3aefd86905a65e3a3f96ae1b14b8513730eb0bd21 |
|
job.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-a946740b2331f24b89a75241ce9c7980e90a6e84064e2371f1c24c3005d34167 |
|
nodes.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-ae3fa3148a7422ab61c5eb6a704014b0bc676f063fcd16e610169095580075ee |
|
sql_builder.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-715f5d61761ad2adfaba4fe83080c8112c6022ef12a2b6a8c8093f4ec8208fe9 |
|
utils.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-b1559dc9f7fd89d6b2055dab420e132d80b5e9e152e708a08b4b1ea309f5ad57 |
|
trino_queries.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-43501c8c77d529114e44cab644a3ae663ddbca25c19f6b8e4c0ce497dd13ca79 |
|
repo_config.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-c90c6781dcec3cdcc26843e013d3d6e9c1ce89d084b3a67e818fe76a0c7d0436 |
|
mode.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-7190e9b257c57a9dae5574f463ca598dc7d1ea797e6ebbe6d49d82e2a3cd3864 |
|
trino_transformation.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-86a623ef1d448b05a5c3659910b7710f50175b6e517c9b62a94d9a0f85ad47ac |
|
test_compute.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-4cd20c66c76ec28f7f5a57be582b8d0f8c3c7ba879b3f4f7ee2336dfcc610b0e |
|
test_trino_compute_engine.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-457537948cc82ae75e8a27be3870346813dcea6deff5ee07d03f5bfd5e64b222 |
|
test_trino_compute_engine.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-b26a4f1614573c06f8ac79453d759d27c815f76b7d343bf644a735e19bec9fa0 |
|
test_mode.py
| https://github.com/feast-dev/feast/pull/6898/files#diff-296165b4155190a9461aa37e732452433cab22f6186f48383b339b45b34d25c8 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4 |
| docs/getting-started/components/compute-engine.md | https://github.com/feast-dev/feast/pull/6898/files#diff-3a2432cc9f8bed7a94a0fad37ede430a0b9a1b9ed6c05f71c1ceb850da6d1c95 |
|
View file
| https://github.com/Marcus-Rosti/feast/blob/ecb671ac005c0002a227a984d97fcc43b4366984/docs/getting-started/components/compute-engine.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/6898/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/6898/files#diff-3a2432cc9f8bed7a94a0fad37ede430a0b9a1b9ed6c05f71c1ceb850da6d1c95 |
|
| https://github.com/feast-dev/feast/pull/6898/files#diff-3a2432cc9f8bed7a94a0fad37ede430a0b9a1b9ed6c05f71c1ceb850da6d1c95 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4 |
| docs/reference/compute-engine/trino.md | https://github.com/feast-dev/feast/pull/6898/files#diff-b6feeec8a4b24c019e343385f1d80fe36f35f17ab208e15b0757fd27f3d52165 |
|
View file
| https://github.com/Marcus-Rosti/feast/blob/ecb671ac005c0002a227a984d97fcc43b4366984/docs/reference/compute-engine/trino.md |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/6898/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/infra/compute_engines/dag/model.py | https://github.com/feast-dev/feast/pull/6898/files#diff-702e08391378ad77548e5d3795efc4d213b1b1abfbe61287b944728ebb2ecdf1 |
|
View file
| https://github.com/Marcus-Rosti/feast/blob/ecb671ac005c0002a227a984d97fcc43b4366984/sdk/python/feast/infra/compute_engines/dag/model.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/6898/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/6898/files#diff-702e08391378ad77548e5d3795efc4d213b1b1abfbe61287b944728ebb2ecdf1 |
|
| https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10 |
| sdk/python/feast/infra/compute_engines/trino/__init__.py | https://github.com/feast-dev/feast/pull/6898/files#diff-7edd808146013669a992b7380effc4362e7d7491abd1ad27fed6d0ce53faddf0 |
|
View file
| https://github.com/Marcus-Rosti/feast/blob/ecb671ac005c0002a227a984d97fcc43b4366984/sdk/python/feast/infra/compute_engines/trino/__init__.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/6898/{{ revealButtonHref }} |
| Please reload this page | https://github.com/feast-dev/feast/pull/6898/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/6898/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |