René's URL Explorer Experiment


Title: fix: Bound Arrow Flight batch size in the offline server by dbbvitor · Pull Request #6896 · feast-dev/feast · GitHub

Open Graph Title: fix: Bound Arrow Flight batch size in the offline server by dbbvitor · Pull Request #6896 · feast-dev/feast

X Title: fix: Bound Arrow Flight batch size in the offline server by dbbvitor · Pull Request #6896 · feast-dev/feast

Description: What this PR does / why we need it: The offline server's do_get() and do_exchange() Flight handlers each returned a single, unbounded Arrow Table/RecordBatch to the client. Once a result approaches Arrow IPC's per-batch limit, sending it raises: ArrowInvalid: Cannot send record batches exceeding 2GiB yet and the whole request fails instead of degrading gracefully. This adds two module-level helpers in offline_server.py: _split_oversized(batch) recursively halves any RecordBatch whose IPC-encoded size exceeds _MAX_BATCH_BYTES (1.5GB, comfortably under the 2GiB cap). It stops recursing at a single row and yields it as-is, so Flight still raises its own clear error for a genuinely oversized row instead of looping forever. _bounded_reader(data) accepts either a pa.Table or a pa.RecordBatchReader and re-batches it through _split_oversized. Both read paths are routed through _bounded_reader: do_get returns fl.RecordBatchStream(_bounded_reader(table)) instead of streaming the raw table directly. do_exchange (the newer HPA-safe single-stream read path added in bae07fc4c) now writes batches in a loop over the bounded reader instead of one writer.write_table(table) call, it was still writing one unbounded table and needed the same fix as do_get. Which issue(s) this PR fixes: Part of #6863 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests New/updated unit tests in sdk/python/tests/unit/test_offline_server.py cover _split_oversized/_bounded_reader directly (oversized splitting, exact-cap boundary, single-oversized-row pass-through, empty batch) and both do_get and do_exchange routing through the bounded reader. The two existing do_exchange unit tests were updated from asserting write_table to asserting the reassembled write_batch calls. Quality bar for this PR: diff-cover against upstream/master: 100% (17/17 changed lines). cosmic-ray mutation testing scoped to the diff (offline_server.py, filtered to lines changed vs upstream/master): 35 mutants generated on the diff, 35 killed, 0 survivors, 0 timeouts, all worker outcomes NORMAL/SKIPPED. One initial survivor (// -> / in the halving arithmetic) was closed with an added test, since a real pyarrow.RecordBatch.slice() silently truncates a float length/offset to the same int and can't otherwise distinguish the two operators. sdk/python/tests/integration/offline_server/test_offline_server.py -v --integration passes locally (4/4) against the real Flight client/server round trip.

Open Graph Description: What this PR does / why we need it: The offline server's do_get() and do_exchange() Flight handlers each returned a single, unbounded Arrow Table/RecordBatch to the client. Once a result approa...

X Description: What this PR does / why we need it: The offline server's do_get() and do_exchange() Flight handlers each returned a single, unbounded Arrow Table/RecordBatch to the client. Once a result ap...

Opengraph URL: https://github.com/feast-dev/feast/pull/6896

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:07fdaa82-0335-17ec-f3cd-13016b099d2e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9B60:262F52:1010631:150AFAF:6AFE98EE
html-safe-nonce5b2ad4e49c87bb6c19002ffe73795f5c18b757d8de229d50ce9dddcb046f0846
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjYwOjI2MkY1MjoxMDEwNjMxOjE1MEFGQUY6NkFGRTk4RUUiLCJ2aXNpdG9yX2lkIjoiMzIxMjIxNTcwMTg1NDkxODg5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9ef9c41b66d86d040c29d892a7e52e998b69c9c0439fcb0fc911e06aa93b6413
hovercard-subject-tagpull_request:4682350629
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6896/files
twitter:imagehttps://avatars.githubusercontent.com/u/37416518?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/37416518?s=400&v=4
og:image:altWhat this PR does / why we need it: The offline server's do_get() and do_exchange() Flight handlers each returned a single, unbounded Arrow Table/RecordBatch to the client. Once a result approa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6896/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6896%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6896%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6896/files
Reloadhttps://github.com/feast-dev/feast/pull/6896/files
Reloadhttps://github.com/feast-dev/feast/pull/6896/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
dbbvitor:fix/offline-server-bounded-batcheshttps://github.com/dbbvitor/feast/tree/fix/offline-server-bounded-batches
Conversation 1 https://github.com/feast-dev/feast/pull/6896
Commits 2 https://github.com/feast-dev/feast/pull/6896/commits
Checks 23 https://github.com/feast-dev/feast/pull/6896/checks
Files changed https://github.com/feast-dev/feast/pull/6896/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6896/files
fix: Bound Arrow Flight batch size in the offline server https://github.com/feast-dev/feast/pull/6896/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6896/files
ef68af3 fix: Bound Arrow Flight batch size in the offline server dbbvitor Sep 24, 2026 https://github.com/feast-dev/feast/pull/6896/commits/ef68af381954668b3ffa064ec4d5f65c0bf9607e
1de36b2 test: Kill the FloorDiv/TrueDiv equivalent mutant in _split_oversized dbbvitor Sep 24, 2026 https://github.com/feast-dev/feast/pull/6896/commits/1de36b2f4c4a2c209d29d064b0d39187333ae238
Clear filters https://github.com/feast-dev/feast/pull/6896/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6896/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6896/files
offline_server.py https://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
test_offline_server.py https://github.com/feast-dev/feast/pull/6896/files#diff-e6c88cf68da6c8ff0308996ba09da4e41baa2994638251c558c63e23fb56eaf0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/offline_server.pyhttps://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
View file https://github.com/dbbvitor/feast/blob/1de36b2f4c4a2c209d29d064b0d39187333ae238/sdk/python/feast/offline_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6896/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
https://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
https://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
https://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
https://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
https://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
https://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
https://github.com/feast-dev/feast/pull/6896/files#diff-c13f0f7fae459fa3b30c42e14ea91a9d73cd7b1941e5efc2360e61f68ae2f8fa
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_offline_server.pyhttps://github.com/feast-dev/feast/pull/6896/files#diff-e6c88cf68da6c8ff0308996ba09da4e41baa2994638251c558c63e23fb56eaf0
View file https://github.com/dbbvitor/feast/blob/1de36b2f4c4a2c209d29d064b0d39187333ae238/sdk/python/tests/unit/test_offline_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6896/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6896/files#diff-e6c88cf68da6c8ff0308996ba09da4e41baa2994638251c558c63e23fb56eaf0
https://github.com/feast-dev/feast/pull/6896/files#diff-e6c88cf68da6c8ff0308996ba09da4e41baa2994638251c558c63e23fb56eaf0
https://github.com/feast-dev/feast/pull/6896/files#diff-e6c88cf68da6c8ff0308996ba09da4e41baa2994638251c558c63e23fb56eaf0
https://github.com/feast-dev/feast/pull/6896/files#diff-e6c88cf68da6c8ff0308996ba09da4e41baa2994638251c558c63e23fb56eaf0
https://github.com/feast-dev/feast/pull/6896/files#diff-e6c88cf68da6c8ff0308996ba09da4e41baa2994638251c558c63e23fb56eaf0
https://github.com/feast-dev/feast/pull/6896/files#diff-e6c88cf68da6c8ff0308996ba09da4e41baa2994638251c558c63e23fb56eaf0
https://github.com/feast-dev/feast/pull/6896/files#diff-e6c88cf68da6c8ff0308996ba09da4e41baa2994638251c558c63e23fb56eaf0
Please reload this pagehttps://github.com/feast-dev/feast/pull/6896/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.