René's URL Explorer Experiment


Title: fix: Load Milvus collections once instead of on every query by simonhearne · Pull Request #6882 · feast-dev/feast · GitHub

Open Graph Title: fix: Load Milvus collections once instead of on every query by simonhearne · Pull Request #6882 · feast-dev/feast

X Title: fix: Load Milvus collections once instead of on every query by simonhearne · Pull Request #6882 · feast-dev/feast

Description: What this PR does / why we need it: online_read and retrieve_online_documents_v2 called load_collection on every request. That call also hid a bug: collections were created, then indexed with a separate create_index, which leaves them unloaded on Milvus servers. Collections are created with their index_params, so Milvus indexes and loads them at once. For existing collections, the load state is checked on first access and load_collection is only called if the collection isn't loaded. The result is cached per store instance. The per-query load_collection calls are removed. Depends on #6881: every vector field must be indexed for the collection to load when it's created. Until #6881 merges this PR also shows its commit; only the last commit (fix: Load Milvus collections once instead of on every query) is new here. Which issue(s) this PR fixes: N/A Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Unit (mocked): an existing collection is loaded 0 times if already loaded and once if not, across 5 reads; new collections are created with index params and no separate load. Unit (Milvus Lite): spy confirms load_collection isn't called by reads or searches. Server: no load_collection per query; a released collection is loaded exactly once by a new store. Unit tests run on Milvus Lite 3.2.1 (pymilvus 3.0.2). Server tests in sdk/python/tests/integration/online_store/test_milvus_remote.py are marked integration and skip unless ZILLIZ_URI and ZILLIZ_TOKEN are set; they passed against a local Milvus 2.6.0 server and against Zilliz Cloud. The existing Milvus unit and universal integration tests pass unchanged. Misc Part of a series of Milvus online store improvements for Zilliz Cloud and production Milvus. 🤖 Generated with Claude Code

Open Graph Description: What this PR does / why we need it: online_read and retrieve_online_documents_v2 called load_collection on every request. That call also hid a bug: collections were created, then indexed with a sep...

X Description: What this PR does / why we need it: online_read and retrieve_online_documents_v2 called load_collection on every request. That call also hid a bug: collections were created, then indexed with a sep...

Opengraph URL: https://github.com/feast-dev/feast/pull/6882

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7cb576dc-90fe-87c0-7fad-a70c5f0ff1ab
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98F6:61466:E7FFBA:13D4AA6:6AFE955C
html-safe-nonceea1c5c65282618f900eccf975859884cf2229419886c5e3ffd908eb61c17ac34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEY2OjYxNDY2OkU3RkZCQToxM0Q0QUE2OjZBRkU5NTVDIiwidmlzaXRvcl9pZCI6IjIyOTI0MDI1MjA3NDEyODcyNjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0385e4c7d09daaeab3649f597de3bd50af95f16080f3ec980020ba553b85adb1
hovercard-subject-tagpull_request:4664305759
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6882/files
twitter:imagehttps://avatars.githubusercontent.com/u/496189?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/496189?s=400&v=4
og:image:altWhat this PR does / why we need it: online_read and retrieve_online_documents_v2 called load_collection on every request. That call also hid a bug: collections were created, then indexed with a sep...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6882/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6882%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6882%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6882/files
Reloadhttps://github.com/feast-dev/feast/pull/6882/files
Reloadhttps://github.com/feast-dev/feast/pull/6882/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
simonhearne:fix/milvus-load-oncehttps://github.com/simonhearne/feast/tree/fix/milvus-load-once
Conversation 1 https://github.com/feast-dev/feast/pull/6882
Commits 2 https://github.com/feast-dev/feast/pull/6882/commits
Checks 1 https://github.com/feast-dev/feast/pull/6882/checks
Files changed https://github.com/feast-dev/feast/pull/6882/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6882/files
fix: Load Milvus collections once instead of on every query https://github.com/feast-dev/feast/pull/6882/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6882/files
0838f0d fix: Make Milvus placeholder vectors valid on Milvus servers simonhearne Sep 28, 2026 https://github.com/feast-dev/feast/pull/6882/commits/0838f0db367327ac7130181bd4ec50e393808e80
f75c444 fix: Load Milvus collections once instead of on every query simonhearne Sep 28, 2026 https://github.com/feast-dev/feast/pull/6882/commits/f75c4445eaa3074df1cede85f1423fe848dff601
Clear filters https://github.com/feast-dev/feast/pull/6882/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6882/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6882/files
.secrets.baseline https://github.com/feast-dev/feast/pull/6882/files#diff-d8447df0cd384602c76086081f13f27ad0b45902297c42da35a6fc51fdf1cec3
milvus.md https://github.com/feast-dev/feast/pull/6882/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
milvus.py https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
test_milvus_remote.py https://github.com/feast-dev/feast/pull/6882/files#diff-95f25767fa3351a959d205bceb3281385fc4cec3503a02e4a13abfdc15b4d46f
test_milvus_online_store.py https://github.com/feast-dev/feast/pull/6882/files#diff-450f1a3096f9e72985ee29b609a310067a6308850ec5765c0b9708a4830b0cfe
.secrets.baselinehttps://github.com/feast-dev/feast/pull/6882/files#diff-d8447df0cd384602c76086081f13f27ad0b45902297c42da35a6fc51fdf1cec3
View file https://github.com/simonhearne/feast/blob/f75c4445eaa3074df1cede85f1423fe848dff601/.secrets.baseline
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/feast-dev/feast/pull/6882/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/milvus.mdhttps://github.com/feast-dev/feast/pull/6882/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
View file https://github.com/simonhearne/feast/blob/f75c4445eaa3074df1cede85f1423fe848dff601/docs/reference/online-stores/milvus.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6882/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6882/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/6882/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/pull/6882/files#diff-db3c469e983dc1586778989d91e337aca298d5e9333b4f4bdaf3e7d995c17880
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/milvus_online_store/milvus.pyhttps://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
View file https://github.com/simonhearne/feast/blob/f75c4445eaa3074df1cede85f1423fe848dff601/sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6882/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
https://github.com/feast-dev/feast/pull/6882/files#diff-3f21025352e4840bcd8dd17ca243f97ab1e0b984b1bc51ea68bfeff59fef00f9
Please reload this pagehttps://github.com/feast-dev/feast/pull/6882/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.