René's URL Explorer Experiment


Title: feat: Add optional GLIDE client for Redis online reads by chandlerok · Pull Request #6870 · feast-dev/feast · GitHub

Open Graph Title: feat: Add optional GLIDE client for Redis online reads by chandlerok · Pull Request #6870 · feast-dev/feast

X Title: feat: Add optional GLIDE client for Redis online reads by chandlerok · Pull Request #6870 · feast-dev/feast

Description: What this PR does / why we need it: Adds an opt-in GLIDE-backed Redis online read path for Python get_online_features. The existing redis-py path does command packing, socket parsing, and response handling in Python. Under thread contention, that work repeatedly reacquires the GIL and can make online reads much slower than single-threaded benchmarks suggest. This PR adds a client: glide option to the Redis online store config. When enabled, Feast uses GLIDE for the batched Redis read while preserving the existing Redis storage layout and default redis-py behavior. This PR intentionally does not include the HGETALL threshold optimization. That can be evaluated separately. Scope RedisOnlineStoreConfig gains client: redis | glide, defaulting to redis. Only the synchronous read paths change (online_read and the batched per-feature-view read behind get_online_features). Writes and get_online_features_async keep using redis-py. GLIDE reads the same entity keys (serialize_entity_key + project) and the same hashed field names (_mmh3(f"{fv}:{name}") plus _ts:) that Feast already writes, so existing data needs no migration. connection_string support: host/port, db, password, username, ssl, socket_timeout, socket_connect_timeout. Unknown parameters are logged and ignored. Sentinel is rejected with a clear error because GLIDE has no Sentinel support. valkey-glide-sync>=2.5,<3 is a new optional extra, feast[glide]. It is imported lazily so users who never opt in are unaffected. Configuring client: glide without it raises FeastExtrasDependencyImportError naming the extra. Implementation notes The read client is selected in one place, RedisOnlineStore._read_hash_fields, which takes a list of (key, fields) HMGET commands and returns one reply per command. Both clients produce the same ordering, so the existing response conversion (_convert_redis_values_to_protobuf) and timestamp handling are untouched. _glide_hmget_batch builds a single Batch(is_atomic=False) (or ClusterBatch(is_atomic=False) for cluster) and calls exec(batch, raise_on_error=True) once, so the whole fetch is one FFI call. Three type annotations were corrected because the GLIDE path made the existing inaccuracy visible: _generate_hset_keys_for_features returns hashed bytes keys, not str, and the value sequences accepted by _convert_redis_values_to_protobuf / _get_features_for_entity legitimately contain None for missing fields. Which issue(s) this PR fixes: Related to #6856. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Commands run: # Unit tests uv run python -m pytest sdk/python/tests/unit/infra/online_store/test_redis.py -q # 35 passed # Redis-related unit tests together uv run python -m pytest sdk/python/tests/unit/infra/online_store/test_redis.py \ sdk/python/tests/unit/infra/online_store/test_redis_versioning.py \ sdk/python/tests/unit/infra/online_store/test_helpers.py -q # 65 passed # Integration tests uv run python -m pytest --integration \ sdk/python/tests/integration/online_store/test_redis_glide_client.py -q # 2 passed # Lint and format uv run ruff check # All checks passed! uv run ruff format --check # 3 files already formatted # Types uv run bash -c "cd sdk/python && mypy feast/infra/online_stores/redis.py" # Success: no issues found in 1 source file Notes on the test runs The integration test seeds rows with the default redis-py client, then reads them back with client: redis and client: glide and asserts the results are byte-identical, both for online_read and for the batched _read_features_per_fv response (including a missing entity). If GLIDE used different keys or field names it would read NOT_FOUND instead of matching. I ran the integration test against a live Valkey 9 on localhost:6379 because the Docker daemon on my machine could not create containers (error creating temporary lease: read-only file system). The committed test uses testcontainers with redis:7, matching the existing test_redis_versioning.py, and is skipped when Docker is unavailable. glide is added to the ci extra in pyproject.toml, but the pinned lock files (sdk/python/requirements/py*-ci-requirements.txt) need a make lock-python-dependencies-all run before CI installs it. Until then the tests that need the real package skip via importorskip; the mock-based tests, including the missing-dependency error test, still run. mypy on feast/infra/online_stores/redis.py is clean. test_redis.py already had 19 mypy errors at master (unrelated pre-existing assertions on Optional dicts and list invariance in online_write_batch test data); this branch reduces that to 16 and adds none. I left those pre-existing errors alone to keep this diff focused. Misc The GLIDE batch is non-atomic by design, matching the existing pipeline(transaction=False) behavior. valkey-glide-sync 2.5.0 and 2.5.3 were both checked to confirm the Batch/ClusterBatch/config signatures used here exist across the 2.5 line. I am happy to add glide to the ci lock files in this PR if you would rather have CI coverage of the GLIDE path immediately.

Open Graph Description: What this PR does / why we need it: Adds an opt-in GLIDE-backed Redis online read path for Python get_online_features. The existing redis-py path does command packing, socket parsing, and response ...

X Description: What this PR does / why we need it: Adds an opt-in GLIDE-backed Redis online read path for Python get_online_features. The existing redis-py path does command packing, socket parsing, and response ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6870

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e62f5d20-61f4-5731-cfaf-059d557bbefe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D58:20D634:DF8DAD:12A3B7C:6AFE9892
html-safe-nonceb36fc8a07cf8acc9afa0dc3a557b3d23036b6e33f696267e0e089ff1ef46f301
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDU4OjIwRDYzNDpERjhEQUQ6MTJBM0I3Qzo2QUZFOTg5MiIsInZpc2l0b3JfaWQiOiI3MTI2NzI5OTYxOTEyNzkyNTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac03d5977ab97bddb2b753deca67a12b663bac1a9d0a9c8c5df3ef6f726bbbaf19
hovercard-subject-tagpull_request:4639688291
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6870/files
twitter:imagehttps://avatars.githubusercontent.com/u/45566625?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/45566625?s=400&v=4
og:image:altWhat this PR does / why we need it: Adds an opt-in GLIDE-backed Redis online read path for Python get_online_features. The existing redis-py path does command packing, socket parsing, and response ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6870/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6870%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6870%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6870/files
Reloadhttps://github.com/feast-dev/feast/pull/6870/files
Reloadhttps://github.com/feast-dev/feast/pull/6870/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
chandlerok:feat/redis-glide-clienthttps://github.com/chandlerok/feast/tree/feat/redis-glide-client
Conversation 13 https://github.com/feast-dev/feast/pull/6870
Commits 2 https://github.com/feast-dev/feast/pull/6870/commits
Checks 23 https://github.com/feast-dev/feast/pull/6870/checks
Files changed https://github.com/feast-dev/feast/pull/6870/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6870/files
feat: Add optional GLIDE client for Redis online reads https://github.com/feast-dev/feast/pull/6870/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6870/files
8182dc4 feat: Add optional GLIDE client for Redis online reads chandlerok Sep 25, 2026 https://github.com/feast-dev/feast/pull/6870/commits/8182dc47a077200a2bdc6bed9d1859988c5353cf
6dd260a fix: Release the GLIDE client and cache its module per store chandlerok Sep 30, 2026 https://github.com/feast-dev/feast/pull/6870/commits/6dd260a67bacf42a3d21f87814bb6aeeda720cf9
Clear filters https://github.com/feast-dev/feast/pull/6870/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6870/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6870/files
redis.md https://github.com/feast-dev/feast/pull/6870/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
pyproject.toml https://github.com/feast-dev/feast/pull/6870/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
redis.py https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
test_redis_glide_client.py https://github.com/feast-dev/feast/pull/6870/files#diff-6798e50645d7c981ddc18cd5eef7a42150629f5f7d3f2f7cf455360fffc263ed
test_redis.py https://github.com/feast-dev/feast/pull/6870/files#diff-c44a5a05d39122961f5a1df8728cafebc6cd7679bdf02a71d42461c238fa637f
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/reference/online-stores/redis.mdhttps://github.com/feast-dev/feast/pull/6870/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
View file https://github.com/chandlerok/feast/blob/6dd260a67bacf42a3d21f87814bb6aeeda720cf9/docs/reference/online-stores/redis.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6870/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6870/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
https://github.com/feast-dev/feast/pull/6870/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
https://github.com/feast-dev/feast/pull/6870/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
https://github.com/feast-dev/feast/pull/6870/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
https://github.com/feast-dev/feast/pull/6870/files#diff-628d54de8459ecfbc0aa848f7223eacdcf8a6a3889b7dfe5ed935df9153d25a1
pyproject.tomlhttps://github.com/feast-dev/feast/pull/6870/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
View file https://github.com/chandlerok/feast/blob/6dd260a67bacf42a3d21f87814bb6aeeda720cf9/pyproject.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6870/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6870/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
https://github.com/feast-dev/feast/pull/6870/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
https://github.com/feast-dev/feast/pull/6870/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
https://github.com/feast-dev/feast/pull/6870/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/redis.pyhttps://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
View file https://github.com/chandlerok/feast/blob/6dd260a67bacf42a3d21f87814bb6aeeda720cf9/sdk/python/feast/infra/online_stores/redis.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6870/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
ntkatholehttps://github.com/ntkathole
Sep 26, 2026https://github.com/feast-dev/feast/pull/6870/files#r4111656346
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6870/files
chandlerokhttps://github.com/chandlerok
Sep 30, 2026https://github.com/feast-dev/feast/pull/6870/files#r4149553566
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
d12d035https://github.com/feast-dev/feast/commit/d12d035417c0d3f7d734f0171a846d2d938b3b3a
Please reload this pagehttps://github.com/feast-dev/feast/pull/6870/files
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
ntkatholehttps://github.com/ntkathole
Sep 26, 2026https://github.com/feast-dev/feast/pull/6870/files#r4111656348
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6870/files
chandlerokhttps://github.com/chandlerok
Sep 30, 2026https://github.com/feast-dev/feast/pull/6870/files#r4149553731
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
d12d035https://github.com/feast-dev/feast/commit/d12d035417c0d3f7d734f0171a846d2d938b3b3a
Please reload this pagehttps://github.com/feast-dev/feast/pull/6870/files
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
https://github.com/feast-dev/feast/pull/6870/files#diff-c2b25e2070b2be8b73b7574b51fd84470df80368d2746be111c1a3fb8793b2ee
Please reload this pagehttps://github.com/feast-dev/feast/pull/6870/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6870/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.