René's URL Explorer Experiment


Title: fix: Preserve an unset aggregation time window across a proto round-trip by Rodrigo-Palma · Pull Request #6859 · feast-dev/feast · GitHub

Open Graph Title: fix: Preserve an unset aggregation time window across a proto round-trip by Rodrigo-Palma · Pull Request #6859 · feast-dev/feast

X Title: fix: Preserve an unset aggregation time window across a proto round-trip by Rodrigo-Palma · Pull Request #6859 · feast-dev/feast

Description: What this PR does / why we need it Aggregation.__init__ types time_window and slide_interval as Optional, and to_proto honours that: it only writes the Duration when the value is not None. from_proto tests the value instead of the presence: time_window = ( timedelta(days=0) if agg_proto.time_window.ToNanoseconds() == 0 else agg_proto.time_window.ToTimedelta() ) An absent Duration also reports ToNanoseconds() == 0, so an aggregation defined without a window comes back as timedelta(0). That difference is load bearing. aggregation_specs_to_agg_ops rejects a windowed aggregation in online serving with: if getattr(agg, "time_window", None) is not None: raise ValueError(time_window_unsupported_error_message) So an on demand feature view written the way the existing tests write it: @on_demand_feature_view(..., aggregations=[Aggregation(column="trips", function="sum")], mode="python") works in process, and then fails on the first get_online_features after feast apply, with "Time window aggregation is not supported in online serving.", even though no window was ever requested. Any registry reaches this, since they all round-trip through the proto. StreamFeatureView runs the same conversion. Aggregation.__eq__ compares both attributes, so a registry diff also sees an unchanged feature view as modified. Fix Read the fields through HasField, which is available because both are google.protobuf.Duration message fields and therefore have presence. Testing Two tests in test_on_demand_feature_view_aggregation.py: a plain round-trip that asserts None survives, and an end to end one that takes an ODFV through to_proto/from_proto and then serves it. Both fail before the change and pass after. ruff check, ruff format and mypy are clean on the touched files.

Open Graph Description: What this PR does / why we need it Aggregation.__init__ types time_window and slide_interval as Optional, and to_proto honours that: it only writes the Duration when the value is not None. from_pro...

X Description: What this PR does / why we need it Aggregation.__init__ types time_window and slide_interval as Optional, and to_proto honours that: it only writes the Duration when the value is not None. from_pro...

Opengraph URL: https://github.com/feast-dev/feast/pull/6859

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:881013d6-c730-3ae7-18b6-7feb353a30e9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAF8:D8CB1:F34D1D:14CABC3:6AFE988B
html-safe-nonce9b0648bf8260b0070574d25a9502c9ab68758380ac1fa22921cfefa388322617
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUY4OkQ4Q0IxOkYzNEQxRDoxNENBQkMzOjZBRkU5ODhCIiwidmlzaXRvcl9pZCI6IjE3OTQzMjQxNTI3OTA3MTg2MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8f5a4b4ca07498212bf38e80d343b9ad3c59f56d1c9f4fc3016b1a72f09e0eb0
hovercard-subject-tagpull_request:4620138293
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6859/files
twitter:imagehttps://avatars.githubusercontent.com/u/86628053?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/86628053?s=400&v=4
og:image:altWhat this PR does / why we need it Aggregation.__init__ types time_window and slide_interval as Optional, and to_proto honours that: it only writes the Duration when the value is not None. from_pro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6859/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6859%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6859%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6859/files
Reloadhttps://github.com/feast-dev/feast/pull/6859/files
Reloadhttps://github.com/feast-dev/feast/pull/6859/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Rodrigo-Palma:fix-aggregation-unset-time-windowhttps://github.com/Rodrigo-Palma/feast/tree/fix-aggregation-unset-time-window
Conversation 2 https://github.com/feast-dev/feast/pull/6859
Commits 1 https://github.com/feast-dev/feast/pull/6859/commits
Checks 23 https://github.com/feast-dev/feast/pull/6859/checks
Files changed https://github.com/feast-dev/feast/pull/6859/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6859/files
fix: Preserve an unset aggregation time window across a proto round-trip https://github.com/feast-dev/feast/pull/6859/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6859/files
1bd6944 fix: Preserve an unset aggregation time window across a proto round-trip Rodrigo-Palma Sep 24, 2026 https://github.com/feast-dev/feast/pull/6859/commits/1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb
Clear filters https://github.com/feast-dev/feast/pull/6859/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6859/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6859/files
__init__.py https://github.com/feast-dev/feast/pull/6859/files#diff-9a90c33451e3d980ddf6b22b808f39d5900fffb298263ae1787ae63f206abe09
test_on_demand_feature_view_aggregation.py https://github.com/feast-dev/feast/pull/6859/files#diff-f99075a720d442afa76dfc4f765a9c8a6b6bfe53284de1aad6841323e83ef136
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/aggregation/__init__.pyhttps://github.com/feast-dev/feast/pull/6859/files#diff-9a90c33451e3d980ddf6b22b808f39d5900fffb298263ae1787ae63f206abe09
View file https://github.com/Rodrigo-Palma/feast/blob/1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb/sdk/python/feast/aggregation/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6859/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6859/files#diff-9a90c33451e3d980ddf6b22b808f39d5900fffb298263ae1787ae63f206abe09
https://github.com/feast-dev/feast/pull/6859/files#diff-9a90c33451e3d980ddf6b22b808f39d5900fffb298263ae1787ae63f206abe09
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_on_demand_feature_view_aggregation.pyhttps://github.com/feast-dev/feast/pull/6859/files#diff-f99075a720d442afa76dfc4f765a9c8a6b6bfe53284de1aad6841323e83ef136
View file https://github.com/Rodrigo-Palma/feast/blob/1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb/sdk/python/tests/unit/test_on_demand_feature_view_aggregation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6859/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6859/files#diff-f99075a720d442afa76dfc4f765a9c8a6b6bfe53284de1aad6841323e83ef136
https://github.com/feast-dev/feast/pull/6859/files#diff-f99075a720d442afa76dfc4f765a9c8a6b6bfe53284de1aad6841323e83ef136
https://github.com/feast-dev/feast/pull/6859/files#diff-f99075a720d442afa76dfc4f765a9c8a6b6bfe53284de1aad6841323e83ef136
Please reload this pagehttps://github.com/feast-dev/feast/pull/6859/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.