René's URL Explorer Experiment


Title: fix: Preserve an unset aggregation time window across a proto round-trip by Rodrigo-Palma · Pull Request #6859 · feast-dev/feast · GitHub

Open Graph Title: fix: Preserve an unset aggregation time window across a proto round-trip by Rodrigo-Palma · Pull Request #6859 · feast-dev/feast

X Title: fix: Preserve an unset aggregation time window across a proto round-trip by Rodrigo-Palma · Pull Request #6859 · feast-dev/feast

Description: The Open Source Feature Store for AI/ML. Contribute to feast-dev/feast development by creating an account on GitHub.

Open Graph Description: What this PR does / why we need it Aggregation.__init__ types time_window and slide_interval as Optional, and to_proto honours that: it only writes the Duration when the value is not None. from_pro...

X Description: What this PR does / why we need it Aggregation.__init__ types time_window and slide_interval as Optional, and to_proto honours that: it only writes the Duration when the value is not None. from_pro...

Opengraph URL: https://github.com/feast-dev/feast/pull/6859

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:7b8c66d9-18be-5617-2cf1-e9539882a717
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-id94A6:3C4BAF:3D5951:552AB4:6AFE9E1B
html-safe-nonce9a968be35ee2de079c06ca63a4780817ba5f9f811f1604673ed5c2e775bafba6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEE2OjNDNEJBRjozRDU5NTE6NTUyQUI0OjZBRkU5RTFCIiwidmlzaXRvcl9pZCI6IjY0MTA1NjU4OTQ1Njg1ODI2ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1522e86cad1f736153299072999fa258aac3d7097c10cc6a34481d6bb85cac3c
hovercard-subject-tagpull_request:4620138293
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6859/checks
twitter:imagehttps://opengraph.githubassets.com/c9156f5b1649b02e81078195f9283efa2da3e652be69b2fba597c6224a6b2601/feast-dev/feast/pull/6859
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c9156f5b1649b02e81078195f9283efa2da3e652be69b2fba597c6224a6b2601/feast-dev/feast/pull/6859
og:image:altWhat this PR does / why we need it Aggregation.__init__ types time_window and slide_interval as Optional, and to_proto honours that: it only writes the Duration when the value is not None. from_pro...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRodrigo-Palma
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6859/checks#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6859%2Fchecks
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6859%2Fchecks
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6859/checks
Reloadhttps://github.com/feast-dev/feast/pull/6859/checks
Reloadhttps://github.com/feast-dev/feast/pull/6859/checks
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Rodrigo-Palma:fix-aggregation-unset-time-windowhttps://github.com/Rodrigo-Palma/feast/tree/fix-aggregation-unset-time-window
Conversationhttps://github.com/feast-dev/feast/pull/6859
Commits1 (1)https://github.com/feast-dev/feast/pull/6859/commits
Checkshttps://github.com/feast-dev/feast/pull/6859/checks
Files changedhttps://github.com/feast-dev/feast/pull/6859/files
fix: Preserve an unset aggregation time window across a proto round-triphttps://github.com/feast-dev/feast/pull/6859/checks#top
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Rodrigo-Palma:fix-aggregation-unset-time-windowhttps://github.com/Rodrigo-Palma/feast/tree/fix-aggregation-unset-time-window
Please reload this pagehttps://github.com/feast-dev/feast/pull/6859/checks
DCO https://github.com/feast-dev/feast/pull/6859/checks?check_run_id=108445459694
pr-local-integration-tests on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964759
integration-test-python-local (3.11, ubuntu-latest) https://github.com/feast-dev/feast/actions/runs/36256964759/job/108445467001?pr=6859
linter on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964764
lint-python https://github.com/feast-dev/feast/actions/runs/36256964764/job/108445467046?pr=6859
Security on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964765
CodeQL Analysis (python) https://github.com/feast-dev/feast/actions/runs/36256964765/job/108445466941?pr=6859
CodeQL Analysis (javascript-typescript) https://github.com/feast-dev/feast/actions/runs/36256964765/job/108445466821?pr=6859
Dependency Security Scan https://github.com/feast-dev/feast/actions/runs/36256964765/job/108445466989?pr=6859
Go Vulnerability Check (go-feature-server) https://github.com/feast-dev/feast/actions/runs/36256964765/job/108445466991?pr=6859
Go Vulnerability Check (feast-operator) https://github.com/feast-dev/feast/actions/runs/36256964765/job/108445466948?pr=6859
pr-remote-rbac-integration-tests on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964770
remote-rbac-integration-tests-python (3.11, ubuntu-latest) https://github.com/feast-dev/feast/actions/runs/36256964770/job/108445466945?pr=6859
pr-ray-integration-tests on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964773
integration-test-ray https://github.com/feast-dev/feast/actions/runs/36256964773/job/108445467151?pr=6859
lint-pr on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964797
Validate PR title https://github.com/feast-dev/feast/actions/runs/36256964797/job/108445466960?pr=6859
smoke-tests on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964803
smoke-test-python (3.11, ubuntu-latest) https://github.com/feast-dev/feast/actions/runs/36256964803/job/108445467371?pr=6859
pr-duckdb-integration-tests on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964811
integration-test-duckdb-offline https://github.com/feast-dev/feast/actions/runs/36256964811/job/108445467337?pr=6859
unit-tests on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964821
unit-test-python (3.10, ubuntu-latest) https://github.com/feast-dev/feast/actions/runs/36256964821/job/108445467232?pr=6859
unit-test-python (3.11, ubuntu-latest) https://github.com/feast-dev/feast/actions/runs/36256964821/job/108445467237?pr=6859
unit-test-python (3.11, macos-14) https://github.com/feast-dev/feast/actions/runs/36256964821/job/108445467262?pr=6859
unit-test-python (3.12, ubuntu-latest) https://github.com/feast-dev/feast/actions/runs/36256964821/job/108445467239?pr=6859
unit-test-python (3.12, macos-14) https://github.com/feast-dev/feast/actions/runs/36256964821/job/108445467299?pr=6859
unit-test-go https://github.com/feast-dev/feast/actions/runs/36256964821/job/108445467238?pr=6859
unit-test-ui https://github.com/feast-dev/feast/actions/runs/36256964821/job/108445467209?pr=6859
operator-pr on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964834
operator-test https://github.com/feast-dev/feast/actions/runs/36256964834/job/108445467283?pr=6859
pr-rest-API-tests on: pull_request https://github.com/feast-dev/feast/actions/runs/36256964839
registry-rest-api-tests https://github.com/feast-dev/feast/actions/runs/36256964839/job/108445467175?pr=6859
CodeQL https://github.com/feast-dev/feast/pull/6859/checks?check_run_id=108445678758
View more details on DCO https://probot.github.io/apps/dco/
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.