| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7f85f90b-0203-9431-16d2-0943ea54136d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92FA:2224A5:EB665C:140C769:6AFE96C0 |
| html-safe-nonce | 5cd55e4eea77c9260b1462f4f627775b55c2b7123d7e811233fe9eaad23451d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkZBOjIyMjRBNTpFQjY2NUM6MTQwQzc2OTo2QUZFOTZDMCIsInZpc2l0b3JfaWQiOiIyNjE1ODM4NDUxNzYwNTM1MjMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3a42ba0a4e570e18ec123f777478813d7efb06c061f411cbe856482e9d8c3446 |
| hovercard-subject-tag | pull_request:4620138293 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/6859/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c9156f5b1649b02e81078195f9283efa2da3e652be69b2fba597c6224a6b2601/feast-dev/feast/pull/6859 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c9156f5b1649b02e81078195f9283efa2da3e652be69b2fba597c6224a6b2601/feast-dev/feast/pull/6859 |
| og:image:alt | What this PR does / why we need it
Aggregation.__init__ types time_window and slide_interval as Optional, and to_proto honours that: it only writes the Duration when the value is not None. from_pro... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Rodrigo-Palma |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-cache |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/feast-dev/feast/pull/6859#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6859 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6859 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/6859 |
| Reload | https://github.com/feast-dev/feast/pull/6859 |
| Reload | https://github.com/feast-dev/feast/pull/6859 |
| feast-dev | https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
| Code | https://github.com/feast-dev/feast |
| Issues223 (223) | https://github.com/feast-dev/feast/issues |
| Pull requests143 (143) | https://github.com/feast-dev/feast/pulls |
| Discussions | https://github.com/feast-dev/feast/discussions |
| Actions | https://github.com/feast-dev/feast/actions |
| Security and quality1 (1) | https://github.com/feast-dev/feast/security |
| Insights | https://github.com/feast-dev/feast/insights |
| https://github.com/feast-dev/feast |
| ntkathole | https://github.com/ntkathole |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| Rodrigo-Palma:fix-aggregation-unset-time-window | https://github.com/Rodrigo-Palma/feast/tree/fix-aggregation-unset-time-window |
| Conversation | https://github.com/feast-dev/feast/pull/6859 |
| Commits1 (1) | https://github.com/feast-dev/feast/pull/6859/commits |
| Checks | https://github.com/feast-dev/feast/pull/6859/checks |
| Files changed | https://github.com/feast-dev/feast/pull/6859/files |
| fix: Preserve an unset aggregation time window across a proto round-trip | https://github.com/feast-dev/feast/pull/6859#top |
| ntkathole | https://github.com/ntkathole |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| Rodrigo-Palma:fix-aggregation-unset-time-window | https://github.com/Rodrigo-Palma/feast/tree/fix-aggregation-unset-time-window |
|
| https://github.com/Rodrigo-Palma |
| Rodrigo-Palma | https://github.com/Rodrigo-Palma |
| Sep 24, 2026 | https://github.com/feast-dev/feast/pull/6859#issue-5561292457 |
| Please reload this page | https://github.com/feast-dev/feast/pull/6859 |
| https://github.com/Rodrigo-Palma |
| Rodrigo-Palma | https://github.com/Rodrigo-Palma |
| code owner | https://github.com/feast-dev/feast/blob/b60f9c7091886881939d0b46e90135c353da89a7/CODEOWNERS#L10 |
| September 24, 2026 00:34 | https://github.com/feast-dev/feast/pull/6859#event-31719500235 |
| https://github.com/codecov-commenter |
| codecov-commenter | https://github.com/codecov-commenter |
| Sep 25, 2026 | https://github.com/feast-dev/feast/pull/6859#issuecomment-5833726305 |
| Please reload this page | https://github.com/feast-dev/feast/pull/6859 |
| https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUwNjk5MzMsIm5iZiI6MTc5NTA2OTYzMywicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMTE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTExOVQwNjI3MTNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNzE2YTY1ZDQ5NWY5NjRkY2U5ZmUyNWNkMWQ5YzBjNDNkM2Y2ZDkzYjUwYjQ4MmZmM2E3ZmY0MDVkNGEzOGQzJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.YnmcREUnDA0jxb_F0aEO1HNPPJ40SB-GAXu2lrQq0nw |
| Codecov | https://app.codecov.io/gh/feast-dev/feast/pull/6859?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| 139704f | https://app.codecov.io/gh/feast-dev/feast/commit/139704f1cfd51e1b8decf4d7413f2c6e3845248a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| 1bd6944 | https://app.codecov.io/gh/feast-dev/feast/commit/1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Codecov GitHub app | https://github.com/apps/codecov/installations/select_target |
| https://app.codecov.io/gh/feast-dev/feast/pull/6859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Flag | https://app.codecov.io/gh/feast-dev/feast/pull/6859/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| go-feature-server | https://app.codecov.io/gh/feast-dev/feast/pull/6859/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| python-unit | https://app.codecov.io/gh/feast-dev/feast/pull/6859/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Files with missing lines | https://app.codecov.io/gh/feast-dev/feast/pull/6859?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| sdk/python/feast/aggregation/__init__.py | https://app.codecov.io/gh/feast-dev/feast/pull/6859?src=pr&el=tree&filepath=sdk%2Fpython%2Ffeast%2Faggregation%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9hZ2dyZWdhdGlvbi9fX2luaXRfXy5weQ== |
| 1 file with indirect coverage changes | https://app.codecov.io/gh/feast-dev/feast/pull/6859/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Continue to review full report in Codecov by Harness | https://app.codecov.io/gh/feast-dev/feast/pull/6859?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Click here to learn more | https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Codecov | https://app.codecov.io/gh/feast-dev/feast/pull/6859?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| 139704f...1bd6944 | https://app.codecov.io/gh/feast-dev/feast/pull/6859?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| comment docs | https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None |
| Test Analytics | https://docs.codecov.com/docs/test-analytics |
| JS Bundle Analysis | https://docs.codecov.com/docs/javascript-bundle-analysis |
| Please reload this page | https://github.com/feast-dev/feast/pull/6859 |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
| force-pushed | https://github.com/feast-dev/feast/compare/debce0a968a5f8722c18a39332059cdf5fb5e694..175e64ee575a362ecd74b723cc5c40f01ad3d45d |
| debce0a | https://github.com/feast-dev/feast/commit/debce0a968a5f8722c18a39332059cdf5fb5e694 |
| 175e64e | https://github.com/feast-dev/feast/commit/175e64ee575a362ecd74b723cc5c40f01ad3d45d |
|
Compare
| https://github.com/feast-dev/feast/compare/debce0a968a5f8722c18a39332059cdf5fb5e694..175e64ee575a362ecd74b723cc5c40f01ad3d45d |
| September 26, 2026 14:39 | https://github.com/feast-dev/feast/pull/6859#event-31894714831 |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Sep 26, 2026 | https://github.com/feast-dev/feast/pull/6859#event-31894716410 |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
| force-pushed | https://github.com/feast-dev/feast/compare/175e64ee575a362ecd74b723cc5c40f01ad3d45d..cedef118ad2ad701261522251f52b54b09b8185c |
| 175e64e | https://github.com/feast-dev/feast/commit/175e64ee575a362ecd74b723cc5c40f01ad3d45d |
| cedef11 | https://github.com/feast-dev/feast/commit/cedef118ad2ad701261522251f52b54b09b8185c |
|
Compare
| https://github.com/feast-dev/feast/compare/175e64ee575a362ecd74b723cc5c40f01ad3d45d..cedef118ad2ad701261522251f52b54b09b8185c |
| September 26, 2026 15:05 | https://github.com/feast-dev/feast/pull/6859#event-31895533091 |
| https://github.com/Rodrigo-Palma |
| Rodrigo-Palma | https://github.com/Rodrigo-Palma |
| Sep 26, 2026 | https://github.com/feast-dev/feast/pull/6859#issuecomment-5847799805 |
| #6850 | https://github.com/feast-dev/feast/pull/6850 |
| #6870 | https://github.com/feast-dev/feast/pull/6870 |
| Please reload this page | https://github.com/feast-dev/feast/pull/6859 |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
|
Sep 26, 2026
| https://github.com/feast-dev/feast/pull/6859#pullrequestreview-5326628106 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/6859/files/1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb |
|
| https://github.com/Rodrigo-Palma |
|
| https://github.com/ntkathole |
| fix: Preserve an unset aggregation time window across a proto round-trip | https://github.com/feast-dev/feast/pull/6859/commits/1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb |
| 1bd6944 | https://github.com/feast-dev/feast/pull/6859/commits/1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
| force-pushed | https://github.com/feast-dev/feast/compare/cedef118ad2ad701261522251f52b54b09b8185c..1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb |
| cedef11 | https://github.com/feast-dev/feast/commit/cedef118ad2ad701261522251f52b54b09b8185c |
| 1bd6944 | https://github.com/feast-dev/feast/commit/1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb |
|
Compare
| https://github.com/feast-dev/feast/compare/cedef118ad2ad701261522251f52b54b09b8185c..1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb |
| September 26, 2026 16:51 | https://github.com/feast-dev/feast/pull/6859#event-31898766017 |
| https://github.com/ntkathole |
| ntkathole | https://github.com/ntkathole |
| 2000379 | https://github.com/feast-dev/feast/commit/2000379e3affb544104948db9a13f8dcf310c53d |
| Sep 26, 2026 | https://github.com/feast-dev/feast/pull/6859#event-31898773697 |
| Please reload this page | https://github.com/feast-dev/feast/pull/6859 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6859 |
|
| https://github.com/ntkathole |
|
ntkathole
| https://github.com/ntkathole |
|
| https://github.com/feast-dev/feast/pull/6859/files/1bd69444bcaaa3f17588e7e1dc21a8b525dcd2fb |
| Please reload this page | https://github.com/feast-dev/feast/pull/6859 |
|
ok-to-test
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test |
| Please reload this page | https://github.com/feast-dev/feast/pull/6859 |
|
| https://github.com/Rodrigo-Palma |
|
| https://github.com/codecov-commenter |
|
| https://github.com/ntkathole |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |