René's URL Explorer Experiment


Title: perf: Decouple metrics HTTP server into a dedicated child process by ntkathole · Pull Request #6855 · feast-dev/feast · GitHub

Open Graph Title: perf: Decouple metrics HTTP server into a dedicated child process by ntkathole · Pull Request #6855 · feast-dev/feast

X Title: perf: Decouple metrics HTTP server into a dedicated child process by ntkathole · Pull Request #6855 · feast-dev/feast

Description: Summary Replace the daemon thread that serves the Prometheus /metrics endpoint with a multiprocessing.Process so that scrape-time aggregation (MultiProcessCollector reads + text serialization) runs with its own GIL, fully isolated from request-serving workers and the Gunicorn master. Problem When Prometheus scrapes the /metrics endpoint, the current daemon thread performs: File listing of all .db files in PROMETHEUS_MULTIPROCESS_DIR Reading mmap-backed metric files from every Gunicorn worker Aggregating/merging metrics across workers Serializing to Prometheus text format All of this runs under the same GIL as the Gunicorn master process. With high metric cardinality (many label combinations), this scrape overhead can cause GIL contention that indirectly affects request latency. Solution Move the WSGI HTTP metrics server into a dedicated child process via multiprocessing.Process(daemon=True): _run_metrics_server() — new top-level function that serves as the child process entry point. It re-imports prometheus_client for macOS spawn safety and registers SIGTERM/SIGINT handlers for graceful shutdown. start_metrics_server() — now spawns a Process instead of a Thread. The function signature and call sites are unchanged. Background monitoring threads (resource, freshness) remain in-process because they only write to mmap-backed Gauges — an operation that is fast and does not benefit from process isolation. Why this is safe Aspect Before (thread) After (process) Metrics port :8000 in master process :8000 in child process GIL isolation Shared with master Fully isolated daemon=True Thread auto-joins on exit Process auto-terminates on parent exit Prometheus scrape Same metrics, same format Identical — MultiProcessCollector reads same mmap files Kubernetes/HPA Transparent Transparent — same port, same pod network namespace spawn safety N/A _run_metrics_server is top-level, re-imports deps

Open Graph Description: Summary Replace the daemon thread that serves the Prometheus /metrics endpoint with a multiprocessing.Process so that scrape-time aggregation (MultiProcessCollector reads + text serialization) runs...

X Description: Summary Replace the daemon thread that serves the Prometheus /metrics endpoint with a multiprocessing.Process so that scrape-time aggregation (MultiProcessCollector reads + text serialization) runs...

Opengraph URL: https://github.com/feast-dev/feast/pull/6855

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:307c9cce-81f8-6ee6-0444-3079c95ddba0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD85E:22FF8D:21F1C6:2EFC4F:6AFE9563
html-safe-nonce8d30d336f7de73b1da25ab1b567e6e0f030fc501c87fb9aa12e75c778d52d587
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODVFOjIyRkY4RDoyMUYxQzY6MkVGQzRGOjZBRkU5NTYzIiwidmlzaXRvcl9pZCI6IjY4Mjk0MTMxNzU0NDg3MzcxMjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca33a39ce3a377fb8fb3002ea163485a532221b228a56e86f12daf27ae87fd975
hovercard-subject-tagpull_request:4598707068
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6855/files
twitter:imagehttps://avatars.githubusercontent.com/u/16951913?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16951913?s=400&v=4
og:image:altSummary Replace the daemon thread that serves the Prometheus /metrics endpoint with a multiprocessing.Process so that scrape-time aggregation (MultiProcessCollector reads + text serialization) runs...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6855/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6855%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6855%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6855/files
Reloadhttps://github.com/feast-dev/feast/pull/6855/files
Reloadhttps://github.com/feast-dev/feast/pull/6855/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
jyejarehttps://github.com/jyejare
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
ntkathole:perf/decouple-metrics-serverhttps://github.com/ntkathole/feast/tree/perf/decouple-metrics-server
Conversation 7 https://github.com/feast-dev/feast/pull/6855
Commits 2 https://github.com/feast-dev/feast/pull/6855/commits
Checks 23 https://github.com/feast-dev/feast/pull/6855/checks
Files changed https://github.com/feast-dev/feast/pull/6855/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6855/files
perf: Decouple metrics HTTP server into a dedicated child process https://github.com/feast-dev/feast/pull/6855/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6855/files
00984f7 perf: Decouple metrics HTTP server into a dedicated child process ntkathole Sep 22, 2026 https://github.com/feast-dev/feast/pull/6855/commits/00984f7980d6c55d5d4a106218816baadf143bb6
5f7ea99 Merge branch 'master' into perf/decouple-metrics-server jyejare Oct 8, 2026 https://github.com/feast-dev/feast/pull/6855/commits/5f7ea995352d0202531aa9e8cb0fb55d7aeb623a
Clear filters https://github.com/feast-dev/feast/pull/6855/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6855/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6855/files
metrics.py https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
test_metrics.py https://github.com/feast-dev/feast/pull/6855/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/metrics.pyhttps://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
View file https://github.com/ntkathole/feast/blob/5f7ea995352d0202531aa9e8cb0fb55d7aeb623a/sdk/python/feast/metrics.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6855/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
Please reload this pagehttps://github.com/feast-dev/feast/pull/6855/files
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6855/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
Please reload this pagehttps://github.com/feast-dev/feast/pull/6855/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6855/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.