| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:58a59bbc-7fa1-60fc-5846-ed1766a36459 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E604:2E53CC:38577:5008B:697B6416 |
| html-safe-nonce | e9e4d7cc89bd8f652061ae3cbe2a5f895b1ab178b4c3aa4d7a9ef8f0abc41025 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjA0OjJFNTNDQzozODU3Nzo1MDA4Qjo2OTdCNjQxNiIsInZpc2l0b3JfaWQiOiI4NzIwNDk2MDk3NzE0OTg4MDU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e69bb6c3867e035622e41f98a388950234badd4f62c393ad70dec40d44f9b4d2 |
| hovercard-subject-tag | pull_request:415065697 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/685/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e6ff8c8de875cdaf50b67d3faa0d9c6edc564b0376e8a8e84047c4ddf5af98e1/feast-dev/feast/pull/685 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e6ff8c8de875cdaf50b67d3faa0d9c6edc564b0376e8a8e84047c4ddf5af98e1/feast-dev/feast/pull/685 |
| og:image:alt | What this PR does / why we need it:
1. Generalise Source Model.
The current Source model in Feast Core is Kafka specific. For all intents and purposes it is a hardcoded implementation of KafkaSourc... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | woop |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3124d344a5a1055df639ae19c1a21017efdd6e719343f8aece5e6a6073188fa |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 88e0ab0325711bb4d5f4f8a00a14757a6fe2c8a7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/685#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F685 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F685 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/685 |
| Reload | https://github.com/feast-dev/feast/pull/685 |
| Reload | https://github.com/feast-dev/feast/pull/685 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
182
| https://github.com/feast-dev/feast/issues |
|
Pull requests
67
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/685#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| woop:generalize-sources | https://github.com/woop/feast/tree/generalize-sources |
|
Refactor Source & Job data model and Stop Duplicate Ingestion Jobs
| https://github.com/feast-dev/feast/pull/685#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| woop:generalize-sources | https://github.com/woop/feast/tree/generalize-sources |
|
Conversation
44
| https://github.com/feast-dev/feast/pull/685 |
|
Commits
5
| https://github.com/feast-dev/feast/pull/685/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/685/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/685/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/woop |
| woop | https://github.com/woop |
| May 8, 2020 | https://github.com/feast-dev/feast/pull/685#issue-614528449 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| topics/brokers | https://github.com/gojek/feast/blob/cc118eb49a785c71484c5e3ba783833a86b41726/core/src/main/java/feast/core/model/Source.java#L55 |
| https://user-images.githubusercontent.com/6728866/81380628-c9a09b80-913d-11ea-8136-0fbaaa8e3983.png |
| #632 | https://github.com/feast-dev/feast/issues/632 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/woop |
| woop | https://github.com/woop |
| pradithya | https://github.com/pradithya |
| zhilingc | https://github.com/zhilingc |
| code owners | https://github.com/feast-dev/feast/blob/cc118eb49a785c71484c5e3ba783833a86b41726/.github/CODEOWNERS#L5 |
| May 8, 2020 06:10 | https://github.com/feast-dev/feast/pull/685#event-3315723891 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
do-not-merge/work-in-progress
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
needs-kind
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind |
|
size/L
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL |
| May 8, 2020 | https://github.com/feast-dev/feast/pull/685#event-3315723944 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
kind/techdebt
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Ftechdebt |
|
compat/breaking
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Acompat%2Fbreaking |
|
needs-kind
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aneeds-kind |
| May 8, 2020 | https://github.com/feast-dev/feast/pull/685#event-3315729327 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 8, 2020 | https://github.com/feast-dev/feast/pull/685#event-3315876773 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
do-not-merge/work-in-progress
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fwork-in-progress |
| May 8, 2020 | https://github.com/feast-dev/feast/pull/685#event-3315876815 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
|
May 9, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-408638485 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files |
| core/src/main/java/feast/core/model/Source.java | https://github.com/feast-dev/feast/pull/685/files#diff-c65e26511a5452315ab7a63d527b18190a2d6ffbe7b754183db0357849d82808 |
| zhilingc | https://github.com/zhilingc |
| May 9, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r422480564 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| woop | https://github.com/woop |
| May 9, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r422485427 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| zhilingc | https://github.com/zhilingc |
| May 10, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r422571655 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| woop | https://github.com/woop |
| May 10, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r422577471 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| zhilingc | https://github.com/zhilingc |
| May 10, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r422583195 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
|
May 10, 2020
| https://github.com/feast-dev/feast/pull/685#ref-issue-615311163 |
|
Create API compatibility and Supported Versions Policy for Feast
#687
| https://github.com/feast-dev/feast/issues/687 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| May 10, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-626272300 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
do-not-merge/hold
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold |
| May 10, 2020 | https://github.com/feast-dev/feast/pull/685#event-3319981294 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 11, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-626651685 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/woop |
| woop | https://github.com/woop |
| force-pushed | https://github.com/feast-dev/feast/compare/161a46d1f0d2aab3f16a6d78853ef52187c3763a..6904912d14e46e8e6881e98653d982953e97ca6c |
| 161a46d | https://github.com/feast-dev/feast/commit/161a46d1f0d2aab3f16a6d78853ef52187c3763a |
| 6904912 | https://github.com/feast-dev/feast/commit/6904912d14e46e8e6881e98653d982953e97ca6c |
|
Compare
| https://github.com/feast-dev/feast/compare/161a46d1f0d2aab3f16a6d78853ef52187c3763a..6904912d14e46e8e6881e98653d982953e97ca6c |
| May 18, 2020 02:35 | https://github.com/feast-dev/feast/pull/685#event-3345273023 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| force-pushed | https://github.com/feast-dev/feast/compare/90f552dc3ec62346e0f83aeb2238e49a6d3af2a7..785208a9c4df7024f16a0810525702228733728f |
| 90f552d | https://github.com/feast-dev/feast/commit/90f552dc3ec62346e0f83aeb2238e49a6d3af2a7 |
| 785208a | https://github.com/feast-dev/feast/commit/785208a9c4df7024f16a0810525702228733728f |
|
Compare
| https://github.com/feast-dev/feast/compare/90f552dc3ec62346e0f83aeb2238e49a6d3af2a7..785208a9c4df7024f16a0810525702228733728f |
| May 19, 2020 10:31 | https://github.com/feast-dev/feast/pull/685#event-3351182418 |
| https://github.com/woop |
| woop | https://github.com/woop |
| force-pushed | https://github.com/feast-dev/feast/compare/68eb265a4de38989705b27e02f49aab25d1cc311..35f8f188c8294db4ed45d94df48d3ebf63b1cbe3 |
| 68eb265 | https://github.com/feast-dev/feast/commit/68eb265a4de38989705b27e02f49aab25d1cc311 |
| 35f8f18 | https://github.com/feast-dev/feast/commit/35f8f188c8294db4ed45d94df48d3ebf63b1cbe3 |
|
Compare
| https://github.com/feast-dev/feast/compare/68eb265a4de38989705b27e02f49aab25d1cc311..35f8f188c8294db4ed45d94df48d3ebf63b1cbe3 |
| May 24, 2020 06:47 | https://github.com/feast-dev/feast/pull/685#event-3367694745 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| May 24, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-633212239 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| @zhilingc | https://github.com/zhilingc |
| @woop | https://github.com/woop |
| @zhilingc | https://github.com/zhilingc |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 24, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-633214753 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| May 25, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-633364373 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| Relevant SO | https://stackoverflow.com/questions/5268466/how-does-hibernate-detect-dirty-state-of-an-entity-object |
| @zhilingc | https://github.com/zhilingc |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 25, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-633419007 |
| @zhilingc | https://github.com/zhilingc |
| @ches | https://github.com/ches |
| @khorshuheng | https://github.com/khorshuheng |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| May 26, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-633803212 |
| Feature Sets being designed as designed Ingestion Concept | https://docs.google.com/document/d/1QnUQWhwJ1fDnMQ4sZdUdLa_4C-x5Hhpw3C8nYLg4nsY/edit |
| @zhilingc | https://github.com/zhilingc |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| May 26, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-633913289 |
| @woop | https://github.com/woop |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 26, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-633923848 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/zhilingc |
| zhilingc | https://github.com/zhilingc |
| May 27, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-634398826 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/woop |
| woop | https://github.com/woop |
| May 27, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-634420619 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| force-pushed | https://github.com/feast-dev/feast/compare/785208a9c4df7024f16a0810525702228733728f..ce63d630c238c1a918b67b61eb24aa334377700a |
| 785208a | https://github.com/feast-dev/feast/commit/785208a9c4df7024f16a0810525702228733728f |
| ce63d63 | https://github.com/feast-dev/feast/commit/ce63d630c238c1a918b67b61eb24aa334377700a |
|
Compare
| https://github.com/feast-dev/feast/compare/785208a9c4df7024f16a0810525702228733728f..ce63d630c238c1a918b67b61eb24aa334377700a |
| May 29, 2020 09:18 | https://github.com/feast-dev/feast/pull/685#event-3386358932 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Jun 3, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-423638740 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files |
| core/src/main/java/feast/core/service/JobCoordinatorService.java | https://github.com/feast-dev/feast/pull/685/files#diff-e00c51ab165ad0121271c6f080f7ec67812bf01ceb58b571f58d735fd6f184ba |
| woop | https://github.com/woop |
| Jun 3, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r434630721 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| Jun 12, 2020 | https://github.com/feast-dev/feast/pull/685#event-3436931725 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| Jun 12, 2020 | https://github.com/feast-dev/feast/pull/685#event-3436932121 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| Jun 12, 2020 | https://github.com/feast-dev/feast/pull/685#event-3436937239 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| force-pushed | https://github.com/feast-dev/feast/compare/69befc5642894e5a0750f69ae4a7e4fffb35e851..60acbd80701c9e521d81823ff26db1fccb3139d6 |
| 69befc5 | https://github.com/feast-dev/feast/commit/69befc5642894e5a0750f69ae4a7e4fffb35e851 |
| 60acbd8 | https://github.com/feast-dev/feast/commit/60acbd80701c9e521d81823ff26db1fccb3139d6 |
|
Compare
| https://github.com/feast-dev/feast/compare/69befc5642894e5a0750f69ae4a7e4fffb35e851..60acbd80701c9e521d81823ff26db1fccb3139d6 |
| June 12, 2020 07:39 | https://github.com/feast-dev/feast/pull/685#event-3437283156 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| Jun 12, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-643150644 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jun 12, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-429651764 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files |
| core/src/main/java/feast/core/model/Job.java | https://github.com/feast-dev/feast/pull/685/files#diff-e95558185cd29f6683ba92d36d8f88fca53ea9dcf57a23813a257a1462593144 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| core/src/main/java/feast/core/service/JobCoordinatorService.java | https://github.com/feast-dev/feast/pull/685/files#diff-e00c51ab165ad0121271c6f080f7ec67812bf01ceb58b571f58d735fd6f184ba |
| pyalex | https://github.com/pyalex |
| Jun 12, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r439361723 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| pyalex | https://github.com/pyalex |
| Jun 12, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r439366095 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| mrzzy | https://github.com/mrzzy |
| Jun 16, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r440623224 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| pyalex | https://github.com/pyalex |
| Jun 16, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r440636132 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| mrzzy | https://github.com/mrzzy |
| Jun 16, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r440656310 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| core/src/main/java/feast/core/service/JobCoordinatorService.java | https://github.com/feast-dev/feast/pull/685/files#diff-e00c51ab165ad0121271c6f080f7ec67812bf01ceb58b571f58d735fd6f184ba |
| pyalex | https://github.com/pyalex |
| Jun 12, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r439365470 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| mrzzy | https://github.com/mrzzy |
| Jun 16, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r440623204 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jun 12, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-429680320 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files |
| core/src/main/java/feast/core/job/JobUpdateTask.java | https://github.com/feast-dev/feast/pull/685/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
| pyalex | https://github.com/pyalex |
| Jun 12, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r439374090 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| mrzzy | https://github.com/mrzzy |
| Jun 16, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r440623188 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| core/src/main/java/feast/core/service/JobCoordinatorService.java | https://github.com/feast-dev/feast/pull/685/files#diff-e00c51ab165ad0121271c6f080f7ec67812bf01ceb58b571f58d735fd6f184ba |
| pyalex | https://github.com/pyalex |
| Jun 12, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r439379816 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| mrzzy | https://github.com/mrzzy |
| Jun 16, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r440623163 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jun 16, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-431222816 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files |
| core/src/main/java/feast/core/service/JobCoordinatorService.java | https://github.com/feast-dev/feast/pull/685/files#diff-e00c51ab165ad0121271c6f080f7ec67812bf01ceb58b571f58d735fd6f184ba |
| pyalex | https://github.com/pyalex |
| Jun 16, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r440636132 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jun 16, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-431224182 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files |
| core/src/test/java/feast/core/service/JobCoordinatorServiceTest.java | https://github.com/feast-dev/feast/pull/685/files#diff-e6b95e0f18caa73bbda2401ec5f10d37c38454eaf36b9f0dcef328dbc3e9e671 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| force-pushed | https://github.com/feast-dev/feast/compare/bfc6f00f43685914a853b7024cc3027c49417ffc..6894c589220275e2288ee9d5a41fd1abd04217c3 |
| bfc6f00 | https://github.com/feast-dev/feast/commit/bfc6f00f43685914a853b7024cc3027c49417ffc |
| 6894c58 | https://github.com/feast-dev/feast/commit/6894c589220275e2288ee9d5a41fd1abd04217c3 |
|
Compare
| https://github.com/feast-dev/feast/compare/bfc6f00f43685914a853b7024cc3027c49417ffc..6894c589220275e2288ee9d5a41fd1abd04217c3 |
| June 18, 2020 13:35 | https://github.com/feast-dev/feast/pull/685#event-3458159754 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jun 18, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-433341951 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files |
| core/src/main/java/feast/core/config/FeatureStreamConfig.java | https://github.com/feast-dev/feast/pull/685/files#diff-6e54d5db36dd7d25e5dac448e913a1619940a61d20503fd9008c04dfd646a8a3 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jun 18, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-433360758 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files |
| core/src/main/java/feast/core/job/JobUpdateTask.java | https://github.com/feast-dev/feast/pull/685/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
| pyalex | https://github.com/pyalex |
| Jun 18, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r442284450 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| mrzzy | https://github.com/mrzzy |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r442600983 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jun 18, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-433382591 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files |
| core/src/main/java/feast/core/model/Source.java | https://github.com/feast-dev/feast/pull/685/files#diff-c65e26511a5452315ab7a63d527b18190a2d6ffbe7b754183db0357849d82808 |
| pyalex | https://github.com/pyalex |
| Jun 18, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r442300520 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| pyalex | https://github.com/pyalex |
| Jun 18, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r442344586 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| mrzzy | https://github.com/mrzzy |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#discussion_r442589527 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| mrzzy | https://github.com/mrzzy |
| June 19, 2020 09:15 | https://github.com/feast-dev/feast/pull/685#commits-pushed-eca5f09 |
|
| https://github.com/mrzzy |
| Rebase & squash on master | https://github.com/feast-dev/feast/pull/685/commits/eca5f09d6108a7edd61611107dd621fb96a57f0b |
| eca5f09 | https://github.com/feast-dev/feast/pull/685/commits/eca5f09d6108a7edd61611107dd621fb96a57f0b |
|
| https://github.com/mrzzy |
| Fix java unit tests | https://github.com/feast-dev/feast/pull/685/commits/d176811e3ffe63c26b2401ef6f6e7e48474962d5 |
| d176811 | https://github.com/feast-dev/feast/pull/685/commits/d176811e3ffe63c26b2401ef6f6e7e48474962d5 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#event-3460622955 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#event-3460623057 |
| mrzzy | https://github.com/mrzzy |
| June 19, 2020 09:45 | https://github.com/feast-dev/feast/pull/685#commits-pushed-af3c88d |
|
| https://github.com/mrzzy |
| Rebase on JobService PR fix | https://github.com/feast-dev/feast/pull/685/commits/af3c88d7bdf749b46fe1104ccffaa042843404aa |
| af3c88d | https://github.com/feast-dev/feast/pull/685/commits/af3c88d7bdf749b46fe1104ccffaa042843404aa |
|
| https://github.com/mrzzy |
| Update JobUpdateTask's createJobId() to generate id based on source c… | https://github.com/feast-dev/feast/pull/685/commits/509e31b3f379729de05128c788cede310a8404c9 |
| 509e31b | https://github.com/feast-dev/feast/pull/685/commits/509e31b3f379729de05128c788cede310a8404c9 |
|
| https://github.com/mrzzy |
| Fix wrong conflict resolve in FeatureStreamConfig | https://github.com/feast-dev/feast/pull/685/commits/ac798c79edca68c31ebce1885e305c05c8c815e5 |
| ac798c7 | https://github.com/feast-dev/feast/pull/685/commits/ac798c79edca68c31ebce1885e305c05c8c815e5 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| force-pushed | https://github.com/feast-dev/feast/compare/8ec69e46d0a9604c8da9d156e9017f3f40522a81..ac798c79edca68c31ebce1885e305c05c8c815e5 |
| 8ec69e4 | https://github.com/feast-dev/feast/commit/8ec69e46d0a9604c8da9d156e9017f3f40522a81 |
| ac798c7 | https://github.com/feast-dev/feast/commit/ac798c79edca68c31ebce1885e305c05c8c815e5 |
|
Compare
| https://github.com/feast-dev/feast/compare/8ec69e46d0a9604c8da9d156e9017f3f40522a81..ac798c79edca68c31ebce1885e305c05c8c815e5 |
| June 19, 2020 02:40 | https://github.com/feast-dev/feast/pull/685#event-3460727069 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
|
Jun 19, 2020
| https://github.com/feast-dev/feast/pull/685#pullrequestreview-433802336 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/685/files/ac798c79edca68c31ebce1885e305c05c8c815e5 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-646435307 |
| pyalex | https://github.com/feast-dev/feast/pull/685#pullrequestreview-433802336 |
| woop | https://github.com/feast-dev/feast/pull/685 |
| here | https://go.k8s.io/bot-commands?repo=feast-dev%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/feast-dev/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/pyalex |
| pyalex | https://github.com/pyalex |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-646441950 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| pyalex | https://github.com/pyalex |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#event-3460996210 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#event-3460996244 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#issuecomment-646443485 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
do-not-merge/hold
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Ado-not-merge%2Fhold |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#event-3461007736 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| f425d7d | https://github.com/feast-dev/feast/commit/f425d7de64392217bbd65a4f07ad2848751a122d |
| Jun 19, 2020 | https://github.com/feast-dev/feast/pull/685#event-3461043333 |
| https://github.com/mrzzy |
| mrzzy | https://github.com/mrzzy |
|
Jun 30, 2020
| https://github.com/feast-dev/feast/pull/685#ref-issue-647170882 |
|
Add Labels to Source Object
#835
| https://github.com/feast-dev/feast/issues/835 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F685 |
|
| https://github.com/zhilingc |
|
zhilingc
| https://github.com/zhilingc |
|
| https://github.com/feast-dev/feast/pull/685/files/e98288305126593a7d2b26f09cae74732a0c109d |
|
| https://github.com/mrzzy |
|
mrzzy
| https://github.com/mrzzy |
|
| https://github.com/feast-dev/feast/pull/685/files/ac798c79edca68c31ebce1885e305c05c8c815e5 |
|
| https://github.com/pyalex |
|
pyalex
| https://github.com/pyalex |
|
| https://github.com/feast-dev/feast/pull/685/files/ac798c79edca68c31ebce1885e305c05c8c815e5 |
|
| https://github.com/pradithya |
|
pradithya
| https://github.com/pradithya |
|
| https://github.com/davidheryanto |
|
davidheryanto
| https://github.com/davidheryanto |
|
| https://github.com/khorshuheng |
|
khorshuheng
| https://github.com/khorshuheng |
|
| https://github.com/pyalex |
|
pyalex
| https://github.com/pyalex |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
compat/breaking
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Acompat%2Fbreaking |
|
kind/techdebt
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Akind%2Ftechdebt |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
size/XXL
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FXXL |
|
Source data model in Feast Core should be generalized
| https://github.com/feast-dev/feast/issues/632 |
| Please reload this page | https://github.com/feast-dev/feast/pull/685 |
|
| https://github.com/woop |
|
| https://github.com/zhilingc |
|
| https://github.com/mrzzy |
|
| https://github.com/feast-ci-bot |
|
| https://github.com/pyalex |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |