René's URL Explorer Experiment


Title: fix: Answer online requests that carry zero entity rows by Daksha1611 · Pull Request #6820 · feast-dev/feast · GitHub

Open Graph Title: fix: Answer online requests that carry zero entity rows by Daksha1611 · Pull Request #6820 · feast-dev/feast

X Title: fix: Answer online requests that carry zero entity rows by Daksha1611 · Pull Request #6820 · feast-dev/feast

Description: What this PR does / why we need it: Three empty-input shapes reached internal exceptions, and the feature server turned each into an HTTP 500: entity_rows=[] -> IndexError: list index out of range entities={"driver_id": []} -> KeyError: Missing join key values for keys: [] entities={} -> KeyError: 'pop from an empty set' The middle case is a well-formed request: the join key was supplied, it simply holds no values, which is what a caller sends when the upstream query matched nothing that run. Three causes, fixed here: get_online_features built its columnar dict from entity_rows[0] on both the sync and async paths, so an empty list raised before anything else ran. _validate_entity_values ended with set_of_row_lengths.pop(); for a mapping with no columns the set is empty and pop() raised. It now reports zero rows. _get_unique_entities treated a join key present with zero values the same as one never supplied — even though the row-wise conversion immediately below it already returns empty results for that case (if not rowise: return (), (), 0). It now raises only when nothing at all was supplied for the view. That last change is deliberately narrow, so existing behaviour is preserved: a partially supplied key set still proceeds (covered by test_get_unique_entities_missing_join_key_success), and a caller supplying nothing relevant still errors with the same message listing the expected keys (covered by test_get_unique_entities_missing_all_join_keys_error). The error is now MissingJoinKeyValuesException, carrying HTTP 400 so the server reports a client error rather than a 500. It subclasses KeyError as well, since that is what this condition raised before and callers catch it — so this is not a breaking change. Resulting behaviour: join keys supplied but empty → 200 with an empty result and correct feature-name metadata; nothing supplied → 400 naming the missing key. Which issue(s) this PR fixes: Fixes #6819 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change New sdk/python/tests/unit/online_store/test_empty_entity_rows.py. Four of its five tests fail on master, reproducing all three symptoms above; the fifth asserts the new exception is still a KeyError and carries 400. Full sdk/python/tests/unit: 2612 passed, 24 skipped. The 6 failures and 28 errors in that run are environmental and present on master too — PySpark worker/driver Python version mismatch, a torch import, MongoDB testcontainers, and a missing CUDA library. ruff check, ruff format --check and mypy are clean on all changed files. Misc An empty response was chosen over a 400 for the empty-but-present case, so batch-scoring callers don't have to special-case "my filter matched nothing". It also lines up with get_historical_features returning an empty frame for a zero-row entity_df. Happy to switch to a 400 if maintainers prefer the stricter reading.

Open Graph Description: What this PR does / why we need it: Three empty-input shapes reached internal exceptions, and the feature server turned each into an HTTP 500: entity_rows=[] -> IndexError: list ind...

X Description: What this PR does / why we need it: Three empty-input shapes reached internal exceptions, and the feature server turned each into an HTTP 500: entity_rows=[] -> IndexError: list...

Opengraph URL: https://github.com/feast-dev/feast/pull/6820

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9ad61bf1-2f1a-0ebb-8e1d-6d3a4d9d87be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA820:2A4404:E71F6F:13092E1:6AFE9560
html-safe-nonce0ef295cc1674fa00e286065904e1d59c46df539a10c9c446805002c7aeebe86a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODIwOjJBNDQwNDpFNzFGNkY6MTMwOTJFMTo2QUZFOTU2MCIsInZpc2l0b3JfaWQiOiI3NjA0NTM0NzUzODEwNjE3Njk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccac416b3265e529dc4a9a37c7559288d309eb6e495ff8e06a036d594949af240
hovercard-subject-tagpull_request:4460789483
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6820/files
twitter:imagehttps://avatars.githubusercontent.com/u/113719658?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/113719658?s=400&v=4
og:image:altWhat this PR does / why we need it: Three empty-input shapes reached internal exceptions, and the feature server turned each into an HTTP 500: entity_rows=[] -> IndexError: list ind...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6820/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6820%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6820%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6820/files
Reloadhttps://github.com/feast-dev/feast/pull/6820/files
Reloadhttps://github.com/feast-dev/feast/pull/6820/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Daksha1611https://github.com/Daksha1611
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Daksha1611:fix/empty-entity-rowshttps://github.com/Daksha1611/feast/tree/fix/empty-entity-rows
Conversation 2 https://github.com/feast-dev/feast/pull/6820
Commits 2 https://github.com/feast-dev/feast/pull/6820/commits
Checks 23 https://github.com/feast-dev/feast/pull/6820/checks
Files changed https://github.com/feast-dev/feast/pull/6820/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6820/files
fix: Answer online requests that carry zero entity rows https://github.com/feast-dev/feast/pull/6820/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6820/files
6cb5ddc fix: Answer online requests that carry zero entity rows Daksha1611 Sep 7, 2026 https://github.com/feast-dev/feast/pull/6820/commits/6cb5ddcd31bc506cabd72b48dc351a380050e975
4822b16 test: Cover the async path for empty entity rows Daksha1611 Sep 8, 2026 https://github.com/feast-dev/feast/pull/6820/commits/4822b162de3ffc254950a722defb12ae1f81f287
Clear filters https://github.com/feast-dev/feast/pull/6820/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6820/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6820/files
errors.py https://github.com/feast-dev/feast/pull/6820/files#diff-c39381f96c36ead6e0306b9422b8d355996bcc1179bd86ad754201f68184e27a
online_store.py https://github.com/feast-dev/feast/pull/6820/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
utils.py https://github.com/feast-dev/feast/pull/6820/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
test_empty_entity_rows.py https://github.com/feast-dev/feast/pull/6820/files#diff-5142845d629721025be201697d3be0383d563a237fab4c17678ad93b96dd7c15
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/errors.pyhttps://github.com/feast-dev/feast/pull/6820/files#diff-c39381f96c36ead6e0306b9422b8d355996bcc1179bd86ad754201f68184e27a
View file https://github.com/feast-dev/feast/blob/4822b162de3ffc254950a722defb12ae1f81f287/sdk/python/feast/errors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6820/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6820/files#diff-c39381f96c36ead6e0306b9422b8d355996bcc1179bd86ad754201f68184e27a
https://github.com/feast-dev/feast/pull/6820/files#diff-c39381f96c36ead6e0306b9422b8d355996bcc1179bd86ad754201f68184e27a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L15
sdk/python/feast/infra/online_stores/online_store.pyhttps://github.com/feast-dev/feast/pull/6820/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
View file https://github.com/feast-dev/feast/blob/4822b162de3ffc254950a722defb12ae1f81f287/sdk/python/feast/infra/online_stores/online_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6820/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6820/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6820/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6820/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6820/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/utils.pyhttps://github.com/feast-dev/feast/pull/6820/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
View file https://github.com/feast-dev/feast/blob/4822b162de3ffc254950a722defb12ae1f81f287/sdk/python/feast/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6820/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6820/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6820/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6820/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6820/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6820/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/pull/6820/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/online_store/test_empty_entity_rows.pyhttps://github.com/feast-dev/feast/pull/6820/files#diff-5142845d629721025be201697d3be0383d563a237fab4c17678ad93b96dd7c15
View file https://github.com/feast-dev/feast/blob/4822b162de3ffc254950a722defb12ae1f81f287/sdk/python/tests/unit/online_store/test_empty_entity_rows.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6820/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/6820/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.