René's URL Explorer Experiment


Title: fix: Normalize Dask timestamps to UTC without a row-wise apply by Daksha1611 · Pull Request #6818 · feast-dev/feast · GitHub

Open Graph Title: fix: Normalize Dask timestamps to UTC without a row-wise apply by Daksha1611 · Pull Request #6818 · feast-dev/feast

X Title: fix: Normalize Dask timestamps to UTC without a row-wise apply by Daksha1611 · Pull Request #6818 · feast-dev/feast

Description: What this PR does / why we need it: _normalize_timestamp made timestamp columns tz-aware with a row-wise apply that declared meta=(timestamp_field, "datetime64[ns, UTC]"). meta only declares the dtype — the partition gets whatever the lambda returns. With zero rows the lambda never runs, so the computed column stayed tz-naive while meta claimed UTC, and the tz-aware comparison in _filter_ttl then raised: TypeError: Invalid comparison between dtype=datetime64[ns] and DatetimeArray A zero-row entity_df is a normal case in batch scoring — the upstream query matched nothing for that run — so get_historical_features crashed instead of returning an empty result. While fixing this I found the same mismatch on a second path: a column carrying a non-UTC timezone also diverged from the declared meta, because the lambda returned any value that already had tzinfo untouched. That is covered by a test here too. Both applies are replaced with dd.to_datetime(..., utc=True), which localizes tz-naive values, converts tz-aware ones, and yields the correct dtype for an empty frame. It is also vectorized, so it drops a Python-level call per row on non-empty frames. Which issue(s) this PR fixes: Fixes #6817 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change New sdk/python/tests/unit/infra/offline_stores/test_dask_empty_entity_df.py covers normalization and TTL filtering at 0 and 1 rows, plus the non-UTC case. Three of its five assertions fail on master and pass here; the two 1-row cases pass both ways, pinning the non-empty behaviour as unchanged. Verified end to end as well: get_historical_features(...).to_df() against a file offline store with an otherwise identical entity frame raised TypeError at 0 rows before this change, and now returns an empty frame with the expected columns while the 1-row case is unchanged. sdk/python/tests/unit/infra/offline_stores plus test_unit_feature_store.py: 235 passed. The 20 errors in that run are MongoDB testcontainers failing to start locally and are present on master too. ruff check, ruff format --check and mypy are clean on both changed files. Misc Point-in-time correctness is unaffected — I re-ran the filter_by_created_timestamp scenario (a row backfilled after the entity timestamp) and it still excludes the late row with the flag and includes it without.

Open Graph Description: What this PR does / why we need it: _normalize_timestamp made timestamp columns tz-aware with a row-wise apply that declared meta=(timestamp_field, "datetime64[ns, UTC]"). meta only decla...

X Description: What this PR does / why we need it: _normalize_timestamp made timestamp columns tz-aware with a row-wise apply that declared meta=(timestamp_field, "datetime64[ns, UTC]"). meta on...

Opengraph URL: https://github.com/feast-dev/feast/pull/6818

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:961c6970-5e44-bd70-9b77-9e5f73853bed
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADE4:ECEED:250CF8:332C81:6AFE9565
html-safe-noncea7bd43de93afe9363e6bc792f3d623fa93826b502e4853929819100aa58fda72
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREU0OkVDRUVEOjI1MENGODozMzJDODE6NkFGRTk1NjUiLCJ2aXNpdG9yX2lkIjoiNzY0MTc0MjE4NDM0NDg4NDU4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac65bd62f8154cb74460bd50704ad75a622b5ab70da4e0e2d0870a3c074c4f92c0
hovercard-subject-tagpull_request:4457638324
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6818/files
twitter:imagehttps://avatars.githubusercontent.com/u/113719658?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/113719658?s=400&v=4
og:image:altWhat this PR does / why we need it: _normalize_timestamp made timestamp columns tz-aware with a row-wise apply that declared meta=(timestamp_field, "datetime64[ns, UTC]"). meta only decla...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6818/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6818%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6818%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6818/files
Reloadhttps://github.com/feast-dev/feast/pull/6818/files
Reloadhttps://github.com/feast-dev/feast/pull/6818/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
Daksha1611https://github.com/Daksha1611
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Daksha1611:fix/dask-empty-entity-dfhttps://github.com/Daksha1611/feast/tree/fix/dask-empty-entity-df
Conversation 1 https://github.com/feast-dev/feast/pull/6818
Commits 3 https://github.com/feast-dev/feast/pull/6818/commits
Checks 1 https://github.com/feast-dev/feast/pull/6818/checks
Files changed https://github.com/feast-dev/feast/pull/6818/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6818/files
fix: Normalize Dask timestamps to UTC without a row-wise apply https://github.com/feast-dev/feast/pull/6818/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/6818/files
042397e fix: Normalize Dask timestamps to UTC without a row-wise apply Daksha1611 Sep 6, 2026 https://github.com/feast-dev/feast/pull/6818/commits/042397e7b2ace8052c5a7b641f9d651dfcb06b77
0604a7a Merge branch 'master' into fix/dask-empty-entity-df Daksha1611 Sep 11, 2026 https://github.com/feast-dev/feast/pull/6818/commits/0604a7a597bf589a391ad9cb678cb6e2138d10b4
15f72fe Merge branch 'master' into fix/dask-empty-entity-df Daksha1611 Oct 6, 2026 https://github.com/feast-dev/feast/pull/6818/commits/15f72fe9069503d3d229949815b44ef8c36edfc2
Clear filters https://github.com/feast-dev/feast/pull/6818/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6818/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6818/files
dask.py https://github.com/feast-dev/feast/pull/6818/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
test_dask_empty_entity_df.py https://github.com/feast-dev/feast/pull/6818/files#diff-15358dcb413a5a46a5af16fce8ddd71ab4f990f81aa3977cf02257bba4ecbb90
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/dask.pyhttps://github.com/feast-dev/feast/pull/6818/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
View file https://github.com/feast-dev/feast/blob/15f72fe9069503d3d229949815b44ef8c36edfc2/sdk/python/feast/infra/offline_stores/dask.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6818/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6818/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6818/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6818/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6818/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/offline_stores/test_dask_empty_entity_df.pyhttps://github.com/feast-dev/feast/pull/6818/files#diff-15358dcb413a5a46a5af16fce8ddd71ab4f990f81aa3977cf02257bba4ecbb90
View file https://github.com/feast-dev/feast/blob/15f72fe9069503d3d229949815b44ef8c36edfc2/sdk/python/tests/unit/infra/offline_stores/test_dask_empty_entity_df.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6818/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.