René's URL Explorer Experiment


Title: fix: Fall back to the serialized body when UDF source misses globals by Daksha1611 · Pull Request #6816 · feast-dev/feast · GitHub

Open Graph Title: fix: Fall back to the serialized body when UDF source misses globals by Daksha1611 · Pull Request #6816 · feast-dev/feast

X Title: fix: Fall back to the serialized body when UDF source misses globals by Daksha1611 · Pull Request #6816 · feast-dev/feast

Description: What this PR does / why we need it: Source-first UDF rehydration execs only the UDF's own source into a namespace seeded with pandas/numpy. A UDF that reads a helper, constant, or aliased import from its defining module cannot resolve those names — but the exec still succeeds, because a function body's free variables are only looked up when the function is called. resolve_udf therefore treated rehydration as successful and never fell back to the dill body, even when that body carried the captured globals and would have run. The failure surfaced later as a NameError during retrieval, so an on-demand feature view that served correctly before started raising once it was loaded from the registry: NameError: name 'scaled' is not defined This validates the rebuilt callable before accepting it: walk its LOAD_GLOBAL operands, plus those of nested code objects (inner functions, comprehensions), and return None when a name resolves in neither the exec namespace nor builtins. resolve_udf then falls back to the serialized body exactly as it did before. Only LOAD_GLOBAL operands are inspected. co_names also contains attribute names (df.columns), so checking that instead would flag working UDFs and push them onto the dill path for no reason — there's a regression test covering that. Self-contained UDFs are unaffected and still take the source path, so the Spark segfault and cross-Python-version benefits of source-first rehydration are kept intact. Which issue(s) this PR fixes: Fixes #6815 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Four regression tests added to sdk/python/tests/unit/transformation/test_udf_rehydrate.py. Three of them fail on master and pass here; the fourth (test_attribute_access_is_not_ mistaken_for_a_missing_global) passes both ways by design, guarding the co_names false-positive trap described above. Verified end to end as well: an ODFV applied from a script, then read back in a separate process holding only the registry, returned NameError before this change and the correct value after. sdk/python/tests/unit filtered to the transformation / on-demand / feature-view areas: 314 passed, 5 skipped. The 9 errors in that run are MongoDB testcontainers failing to start locally and are present on master too. ruff check, ruff format --check and mypy are clean on both changed files. Misc The pre-existing test_resolve_udf_prefers_source_over_garbage_dill_body still passes, which confirms self-contained UDFs continue to prefer source over the body.

Open Graph Description: What this PR does / why we need it: Source-first UDF rehydration execs only the UDF's own source into a namespace seeded with pandas/numpy. A UDF that reads a helper, constant, or aliased impor...

X Description: What this PR does / why we need it: Source-first UDF rehydration execs only the UDF's own source into a namespace seeded with pandas/numpy. A UDF that reads a helper, constant, or aliased i...

Opengraph URL: https://github.com/feast-dev/feast/pull/6816

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c72c502f-6510-1e7f-ec7c-38539b3caff4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9676:29B1E5:D7CE9:120CCF:6AFE9269
html-safe-nonce28ed40eccab930e0d7fab35792920ca768de0bfeecadb2b609b1370a352b3744
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Njc2OjI5QjFFNTpEN0NFOToxMjBDQ0Y6NkFGRTkyNjkiLCJ2aXNpdG9yX2lkIjoiNTkwNjc4NjMzOTc4NDY1OTU2MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac408a066fc96c4856baa732eaa53473a253634c0b72bd7c323427b2d09379de82
hovercard-subject-tagpull_request:4457365818
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6816/files
twitter:imagehttps://avatars.githubusercontent.com/u/113719658?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/113719658?s=400&v=4
og:image:altWhat this PR does / why we need it: Source-first UDF rehydration execs only the UDF's own source into a namespace seeded with pandas/numpy. A UDF that reads a helper, constant, or aliased impor...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6816/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6816%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6816%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6816/files
Reloadhttps://github.com/feast-dev/feast/pull/6816/files
Reloadhttps://github.com/feast-dev/feast/pull/6816/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
shuchuhttps://github.com/shuchu
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Daksha1611:fix/odfv-udf-globals-rehydratehttps://github.com/Daksha1611/feast/tree/fix/odfv-udf-globals-rehydrate
Conversation 3 https://github.com/feast-dev/feast/pull/6816
Commits 6 https://github.com/feast-dev/feast/pull/6816/commits
Checks 1 https://github.com/feast-dev/feast/pull/6816/checks
Files changed https://github.com/feast-dev/feast/pull/6816/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6816/files
fix: Fall back to the serialized body when UDF source misses globals https://github.com/feast-dev/feast/pull/6816/files#top
Show all changes 6 commits https://github.com/feast-dev/feast/pull/6816/files
dee6ef0 fix: Fall back to the serialized body when UDF source misses globals Daksha1611 Sep 6, 2026 https://github.com/feast-dev/feast/pull/6816/commits/dee6ef046a8e6e87c210c4cbb2e0ee2425818736
6956297 Merge branch 'master' into fix/odfv-udf-globals-rehydrate Daksha1611 Sep 11, 2026 https://github.com/feast-dev/feast/pull/6816/commits/6956297a615a2bc64e5ea5f7837bc311279c471d
2974eaa Merge branch 'master' into fix/odfv-udf-globals-rehydrate Daksha1611 Sep 15, 2026 https://github.com/feast-dev/feast/pull/6816/commits/2974eaadf972ae5a54926377c9814d3d02a715a4
8293673 Merge branch 'master' into fix/odfv-udf-globals-rehydrate Daksha1611 Sep 15, 2026 https://github.com/feast-dev/feast/pull/6816/commits/82936734627f5a52c102b86768794ee20c69bc77
e330597 Merge branch 'master' into fix/odfv-udf-globals-rehydrate Daksha1611 Oct 6, 2026 https://github.com/feast-dev/feast/pull/6816/commits/e33059720c9e991a6c9a9f97d2fadf48462d9ff7
54676cc Merge branch 'master' into fix/odfv-udf-globals-rehydrate shuchu Nov 10, 2026 https://github.com/feast-dev/feast/pull/6816/commits/54676cc5e6835ffb54737122be800415105c7899
Clear filters https://github.com/feast-dev/feast/pull/6816/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6816/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6816/files
udf_rehydrate.py https://github.com/feast-dev/feast/pull/6816/files#diff-4bd8c0f54e3625736dbbf49e76b41ab0afdcf7b748aed69273590e04bff575af
test_udf_rehydrate.py https://github.com/feast-dev/feast/pull/6816/files#diff-ff1a4011ebfc22c074d506d74521037ace06cf7eda5c7cf5b5e0812d53d1ecd2
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/transformation/udf_rehydrate.pyhttps://github.com/feast-dev/feast/pull/6816/files#diff-4bd8c0f54e3625736dbbf49e76b41ab0afdcf7b748aed69273590e04bff575af
View file https://github.com/Daksha1611/feast/blob/54676cc5e6835ffb54737122be800415105c7899/sdk/python/feast/transformation/udf_rehydrate.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6816/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6816/files#diff-4bd8c0f54e3625736dbbf49e76b41ab0afdcf7b748aed69273590e04bff575af
https://github.com/feast-dev/feast/pull/6816/files#diff-4bd8c0f54e3625736dbbf49e76b41ab0afdcf7b748aed69273590e04bff575af
https://github.com/feast-dev/feast/pull/6816/files#diff-4bd8c0f54e3625736dbbf49e76b41ab0afdcf7b748aed69273590e04bff575af
https://github.com/feast-dev/feast/pull/6816/files#diff-4bd8c0f54e3625736dbbf49e76b41ab0afdcf7b748aed69273590e04bff575af
https://github.com/feast-dev/feast/pull/6816/files#diff-4bd8c0f54e3625736dbbf49e76b41ab0afdcf7b748aed69273590e04bff575af
https://github.com/feast-dev/feast/pull/6816/files#diff-4bd8c0f54e3625736dbbf49e76b41ab0afdcf7b748aed69273590e04bff575af
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/transformation/test_udf_rehydrate.pyhttps://github.com/feast-dev/feast/pull/6816/files#diff-ff1a4011ebfc22c074d506d74521037ace06cf7eda5c7cf5b5e0812d53d1ecd2
View file https://github.com/Daksha1611/feast/blob/54676cc5e6835ffb54737122be800415105c7899/sdk/python/tests/unit/transformation/test_udf_rehydrate.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6816/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6816/files#diff-ff1a4011ebfc22c074d506d74521037ace06cf7eda5c7cf5b5e0812d53d1ecd2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.