René's URL Explorer Experiment


Title: fix: Preserve entity row order in precomputed reads by JodeZer · Pull Request #6806 · feast-dev/feast · GitHub

Open Graph Title: fix: Preserve entity row order in precomputed reads by JodeZer · Pull Request #6806 · feast-dev/feast

X Title: fix: Preserve entity row order in precomputed reads by JodeZer · Pull Request #6806 · feast-dev/feast

Description: What this PR does / why we need it: Precomputed online retrieval deduplicates and sorts entity keys before reading their vectors. The fast path previously wrote those vectors into response rows by enumeration order instead of mapping them back to the original request rows. Unsorted requests could therefore receive another entity's features, and repeated entities were not fanned out to every requested row. This is a user-facing correctness fix. It passes the entity-to-request-row mapping into the precomputed fast path and scatters values, field statuses, and timestamps back to their original positions while preserving the existing deduplicated read and parse behavior. Both synchronous and asynchronous public get_online_features paths are covered. Which issue(s) this PR fixes: Fixes #6805 The affected precomputed path was introduced by #6463 for #6185. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Successful checks: Precomputed feature vector unit file: 62 passed, including sync and async public retrieval with unordered and duplicate entities. Adjacent unique-entity and async feature-server tests: 5 passed. Full repository lint: Ruff passed for 917 files; mypy passed for 627 source files. Feast pre-commit and pre-push hooks passed. The full make test-python-unit run completed with 2630 passed and 17 skipped, but exited nonzero with 17 failures and 22 errors unrelated to the changed files. Local failures were confined to existing environment-sensitive areas: SQLite extension loading, CLI repository templates, Docling dependency compatibility, and MongoDB test-container port mapping. All 62 tests in the modified precomputed suite passed within that full run. Misc No public API, protobuf, storage schema, or dependency changes. Release note Fix precomputed online retrieval to preserve entity input order and duplicate rows.

Open Graph Description: What this PR does / why we need it: Precomputed online retrieval deduplicates and sorts entity keys before reading their vectors. The fast path previously wrote those vectors into response rows by ...

X Description: What this PR does / why we need it: Precomputed online retrieval deduplicates and sorts entity keys before reading their vectors. The fast path previously wrote those vectors into response rows by ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6806

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:55f3044a-043b-1d4f-12c5-1e19d4e72388
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8610:22BB81:F9014D:147EDE0:6AFE9885
html-safe-nonce7561c3813f587a2da6335358e6fcc6bee68ba4d568dfc74d3afaadbd2b8f55bf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjEwOjIyQkI4MTpGOTAxNEQ6MTQ3RURFMDo2QUZFOTg4NSIsInZpc2l0b3JfaWQiOiI0NjIyODU5MjY1OTczODUyMjkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacea458e78a672770f758c54588493313be5da518be3a592537aa6c21b2ada8c8c
hovercard-subject-tagpull_request:4411013965
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6806/files
twitter:imagehttps://avatars.githubusercontent.com/u/9582429?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9582429?s=400&v=4
og:image:altWhat this PR does / why we need it: Precomputed online retrieval deduplicates and sorts entity keys before reading their vectors. The fast path previously wrote those vectors into response rows by ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6806/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6806%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6806%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6806/files
Reloadhttps://github.com/feast-dev/feast/pull/6806/files
Reloadhttps://github.com/feast-dev/feast/pull/6806/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
JodeZer:fix/precomputed-entity-row-orderhttps://github.com/JodeZer/feast/tree/fix/precomputed-entity-row-order
Conversation 1 https://github.com/feast-dev/feast/pull/6806
Commits 1 https://github.com/feast-dev/feast/pull/6806/commits
Checks 1 https://github.com/feast-dev/feast/pull/6806/checks
Files changed https://github.com/feast-dev/feast/pull/6806/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6806/files
fix: Preserve entity row order in precomputed reads https://github.com/feast-dev/feast/pull/6806/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6806/files
36488e2 fix: Preserve entity row order in precomputed reads JodeZer Sep 1, 2026 https://github.com/feast-dev/feast/pull/6806/commits/36488e250bd3c8f9992ec54eb00313d027768d65
Clear filters https://github.com/feast-dev/feast/pull/6806/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6806/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6806/files
online_store.py https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
test_precomputed_feature_vectors.py https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L15
sdk/python/feast/infra/online_stores/online_store.pyhttps://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
View file https://github.com/JodeZer/feast/blob/36488e250bd3c8f9992ec54eb00313d027768d65/sdk/python/feast/infra/online_stores/online_store.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6806/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/pull/6806/files#diff-5ca0c4f03c06d0555b1abff748ac19b61836cacade81c5c670df9cb2704b4021
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_precomputed_feature_vectors.pyhttps://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
View file https://github.com/JodeZer/feast/blob/36488e250bd3c8f9992ec54eb00313d027768d65/sdk/python/tests/unit/test_precomputed_feature_vectors.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6806/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com/feast-dev/feast/pull/6806/files#diff-882b9b6e6624e54f25aebd53b8d60aa2dcda8fc66012bfdd8b9ba7007546b770
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.