René's URL Explorer Experiment


Title: fix: Preserve distinct entity_df rows sharing a join key and timestamp in Dask offline store by piyush182004 · Pull Request #6786 · feast-dev/feast · GitHub

Open Graph Title: fix: Preserve distinct entity_df rows sharing a join key and timestamp in Dask offline store by piyush182004 · Pull Request #6786 · feast-dev/feast

X Title: fix: Preserve distinct entity_df rows sharing a join key and timestamp in Dask offline store by piyush182004 · Pull Request #6786 · feast-dev/feast

Description: ISSUE:- #6787 What this PR does / why we need it: get_historical_features() on the Dask/File offline store returned fewer rows than were passed in whenever the entity_df contained two or more rows that shared a join key and event timestamp but differed in other columns — for example, two orders placed by the same customer in the same logged second, each with its own order id and label. _drop_duplicates() deduplicated the joined result on (join keys, event timestamp) only. Since that pair does not uniquely identify an input row, distinct entity_df rows sharing it were collapsed into one by drop_duplicates(keep="last"), silently discarding every other column of the dropped rows — including labels a training pipeline would join on. Reproduced with a 4-row entity_df (two rows sharing a join key and timestamp): before this change, only 2 of 4 rows survived. The DuckDB offline store, and every SQL-based store (BigQuery, Snowflake, Redshift, Postgres, Spark, ClickHouse, Trino, Couchbase, Athena), already avoid this by carrying a per-row entity_row_unique_id through their generated queries; Dask/File had no equivalent. The fix tags each input row with a synthetic unique id before the per-feature-view join, dedupes on that id instead of (join keys, timestamp), and drops the id column before returning. Non-entity mode (entity_df=None, used to snapshot all entities as of a timestamp) is unaffected and covered by an existing test. Verification Full offline-store + local-feast-tests suite: 260 passed, 0 failed. Added 2 regression tests covering the collapse scenario and the exact row-count invariant. Which issue(s) this PR fixes: Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests

Open Graph Description: ISSUE:- #6787 What this PR does / why we need it: get_historical_features() on the Dask/File offline store returned fewer rows than were passed in whenever the entity_df contained two or more rows ...

X Description: ISSUE:- #6787 What this PR does / why we need it: get_historical_features() on the Dask/File offline store returned fewer rows than were passed in whenever the entity_df contained two or more rows ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6786

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a57404ff-33d9-df87-098c-9af00b42ba5d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idADF4:22FF8D:21F735:2F03A9:6AFE9565
html-safe-nonce9d630ffa467d94ced8731786f82e668bfba6b58a5fb6c122445193bb28faf19f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBREY0OjIyRkY4RDoyMUY3MzU6MkYwM0E5OjZBRkU5NTY1IiwidmlzaXRvcl9pZCI6IjMxMDE5MTc0MTk4MjA0NTUyNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6364dee8509c50b41567b33a830e5e7c3e10ce58f4d854bb2d175a5309bd143a
hovercard-subject-tagpull_request:4364155148
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6786/files
twitter:imagehttps://avatars.githubusercontent.com/u/146834305?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/146834305?s=400&v=4
og:image:altISSUE:- #6787 What this PR does / why we need it: get_historical_features() on the Dask/File offline store returned fewer rows than were passed in whenever the entity_df contained two or more rows ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6786/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6786%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6786%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6786/files
Reloadhttps://github.com/feast-dev/feast/pull/6786/files
Reloadhttps://github.com/feast-dev/feast/pull/6786/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
piyush182004https://github.com/piyush182004
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
piyush182004:fix/dask-entity-row-collapsehttps://github.com/piyush182004/feast/tree/fix/dask-entity-row-collapse
Conversation 3 https://github.com/feast-dev/feast/pull/6786
Commits 1 https://github.com/feast-dev/feast/pull/6786/commits
Checks 37 https://github.com/feast-dev/feast/pull/6786/checks
Files changed https://github.com/feast-dev/feast/pull/6786/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786/files
fix: Preserve distinct entity_df rows sharing a join key and timestamp in Dask offline store https://github.com/feast-dev/feast/pull/6786/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6786/files
02938bb fix: Preserve distinct entity_df rows sharing a join key and timestam… piyush182004 Aug 26, 2026 https://github.com/feast-dev/feast/pull/6786/commits/02938bb46cda947e21b8ba416ced195788409bce
Clear filters https://github.com/feast-dev/feast/pull/6786/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786/files
dask.py https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
test_dask_entity_row_dedup.py https://github.com/feast-dev/feast/pull/6786/files#diff-654b9e5aa319d20c405d86d662e41133355ecf2bb1095020b945469b0e4239fd
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/dask.pyhttps://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
View file https://github.com/feast-dev/feast/blob/02938bb46cda947e21b8ba416ced195788409bce/sdk/python/feast/infra/offline_stores/dask.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6786/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/pull/6786/files#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/offline_stores/test_dask_entity_row_dedup.pyhttps://github.com/feast-dev/feast/pull/6786/files#diff-654b9e5aa319d20c405d86d662e41133355ecf2bb1095020b945469b0e4239fd
View file https://github.com/feast-dev/feast/blob/02938bb46cda947e21b8ba416ced195788409bce/sdk/python/tests/unit/infra/offline_stores/test_dask_entity_row_dedup.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6786/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.