René's URL Explorer Experiment


Title: fix: Preserve distinct entity_df rows sharing a join key and timestamp in Dask offline store by piyush182004 · Pull Request #6786 · feast-dev/feast · GitHub

Open Graph Title: fix: Preserve distinct entity_df rows sharing a join key and timestamp in Dask offline store by piyush182004 · Pull Request #6786 · feast-dev/feast

X Title: fix: Preserve distinct entity_df rows sharing a join key and timestamp in Dask offline store by piyush182004 · Pull Request #6786 · feast-dev/feast

Description: The Open Source Feature Store for AI/ML. Contribute to feast-dev/feast development by creating an account on GitHub.

Open Graph Description: ISSUE:- #6787 What this PR does / why we need it: get_historical_features() on the Dask/File offline store returned fewer rows than were passed in whenever the entity_df contained two or more rows ...

X Description: ISSUE:- #6787 What this PR does / why we need it: get_historical_features() on the Dask/File offline store returned fewer rows than were passed in whenever the entity_df contained two or more rows ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6786

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3ae7cc83-9f60-60c8-fd2b-c67734d3ab79
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCCD2:312218:D39084:11706F8:6AFE920E
html-safe-noncec21c2b6022670a88cbc96ebaaedf43b6027b71ded11674af0418328c0a2fe170
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0QyOjMxMjIxODpEMzkwODQ6MTE3MDZGODo2QUZFOTIwRSIsInZpc2l0b3JfaWQiOiIxMDMwMzIyMDM0MzA0NzgyODYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac5bd00e7f3872187867af335ba1ebfdbded337fb4c643a634b981d4a4ee39b103
hovercard-subject-tagpull_request:4364155148
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/6786/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c84f09fcd00c6056214ae82f9628dd8dbb870165961ad4a9f0b0452a4e34d0df/feast-dev/feast/pull/6786
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c84f09fcd00c6056214ae82f9628dd8dbb870165961ad4a9f0b0452a4e34d0df/feast-dev/feast/pull/6786
og:image:altISSUE:- #6787 What this PR does / why we need it: get_historical_features() on the Dask/File offline store returned fewer rows than were passed in whenever the entity_df contained two or more rows ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepiyush182004
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6786#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6786
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6786
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6786
Reloadhttps://github.com/feast-dev/feast/pull/6786
Reloadhttps://github.com/feast-dev/feast/pull/6786
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
piyush182004https://github.com/piyush182004
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
piyush182004:fix/dask-entity-row-collapsehttps://github.com/piyush182004/feast/tree/fix/dask-entity-row-collapse
Conversationhttps://github.com/feast-dev/feast/pull/6786
Commits1 (1)https://github.com/feast-dev/feast/pull/6786/commits
Checkshttps://github.com/feast-dev/feast/pull/6786/checks
Files changedhttps://github.com/feast-dev/feast/pull/6786/files
fix: Preserve distinct entity_df rows sharing a join key and timestamp in Dask offline storehttps://github.com/feast-dev/feast/pull/6786#top
piyush182004https://github.com/piyush182004
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
piyush182004:fix/dask-entity-row-collapsehttps://github.com/piyush182004/feast/tree/fix/dask-entity-row-collapse
https://github.com/piyush182004
piyush182004https://github.com/piyush182004
Aug 26, 2026https://github.com/feast-dev/feast/pull/6786#issue-5253569845
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786
#6787https://github.com/feast-dev/feast/issues/6787
conventional commitshttps://www.conventionalcommits.org/
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786
https://github.com/piyush182004
fix: Preserve distinct entity_df rows sharing a join key and timestam…https://github.com/feast-dev/feast/pull/6786/commits/02938bb46cda947e21b8ba416ced195788409bce
02938bbhttps://github.com/feast-dev/feast/pull/6786/commits/02938bb46cda947e21b8ba416ced195788409bce
feast-dev#3360https://github.com/feast-dev/feast/issues/3360
https://github.com/piyush182004
piyush182004https://github.com/piyush182004
code ownerhttps://github.com/feast-dev/feast/blob/8ab92e8fcfee9924d663652c519aed4eacae63a7/CODEOWNERS#L10
August 26, 2026 05:11https://github.com/feast-dev/feast/pull/6786#event-30022395639
https://github.com/piyush182004
piyush182004https://github.com/piyush182004
Aug 26, 2026 https://github.com/feast-dev/feast/pull/6786#ref-issue-5253591736
get_historical_features (Dask/File) silently drops entity_df rows sharing a join key and timestamp #6787 https://github.com/feast-dev/feast/issues/6787
https://github.com/franciscojavierarceo
franciscojavierarceohttps://github.com/franciscojavierarceo
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Aug 26, 2026https://github.com/feast-dev/feast/pull/6786#event-30063559018
https://github.com/franciscojavierarceo
franciscojavierarceohttps://github.com/franciscojavierarceo
Copilothttps://github.com/apps/copilot-pull-request-reviewer
August 26, 2026 19:17https://github.com/feast-dev/feast/pull/6786#event-30063562359
started reviewinghttps://github.com/feast-dev/feast/sessions/93a6f9f4-3cf8-42a2-9621-18a2ef2ee675
franciscojavierarceohttps://github.com/franciscojavierarceo
August 26, 2026 19:20https://github.com/feast-dev/feast/pull/6786#event-30063677633
View session https://github.com/feast-dev/feast/sessions/93a6f9f4-3cf8-42a2-9621-18a2ef2ee675
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Aug 26, 2026 https://github.com/feast-dev/feast/pull/6786#pullrequestreview-5034277526
View reviewed changes https://github.com/feast-dev/feast/pull/6786/files/02938bb46cda947e21b8ba416ced195788409bce
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/feast-dev/feast/pull/6786#pullrequestreview-5034277526
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Add a code-review agent skillhttps://github.com/feast-dev/feast/new/master?filename=.github/skills/code-review/SKILL.md
Learn more in the docs.https://docs.github.com/en/copilot/how-tos/use-copilot-agents/request-a-code-review/use-code-review#mcp-servers-and-agent-skills
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786
sdk/python/feast/infra/offline_stores/dask.pyhttps://github.com/feast-dev/feast/pull/6786/files/02938bb46cda947e21b8ba416ced195788409bce#diff-3de9c84e29516229969edd4207d459ab105da1919b3cd1869a6289c316b5575e
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Aug 26, 2026https://github.com/feast-dev/feast/pull/6786#issuecomment-5430045269
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUwNjg3MzEsIm5iZiI6MTc5NTA2ODQzMSwicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMTE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTExOVQwNjA3MTFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04NmYwMGY3MGYwMWM4MGVlODZkOWYxN2ZiMDVkNTM1NTYzNzc4ZmU2NzIyZmM3MjM0OThlODM2Mzc5MjYwZDBlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.ZlNXmk_9gUW2iSKhaV3DJ1Vh-SFnH0Ez45QYuEewris
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6786?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
8ab92e8https://app.codecov.io/gh/feast-dev/feast/commit/8ab92e8fcfee9924d663652c519aed4eacae63a7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
02938bbhttps://app.codecov.io/gh/feast-dev/feast/commit/02938bb46cda947e21b8ba416ced195788409bce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/feast-dev/feast/pull/6786?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Flaghttps://app.codecov.io/gh/feast-dev/feast/pull/6786/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
go-feature-serverhttps://app.codecov.io/gh/feast-dev/feast/pull/6786/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
python-unithttps://app.codecov.io/gh/feast-dev/feast/pull/6786/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Files with missing lineshttps://app.codecov.io/gh/feast-dev/feast/pull/6786?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
sdk/python/feast/infra/offline_stores/dask.pyhttps://app.codecov.io/gh/feast-dev/feast/pull/6786?src=pr&el=tree&filepath=sdk%2Fpython%2Ffeast%2Finfra%2Foffline_stores%2Fdask.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9vZmZsaW5lX3N0b3Jlcy9kYXNrLnB5
Continue to review full report in Codecov by Harnesshttps://app.codecov.io/gh/feast-dev/feast/pull/6786?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6786?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
8ab92e8...02938bbhttps://app.codecov.io/gh/feast-dev/feast/pull/6786?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786
https://github.com/iammanoj807
iammanoj807https://github.com/iammanoj807
Nov 18, 2026 https://github.com/feast-dev/feast/pull/6786#ref-pullrequest-6462263702
fix: Keep the source event timestamp separate from request data in Dask retrieval #7177 https://github.com/feast-dev/feast/pull/7177
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6786
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/feast-dev/feast/pull/6786/files/02938bb46cda947e21b8ba416ced195788409bce
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Please reload this pagehttps://github.com/feast-dev/feast/pull/6786
https://github.com/piyush182004
https://github.com/codecov-commenter
https://github.com/apps/copilot-pull-request-reviewer
https://github.com/franciscojavierarceo
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.