René's URL Explorer Experiment


Title: feat: Add quality monitoring features for Trino offline store by Marcus-Rosti · Pull Request #6779 · feast-dev/feast · GitHub

Open Graph Title: feat: Add quality monitoring features for Trino offline store by Marcus-Rosti · Pull Request #6779 · feast-dev/feast

X Title: feat: Add quality monitoring features for Trino offline store by Marcus-Rosti · Pull Request #6779 · feast-dev/feast

Description: What this PR does / why we need it: Trino is missing the required endpoints for monitoring data quality... here I believe I've added most of them. I based it on the spark implementation. My familiarity with spark is pretty high -- trino less so. Which issue(s) this PR fixes: None? Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change Misc I mainly copy and pasted the implementation from spark and then Gemini and I had a bit of fun refactoring that. I leveraged gemini pretty heavily to generate unit tests which I think are fairly exhaustive but I don't know y'all's vibes on that one. oh the auth: Optional[...] = None is fix to another issue where excluding an auth implementation results in a pydantic error -- I just included that here selfishly

Open Graph Description: What this PR does / why we need it: Trino is missing the required endpoints for monitoring data quality... here I believe I've added most of them. I based it on the spark implementation. My fa...

X Description: What this PR does / why we need it: Trino is missing the required endpoints for monitoring data quality... here I believe I've added most of them. I based it on the spark implementation. M...

Opengraph URL: https://github.com/feast-dev/feast/pull/6779

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8f5a30e5-8e3c-1bed-3668-b069240c8fd5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9286:3CBC2:F25531:13E6C93:6AFE9878
html-safe-nonce57f6689f03f5abeac5064f7b978ebbf6206bc3dad4b09b4da6667c67e4cc49f8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5Mjg2OjNDQkMyOkYyNTUzMToxM0U2QzkzOjZBRkU5ODc4IiwidmlzaXRvcl9pZCI6Ijg1Njg5OTkzNDY5NDEzNjg0NDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1f2e1d27cf8fa3953e58c4166888f1c238291882c23ec67c3ee5cbd61a29343a
hovercard-subject-tagpull_request:4353392081
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6779/files
twitter:imagehttps://avatars.githubusercontent.com/u/8094255?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8094255?s=400&v=4
og:image:altWhat this PR does / why we need it: Trino is missing the required endpoints for monitoring data quality... here I believe I've added most of them. I based it on the spark implementation. My fa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6779/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6779%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6779%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6779/files
Reloadhttps://github.com/feast-dev/feast/pull/6779/files
Reloadhttps://github.com/feast-dev/feast/pull/6779/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Marcus-Rosti:mrosti/trino-monitoringhttps://github.com/Marcus-Rosti/feast/tree/mrosti/trino-monitoring
Conversation 13 https://github.com/feast-dev/feast/pull/6779
Commits 8 https://github.com/feast-dev/feast/pull/6779/commits
Checks 23 https://github.com/feast-dev/feast/pull/6779/checks
Files changed https://github.com/feast-dev/feast/pull/6779/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6779/files
feat: Add quality monitoring features for Trino offline store https://github.com/feast-dev/feast/pull/6779/files#top
Show all changes 8 commits https://github.com/feast-dev/feast/pull/6779/files
83bade6 feat: Add quality monitoring features for Trino offline store Marcus-Rosti Aug 25, 2026 https://github.com/feast-dev/feast/pull/6779/commits/83bade60cc60e1c208da32f5f8eb97b2593cee6c
5f1871e fix: Query structure and null counts Marcus-Rosti Sep 17, 2026 https://github.com/feast-dev/feast/pull/6779/commits/5f1871e5d7633fbcb30dd4f5c0a97a2d40c0ba7c
8ee0a3d fix: Infers null syntax from pandas Marcus-Rosti Sep 17, 2026 https://github.com/feast-dev/feast/pull/6779/commits/8ee0a3d58530ac93d7e287d356195348ed1b31a5
07e2c22 fix: Guard _is_nan against container types in upload formatting Marcus-Rosti Sep 17, 2026 https://github.com/feast-dev/feast/pull/6779/commits/07e2c227d6062dc405a61ba6ed69894b25fd6cb0
af4f169 fix: Implement rename-swap pattern for Trino monitoring tables Marcus-Rosti Sep 17, 2026 https://github.com/feast-dev/feast/pull/6779/commits/af4f169369f4e66be895d327bdbf7b0ccd854205
fc7d942 fix: Use append-only writes for Trino monitoring metrics Marcus-Rosti Sep 17, 2026 https://github.com/feast-dev/feast/pull/6779/commits/fc7d9421da5bf88b3a80824f5801b3b7c5f72be5
06f73d9 fix: Narrow exception handling and add debug logging in Trino monitoring Marcus-Rosti Sep 17, 2026 https://github.com/feast-dev/feast/pull/6779/commits/06f73d9ee472d3690a7211287b54703ad396e0f5
dc6fec5 fix: Convert tz-aware datetimes to UTC in Trino SQL literal formatting Marcus-Rosti Sep 17, 2026 https://github.com/feast-dev/feast/pull/6779/commits/dc6fec5e3dc149d00956097089800bd6481ba49c
Clear filters https://github.com/feast-dev/feast/pull/6779/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6779/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6779/files
feature-monitoring.md https://github.com/feast-dev/feast/pull/6779/files#diff-db6440a84a17d95b10a050c62dbceb35d5fb5950a65b38797fb44d219c102b97
spark.py https://github.com/feast-dev/feast/pull/6779/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
upload.py https://github.com/feast-dev/feast/pull/6779/files#diff-ca78d14f2f22d56450d3ade99c716fd4992f3cab6ff1db80ade45f704efa526a
test_trino_monitoring.py https://github.com/feast-dev/feast/pull/6779/files#diff-beac26ca51f3d14a5a2f8aff075bb6c1b5a307534ef89209672683371088da4a
trino.py https://github.com/feast-dev/feast/pull/6779/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
test_compute_correctness.py https://github.com/feast-dev/feast/pull/6779/files#diff-e17a0712b9a28345df93d4e1562b9065d53323677412da1d67cfc3b8a0cb5aa1
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/how-to-guides/feature-monitoring.mdhttps://github.com/feast-dev/feast/pull/6779/files#diff-db6440a84a17d95b10a050c62dbceb35d5fb5950a65b38797fb44d219c102b97
View file https://github.com/Marcus-Rosti/feast/blob/dc6fec5e3dc149d00956097089800bd6481ba49c/docs/how-to-guides/feature-monitoring.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6779/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6779/files#diff-db6440a84a17d95b10a050c62dbceb35d5fb5950a65b38797fb44d219c102b97
https://github.com/feast-dev/feast/pull/6779/files#diff-db6440a84a17d95b10a050c62dbceb35d5fb5950a65b38797fb44d219c102b97
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.pyhttps://github.com/feast-dev/feast/pull/6779/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
View file https://github.com/Marcus-Rosti/feast/blob/dc6fec5e3dc149d00956097089800bd6481ba49c/sdk/python/feast/infra/offline_stores/contrib/spark_offline_store/spark.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6779/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6779/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/pull/6779/files#diff-ef3fce408c702d00aa891015376e83ff1084907c69c95cafacf5fae657fca486
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/connectors/upload.pyhttps://github.com/feast-dev/feast/pull/6779/files#diff-ca78d14f2f22d56450d3ade99c716fd4992f3cab6ff1db80ade45f704efa526a
View file https://github.com/Marcus-Rosti/feast/blob/dc6fec5e3dc149d00956097089800bd6481ba49c/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/connectors/upload.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6779/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6779/files#diff-ca78d14f2f22d56450d3ade99c716fd4992f3cab6ff1db80ade45f704efa526a
https://github.com/feast-dev/feast/pull/6779/files#diff-ca78d14f2f22d56450d3ade99c716fd4992f3cab6ff1db80ade45f704efa526a
https://github.com/feast-dev/feast/pull/6779/files#diff-ca78d14f2f22d56450d3ade99c716fd4992f3cab6ff1db80ade45f704efa526a
https://github.com/feast-dev/feast/pull/6779/files#diff-ca78d14f2f22d56450d3ade99c716fd4992f3cab6ff1db80ade45f704efa526a
Please reload this pagehttps://github.com/feast-dev/feast/pull/6779/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6779/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.