René's URL Explorer Experiment


Title: fix: Unwrap SecretStr tokens when building Trino auth objects by AdityaPatil22 · Pull Request #6771 · feast-dev/feast · GitHub

Open Graph Title: fix: Unwrap SecretStr tokens when building Trino auth objects by AdityaPatil22 · Pull Request #6771 · feast-dev/feast

X Title: fix: Unwrap SecretStr tokens when building Trino auth objects by AdityaPatil22 · Pull Request #6771 · feast-dev/feast

Description: What this PR does / why we need it: The Trino offline store fails when using JWT authentication: TypeError: can only concatenate str (not "SecretStr") to str This happens because AuthConfig.to_trino_auth() passed model.model_dump() directly into Trino's auth classes. For JWT, the token field is a Pydantic SecretStr (to avoid leaking it in logs/reprs), but model_dump() leaves it as a SecretStr object instead of a plain string, and Trino's JWTAuthentication does "Bearer " + self.token internally, which fails on a non-str. The fix unwraps any SecretStr fields via .get_secret_value() before constructing the Trino auth object, in to_trino_auth(). This is scoped to the auth boundary only — it doesn't touch _get_trino_client(), doesn't monkey-patch the Trino library, and doesn't change the user-facing config format. Other auth types (basic, kerberos, oauth2, certificate) are unaffected since none of their models use SecretStr. Which issue(s) this PR fixes: Fixes #6760 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Added sdk/python/tests/unit/infra/offline_stores/contrib/trino_offline_store/test_trino_auth.py: test_jwt_auth_produces_plain_str_token — verifies to_trino_auth() produces a JWTAuthentication whose .token is a plain str equal to the configured token, not a SecretStr. test_oauth2_auth_unchanged — verifies OAuth2 auth is unaffected by the change. Ran the full trino_offline_store unit test suite (46 passed) plus ruff lint/format on modified files.

Open Graph Description: What this PR does / why we need it: The Trino offline store fails when using JWT authentication: TypeError: can only concatenate str (not "SecretStr") to str This happens because AuthConf...

X Description: What this PR does / why we need it: The Trino offline store fails when using JWT authentication: TypeError: can only concatenate str (not "SecretStr") to str This happens because ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6771

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e7133a4b-ca46-e4d1-2034-dcbf8fd1b208
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9866:132CCD:E57F12:13BFD84:6AFE983B
html-safe-nonceaf639fc90a3d241ee227bb1d5014db5f8f81330b04da5d2474b9dc96dbc54ee4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODY2OjEzMkNDRDpFNTdGMTI6MTNCRkQ4NDo2QUZFOTgzQiIsInZpc2l0b3JfaWQiOiI4Mjc5ODA0ODc5NDgwNzIzNTE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacab6583528fccf16d74b7bee51c91de6ccce77748ed5561c636cb56d86b11fc72
hovercard-subject-tagpull_request:4331024891
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6771/files
twitter:imagehttps://avatars.githubusercontent.com/u/121920458?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/121920458?s=400&v=4
og:image:altWhat this PR does / why we need it: The Trino offline store fails when using JWT authentication: TypeError: can only concatenate str (not "SecretStr") to str This happens because AuthConf...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6771/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6771%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6771%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6771/files
Reloadhttps://github.com/feast-dev/feast/pull/6771/files
Reloadhttps://github.com/feast-dev/feast/pull/6771/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
AdityaPatil22:fix/trino-offline-store-failureshttps://github.com/AdityaPatil22/feast/tree/fix/trino-offline-store-failures
Conversation 6 https://github.com/feast-dev/feast/pull/6771
Commits 2 https://github.com/feast-dev/feast/pull/6771/commits
Checks 23 https://github.com/feast-dev/feast/pull/6771/checks
Files changed https://github.com/feast-dev/feast/pull/6771/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6771/files
fix: Unwrap SecretStr tokens when building Trino auth objects https://github.com/feast-dev/feast/pull/6771/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6771/files
17a332c fix: Unwrap SecretStr tokens when building Trino auth objects AdityaPatil22 Aug 21, 2026 https://github.com/feast-dev/feast/pull/6771/commits/17a332c0267804af0a1a998b5deb2b19cfa023fa
af4200b test: Cover basic auth plain fields in Trino auth conversion AdityaPatil22 Aug 24, 2026 https://github.com/feast-dev/feast/pull/6771/commits/af4200ba53723e81b903cbfdea01bbf24d81dbc6
Clear filters https://github.com/feast-dev/feast/pull/6771/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6771/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6771/files
trino.py https://github.com/feast-dev/feast/pull/6771/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
test_trino_auth.py https://github.com/feast-dev/feast/pull/6771/files#diff-5cfe319e58c144d92ebcb8577661c34b3f828096f49edf975e431787b90580bf
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.pyhttps://github.com/feast-dev/feast/pull/6771/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
View file https://github.com/AdityaPatil22/feast/blob/af4200ba53723e81b903cbfdea01bbf24d81dbc6/sdk/python/feast/infra/offline_stores/contrib/trino_offline_store/trino.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6771/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6771/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/pull/6771/files#diff-6e65b50429a62b87dcf94c643d5592e6e8d59ba957792ee44447b04db4da75fe
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/offline_stores/contrib/trino_offline_store/test_trino_auth.pyhttps://github.com/feast-dev/feast/pull/6771/files#diff-5cfe319e58c144d92ebcb8577661c34b3f828096f49edf975e431787b90580bf
View file https://github.com/AdityaPatil22/feast/blob/af4200ba53723e81b903cbfdea01bbf24d81dbc6/sdk/python/tests/unit/infra/offline_stores/contrib/trino_offline_store/test_trino_auth.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6771/{{ revealButtonHref }}
aniketpaluhttps://github.com/aniketpalu
Aug 24, 2026https://github.com/feast-dev/feast/pull/6771/files#r3841678455
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6771/files
AdityaPatil22https://github.com/AdityaPatil22
Aug 24, 2026https://github.com/feast-dev/feast/pull/6771/files#r3842096622
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6771/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6771/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.