René's URL Explorer Experiment


Title: fix: Resolve kserve with pip --dry-run instead of installing it by larrysingleton007 · Pull Request #6733 · feast-dev/feast · GitHub

Open Graph Title: fix: Resolve kserve with pip --dry-run instead of installing it by larrysingleton007 · Pull Request #6733 · feast-dev/feast

X Title: fix: Resolve kserve with pip --dry-run instead of installing it by larrysingleton007 · Pull Request #6733 · feast-dev/feast

Description: What this PR does / why we need it test_install_kserve_with_feast installs kserve into the interpreter running the unit suite, with no isolation and no cleanup, so it mutates the environment every other test is using. Feast pins psutil==5.9.0 and kserve 0.15.2 requires psutil<6.0.0,>=5.9.6, so pip cannot leave the installed version in place — it uninstalls psutil, then installs 5.9.8: Attempting uninstall: psutil Found existing installation: psutil 5.9.0 Uninstalling psutil-5.9.0: Successfully uninstalled psutil-5.9.0 Installing collected packages: … psutil … make test-python-unit runs pytest -n 8, so eight workers share one environment. Any test importing psutil during that window fails, including every test that shells out to the CLI, since feast/metrics.py imports it at module scope. That is how an unrelated docs PR picked up a red unit-test-python (3.12, ubuntu-latest) on test_3rd_party_providers with ModuleNotFoundError: No module named 'psutil'. Because it depends on worker timing, a re-run usually passes and it reads as flake. kserve also pulls protobuf down to 4.25.x, which leaves the environment broken for the next run: the installed grpcio-health-checking ships protobuf 6.x generated code importing google.protobuf.runtime_version. The first run passes, because collection imports precede the mid-run install; the second fails at collection. --dry-run performs the same resolution and still exits non-zero when the versions cannot be satisfied together, which is what the test guards against, without installing anything. This also replaces the conflict assertion, which was inverted: conflict_occured = "dependency conflicts" in err and "ERROR" not in err That is only true when pip reports conflicts without an error, so a run failing loudly set it to False. The exit_code == 0 assertion was already doing the real work; it now carries pip's output for diagnosis. Which issue(s) this PR fixes Closes #6732 Misc Verified both directions, so the detection is unchanged rather than merely quieter: clean resolution exits 0, performs the full resolve (Would install … psutil-5.9.8 …), and leaves psutil at 5.9.0 with kserve not importable afterwards pip install --dry-run kserve==0.15.2 psutil==5.9.0 exits 1 with Cannot install kserve==0.15.2 and psutil==5.9.0 because these package versions have conflicting dependencies The full unit suite now passes twice in a row — 2529 passed, 20 skipped both times, with psutil still 5.9.0 and protobuf still 6.33.6 after the first. Previously the second run produced 31 failures and 8 collection errors. The test also drops from about 13s to under 2s. This needs a kind/ label, which I cannot add as an outside contributor.

Open Graph Description: What this PR does / why we need it test_install_kserve_with_feast installs kserve into the interpreter running the unit suite, with no isolation and no cleanup, so it mutates the environment every ...

X Description: What this PR does / why we need it test_install_kserve_with_feast installs kserve into the interpreter running the unit suite, with no isolation and no cleanup, so it mutates the environment every ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6733

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:17a33a78-65c2-b9fd-33dd-0aba32998dd0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85E6:1C8D80:458CA2:5CADEA:6AFEA26B
html-safe-nonce60e2b85c1795b338b507619becba2f28db236c803d66f44fc4a348d145446b71
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUU2OjFDOEQ4MDo0NThDQTI6NUNBREVBOjZBRkVBMjZCIiwidmlzaXRvcl9pZCI6IjY4MzY3MDE3OTUwNzk1OTQ2MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb986d6efbbd9f37ea8fc4177a4a49092bdd9c671c35b9e93ee34781e532acf77
hovercard-subject-tagpull_request:4266942083
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6733/files
twitter:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
og:image:altWhat this PR does / why we need it test_install_kserve_with_feast installs kserve into the interpreter running the unit suite, with no isolation and no cleanup, so it mutates the environment every ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6733/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6733%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6733%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6733/files
Reloadhttps://github.com/feast-dev/feast/pull/6733/files
Reloadhttps://github.com/feast-dev/feast/pull/6733/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:fix/kserve-test-isolationhttps://github.com/larrysingleton007/feast/tree/fix/kserve-test-isolation
Conversation 2 https://github.com/feast-dev/feast/pull/6733
Commits 1 https://github.com/feast-dev/feast/pull/6733/commits
Checks 23 https://github.com/feast-dev/feast/pull/6733/checks
Files changed https://github.com/feast-dev/feast/pull/6733/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6733/files
fix: Resolve kserve with pip --dry-run instead of installing it https://github.com/feast-dev/feast/pull/6733/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6733/files
33a8e47 fix: Resolve kserve with pip --dry-run instead of installing it larrysingleton007 Aug 13, 2026 https://github.com/feast-dev/feast/pull/6733/commits/33a8e47c2c45a363915f50063c72b59ed0421c38
Clear filters https://github.com/feast-dev/feast/pull/6733/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6733/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6733/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/test_dependency_conflicts.pyhttps://github.com/feast-dev/feast/pull/6733/files#diff-3add63b6b9730120c755b76d8789b3123b3df0b6c826e529cfb7c1723ea33753
View file https://github.com/larrysingleton007/feast/blob/33a8e47c2c45a363915f50063c72b59ed0421c38/sdk/python/tests/unit/infra/test_dependency_conflicts.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6733/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6733/files#diff-3add63b6b9730120c755b76d8789b3123b3df0b6c826e529cfb7c1723ea33753
https://github.com/feast-dev/feast/pull/6733/files#diff-3add63b6b9730120c755b76d8789b3123b3df0b6c826e529cfb7c1723ea33753
Please reload this pagehttps://github.com/feast-dev/feast/pull/6733/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.