Title: fix: Resolve kserve with pip --dry-run instead of installing it by larrysingleton007 · Pull Request #6733 · feast-dev/feast · GitHub
Open Graph Title: fix: Resolve kserve with pip --dry-run instead of installing it by larrysingleton007 · Pull Request #6733 · feast-dev/feast
X Title: fix: Resolve kserve with pip --dry-run instead of installing it by larrysingleton007 · Pull Request #6733 · feast-dev/feast
Description: What this PR does / why we need it test_install_kserve_with_feast installs kserve into the interpreter running the unit suite, with no isolation and no cleanup, so it mutates the environment every other test is using. Feast pins psutil==5.9.0 and kserve 0.15.2 requires psutil<6.0.0,>=5.9.6, so pip cannot leave the installed version in place — it uninstalls psutil, then installs 5.9.8: Attempting uninstall: psutil Found existing installation: psutil 5.9.0 Uninstalling psutil-5.9.0: Successfully uninstalled psutil-5.9.0 Installing collected packages: … psutil … make test-python-unit runs pytest -n 8, so eight workers share one environment. Any test importing psutil during that window fails, including every test that shells out to the CLI, since feast/metrics.py imports it at module scope. That is how an unrelated docs PR picked up a red unit-test-python (3.12, ubuntu-latest) on test_3rd_party_providers with ModuleNotFoundError: No module named 'psutil'. Because it depends on worker timing, a re-run usually passes and it reads as flake. kserve also pulls protobuf down to 4.25.x, which leaves the environment broken for the next run: the installed grpcio-health-checking ships protobuf 6.x generated code importing google.protobuf.runtime_version. The first run passes, because collection imports precede the mid-run install; the second fails at collection. --dry-run performs the same resolution and still exits non-zero when the versions cannot be satisfied together, which is what the test guards against, without installing anything. This also replaces the conflict assertion, which was inverted: conflict_occured = "dependency conflicts" in err and "ERROR" not in err That is only true when pip reports conflicts without an error, so a run failing loudly set it to False. The exit_code == 0 assertion was already doing the real work; it now carries pip's output for diagnosis. Which issue(s) this PR fixes Closes #6732 Misc Verified both directions, so the detection is unchanged rather than merely quieter: clean resolution exits 0, performs the full resolve (Would install … psutil-5.9.8 …), and leaves psutil at 5.9.0 with kserve not importable afterwards pip install --dry-run kserve==0.15.2 psutil==5.9.0 exits 1 with Cannot install kserve==0.15.2 and psutil==5.9.0 because these package versions have conflicting dependencies The full unit suite now passes twice in a row — 2529 passed, 20 skipped both times, with psutil still 5.9.0 and protobuf still 6.33.6 after the first. Previously the second run produced 31 failures and 8 collection errors. The test also drops from about 13s to under 2s. This needs a kind/ label, which I cannot add as an outside contributor.
Open Graph Description: What this PR does / why we need it test_install_kserve_with_feast installs kserve into the interpreter running the unit suite, with no isolation and no cleanup, so it mutates the environment every ...
X Description: What this PR does / why we need it test_install_kserve_with_feast installs kserve into the interpreter running the unit suite, with no isolation and no cleanup, so it mutates the environment every ...
Opengraph URL: https://github.com/feast-dev/feast/pull/6733
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:17a33a78-65c2-b9fd-33dd-0aba32998dd0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 85E6:1C8D80:458CA2:5CADEA:6AFEA26B |
| html-safe-nonce | 60e2b85c1795b338b507619becba2f28db236c803d66f44fc4a348d145446b71 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUU2OjFDOEQ4MDo0NThDQTI6NUNBREVBOjZBRkVBMjZCIiwidmlzaXRvcl9pZCI6IjY4MzY3MDE3OTUwNzk1OTQ2MDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b986d6efbbd9f37ea8fc4177a4a49092bdd9c671c35b9e93ee34781e532acf77 |
| hovercard-subject-tag | pull_request:4266942083 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6733/files |
| twitter:image | https://avatars.githubusercontent.com/u/166439969?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/166439969?s=400&v=4 |
| og:image:alt | What this PR does / why we need it test_install_kserve_with_feast installs kserve into the interpreter running the unit suite, with no isolation and no cleanup, so it mutates the environment every ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3f25273206cd841171bca0002261ae4c9757d934 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width