René's URL Explorer Experiment


Title: fix: Fix mypy TorchTensor type alias error by nithin42 · Pull Request #6712 · feast-dev/feast · GitHub

Open Graph Title: fix: Fix mypy TorchTensor type alias error by nithin42 · Pull Request #6712 · feast-dev/feast

X Title: fix: Fix mypy TorchTensor type alias error by nithin42 · Pull Request #6712 · feast-dev/feast

Description: What this PR does / why we need it In online_response.py, TorchTensor is defined using TypeAlias inside both conditional branches of if TYPE_CHECKING:. Mypy complains: Variable "feast.online_response.TorchTensor" is not valid as a type because it parses it as a variable inside the runtime fallback branch. This PR fixes the typing syntax in online_response.py by defining TorchTensor cleanly without TypeAlias in the fallback branch so mypy parses the type correctly. Which issue(s) this PR fixes Fixes #5563 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format

Open Graph Description: What this PR does / why we need it In online_response.py, TorchTensor is defined using TypeAlias inside both conditional branches of if TYPE_CHECKING:. Mypy complains: Variable "feast.online_r...

X Description: What this PR does / why we need it In online_response.py, TorchTensor is defined using TypeAlias inside both conditional branches of if TYPE_CHECKING:. Mypy complains: Variable "feast.onli...

Opengraph URL: https://github.com/feast-dev/feast/pull/6712

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:19faa49c-a6af-bdc2-eccf-ca3fbc7d8a3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDD2:15833F:2F9B7F:425BFC:6AFE99C7
html-safe-noncee08ee39c0caf8bfcb58440de672ce2778157e396dfde4ea2a02f923a8c00f0d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREQyOjE1ODMzRjoyRjlCN0Y6NDI1QkZDOjZBRkU5OUM3IiwidmlzaXRvcl9pZCI6IjY2MzcyNTk5NDYzOTgyMjY4ODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace0fc2d8964f0dd5f5542cf05b90f5b4d3706d131c78592d96eb8c209baa1104d
hovercard-subject-tagpull_request:4230986487
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6712/files
twitter:imagehttps://avatars.githubusercontent.com/u/52503252?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/52503252?s=400&v=4
og:image:altWhat this PR does / why we need it In online_response.py, TorchTensor is defined using TypeAlias inside both conditional branches of if TYPE_CHECKING:. Mypy complains: Variable "feast.online_r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6712/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6712%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6712%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6712/files
Reloadhttps://github.com/feast-dev/feast/pull/6712/files
Reloadhttps://github.com/feast-dev/feast/pull/6712/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
jyejarehttps://github.com/jyejare
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
nithin42:fix/online-response-mypyhttps://github.com/nithin42/feast/tree/fix/online-response-mypy
Conversation 5 https://github.com/feast-dev/feast/pull/6712
Commits 2 https://github.com/feast-dev/feast/pull/6712/commits
Checks 23 https://github.com/feast-dev/feast/pull/6712/checks
Files changed https://github.com/feast-dev/feast/pull/6712/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6712/files
fix: Fix mypy TorchTensor type alias error https://github.com/feast-dev/feast/pull/6712/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6712/files
eeb10bc fix: Fix mypy TorchTensor type alias error nithin42 Aug 7, 2026 https://github.com/feast-dev/feast/pull/6712/commits/eeb10bc817adc3b00b5f3ea7a661c58df90d2815
a0c040f fix: remove redundant `import torch` under TYPE_CHECKING block nithin42 Aug 10, 2026 https://github.com/feast-dev/feast/pull/6712/commits/a0c040ffa6468eb0af600ef416e768a355875183
Clear filters https://github.com/feast-dev/feast/pull/6712/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6712/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6712/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/online_response.pyhttps://github.com/feast-dev/feast/pull/6712/files#diff-c0279507be8595b0cd9375cf8bc75e005ab6c229b99250305c74ac1a080bfb7d
View file https://github.com/nithin42/feast/blob/a0c040ffa6468eb0af600ef416e768a355875183/sdk/python/feast/online_response.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6712/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6712/files#diff-c0279507be8595b0cd9375cf8bc75e005ab6c229b99250305c74ac1a080bfb7d
https://github.com/feast-dev/feast/pull/6712/files#diff-c0279507be8595b0cd9375cf8bc75e005ab6c229b99250305c74ac1a080bfb7d
https://github.com/feast-dev/feast/pull/6712/files#diff-c0279507be8595b0cd9375cf8bc75e005ab6c229b99250305c74ac1a080bfb7d
Please reload this pagehttps://github.com/feast-dev/feast/pull/6712/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.