René's URL Explorer Experiment


Title: fix: Feast apply silently ignoring ttl updates to None or timedelta(0) by saket3395 · Pull Request #6709 · feast-dev/feast · GitHub

Open Graph Title: fix: Feast apply silently ignoring ttl updates to None or timedelta(0) by saket3395 · Pull Request #6709 · feast-dev/feast

X Title: fix: Feast apply silently ignoring ttl updates to None or timedelta(0) by saket3395 · Pull Request #6709 · feast-dev/feast

Description: Summary Fixes #6703 — re-applying an existing FeatureView/LabelView with ttl=None or ttl=timedelta(0) (both the documented way to express "no ttl") silently keeps the old finite ttl in the registry. feast apply reports the change on every run, but nothing actually updates. Root cause (as diagnosed in the issue): Registry._update_metadata_fields() routes ttl changes through a truthiness check: if ( hasattr(existing_proto.spec, "ttl") and hasattr(updated_fv, "ttl") and updated_fv.ttl # falsy for both None and timedelta(0) ): Since None and timedelta(0) are both falsy, the whole ttl-update block is skipped exactly when it should clear the ttl. There's a second bug in the same block that the outer-gate fix alone doesn't cover: for the FeatureView branch, get_ttl_duration() returns Python None when self.ttl is None: def get_ttl_duration(self): ttl_duration = None if self.ttl is not None: ttl_duration = Duration() ttl_duration.FromTimedelta(self.ttl) return ttl_duration and the existing inner check in _update_metadata_fields: ttl_duration = updated_fv.get_ttl_duration() if ttl_duration: existing_proto.spec.ttl.CopyFrom(ttl_duration) would still skip CopyFrom when ttl_duration is None — so removing only the outer gate fixes the timedelta(0) case but not ttl=None for FeatureView. Fix Removed the outer truthy gate; kept only the hasattr checks. For FeatureView: always CopyFrom — using an explicit empty Duration() when get_ttl_duration() returns None, instead of skipping the write. An empty Duration decodes back to timedelta(0) via FeatureView.from_proto's existing ToNanoseconds() == 0 check, so this correctly round-trips as "no ttl". For LabelView: guarded FromTimedelta() against ttl is None (previously unreachable because the outer gate prevented ttl=None from reaching this branch at all; now that the gate is gone, it needs its own guard) — falls through to the default zero Duration() in that case. Verification Traced all three cases (None, timedelta(0), a finite value) through the new branch logic in isolation (a minimal stand-in mirroring the real Duration/get_ttl_duration control flow, since protobuf isn't installed in this environment and I didn't want to add it just to verify branch logic): ttl input FeatureView branch LabelView branch None zero Duration zero Duration timedelta(0) zero Duration zero Duration timedelta(days=10) 864000s Duration 864000s Duration Both branches now resolve identically for all three cases, and confirmed via feature_view.py's from_proto that a zero-value Duration round-trips to timedelta(0), matching the codebase's existing "no ttl" convention. Test plan Traced all three ttl cases through the new logic in isolation, for both FeatureView and LabelView. Didn't run this against feast's actual test suite / a live feast apply round-trip in this environment (protobuf not installed here, didn't want to pull in the dependency just to verify this). Flagging for CI/maintainer verification — happy to iterate if anything surfaces.

Open Graph Description: Summary Fixes #6703 — re-applying an existing FeatureView/LabelView with ttl=None or ttl=timedelta(0) (both the documented way to express "no ttl") silently keeps the old finite ttl in th...

X Description: Summary Fixes #6703 — re-applying an existing FeatureView/LabelView with ttl=None or ttl=timedelta(0) (both the documented way to express "no ttl") silently keeps the old finite t...

Opengraph URL: https://github.com/feast-dev/feast/pull/6709

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:92299107-4613-6bc0-5b03-e3f55bc24f47
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id99C0:6B7A6:F16EF7:13DF4F4:6AFE9894
html-safe-noncecf33cd9c076db6e645dcdbab66da4aecf412b6ff380dc8986672bc0c88b017bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUMwOjZCN0E2OkYxNkVGNzoxM0RGNEY0OjZBRkU5ODk0IiwidmlzaXRvcl9pZCI6IjMxODczOTA1NTM2MzY1OTkyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7e40ba90c71916957ce42ab74185ab99658ab2da73f73caef396272b8cb5cdf4
hovercard-subject-tagpull_request:4218504572
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6709/files
twitter:imagehttps://avatars.githubusercontent.com/u/55333527?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/55333527?s=400&v=4
og:image:altSummary Fixes #6703 — re-applying an existing FeatureView/LabelView with ttl=None or ttl=timedelta(0) (both the documented way to express "no ttl") silently keeps the old finite ttl in th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6709/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6709%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6709%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6709/files
Reloadhttps://github.com/feast-dev/feast/pull/6709/files
Reloadhttps://github.com/feast-dev/feast/pull/6709/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
saket3395:fix/ttl-clear-falsy-guardhttps://github.com/saket3395/feast/tree/fix/ttl-clear-falsy-guard
Conversation 10 https://github.com/feast-dev/feast/pull/6709
Commits 4 https://github.com/feast-dev/feast/pull/6709/commits
Checks 1 https://github.com/feast-dev/feast/pull/6709/checks
Files changed https://github.com/feast-dev/feast/pull/6709/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6709/files
fix: Feast apply silently ignoring ttl updates to None or timedelta(0) https://github.com/feast-dev/feast/pull/6709/files#top
Show all changes 4 commits https://github.com/feast-dev/feast/pull/6709/files
73d3956 fix: feast apply ignores ttl updates when new ttl is None or timedelt… Aug 6, 2026 https://github.com/feast-dev/feast/pull/6709/commits/73d3956a6731db36be28fa91418999c0b2fea919
326215c address review nitpicks: hoist Duration import, guard FromTimedelta Aug 6, 2026 https://github.com/feast-dev/feast/pull/6709/commits/326215c90fee1c5e094635d77d5cfec9645d291d
cc340e8 test: cover ttl clearing in _update_metadata_fields (#6703) Aug 11, 2026 https://github.com/feast-dev/feast/pull/6709/commits/cc340e87b775bae24af106a74611fead18bc5c5f
b34897a style: apply ruff format to registry.py ttl block Aug 14, 2026 https://github.com/feast-dev/feast/pull/6709/commits/b34897a5cf86a3390dc203758839c1531094ec97
Clear filters https://github.com/feast-dev/feast/pull/6709/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6709/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6709/files
registry.py https://github.com/feast-dev/feast/pull/6709/files#diff-e399b315ba346413cd4c6d0ce607a4376137f9be98df9b3044a79e749a5dd12e
test_update_metadata_fields.py https://github.com/feast-dev/feast/pull/6709/files#diff-1d028b640a937cd926b7bfc93c95daa435e02a9445f8e9f007e511d00794bdf4
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/registry/registry.pyhttps://github.com/feast-dev/feast/pull/6709/files#diff-e399b315ba346413cd4c6d0ce607a4376137f9be98df9b3044a79e749a5dd12e
View file https://github.com/saket3395/feast/blob/b34897a5cf86a3390dc203758839c1531094ec97/sdk/python/feast/infra/registry/registry.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6709/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6709/files#diff-e399b315ba346413cd4c6d0ce607a4376137f9be98df9b3044a79e749a5dd12e
https://github.com/feast-dev/feast/pull/6709/files#diff-e399b315ba346413cd4c6d0ce607a4376137f9be98df9b3044a79e749a5dd12e
https://github.com/feast-dev/feast/pull/6709/files#diff-e399b315ba346413cd4c6d0ce607a4376137f9be98df9b3044a79e749a5dd12e
jyejarehttps://github.com/jyejare
Aug 6, 2026https://github.com/feast-dev/feast/pull/6709/files#r3729996404
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6709/files
https://github.com/feast-dev/feast/pull/6709/files#diff-e399b315ba346413cd4c6d0ce607a4376137f9be98df9b3044a79e749a5dd12e
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/registry/test_update_metadata_fields.pyhttps://github.com/feast-dev/feast/pull/6709/files#diff-1d028b640a937cd926b7bfc93c95daa435e02a9445f8e9f007e511d00794bdf4
View file https://github.com/saket3395/feast/blob/b34897a5cf86a3390dc203758839c1531094ec97/sdk/python/tests/unit/infra/registry/test_update_metadata_fields.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6709/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.