René's URL Explorer Experiment


Title: fix: Report single-feature-view spark_application materialization success by adarshsm · Pull Request #6700 · feast-dev/feast · GitHub

Open Graph Title: fix: Report single-feature-view spark_application materialization success by adarshsm · Pull Request #6700 · feast-dev/feast

X Title: fix: Report single-feature-view spark_application materialization success by adarshsm · Pull Request #6700 · feast-dev/feast

Description: What this does Fixes #6673. Every single-feature-view materialization on the spark_application batch engine is reported as a failure: Exception: SparkApplication feast-sa- not found even though the Spark driver already materialized the features and updated the registry. Automation calling feast materialize or the feature server's /materialize endpoint sees a failure and may retry work that already succeeded. It is deterministic for exactly one feature view. Root cause materialize() deletes the SparkApplication CR in its finally immediately after _build_per_fv_jobs() returns: try: self._wait_for_completion(job) return self._build_per_fv_jobs(registry, tasks, job_id, job) finally: self._cleanup(job_id) # deletes the CR For a single feature view, _build_per_fv_jobs() short-circuited and returned the live polling job: if len(tasks) <= 1: return [job for _ in tasks] FeatureStore._submit_and_process_materialization_jobs() then re-checks job.status(). On success the job has no captured error, so status() re-queries the CR that _cleanup() just deleted → 404 → _error set → ERROR raised. (On genuine failure job._error is already set and status() short-circuits, so only the success path 404s.) Fix Resolve the per-FV outcome from registry state for every task count — exactly what the multi-FV path already does. The driver pod sets each materialized FV to AVAILABLE_ONLINE, so: materialized FV → CompletedMaterializationJob, which reports SUCCEEDED with no Kubernetes call and is safe after cleanup; unmaterialized FV → ERROR (was not materialized …), consistent with the existing multi-FV behavior; the Spark driver's error detail is already logged by _wait_for_completion. The now-unused job parameter to _build_per_fv_jobs() is dropped. Tests The existing single-task test asserted the buggy behavior (return the live job, skip the registry). Rewrote it to require resolution from registry state with no CR query, and added a single-failed-FV case. All spark_application unit tests pass; the fix is exercised entirely with mocked K8s/registry — no live cluster needed. Verified the before/after on the real classes: a live job re-checked after CR deletion returns ERROR "… not found" (the reported symptom), while the fixed single-FV path returns SUCCEEDED and makes no get_namespaced_custom_object call.

Open Graph Description: What this does Fixes #6673. Every single-feature-view materialization on the spark_application batch engine is reported as a failure: Exception: SparkApplication feast-sa-<job-id> not found ...

X Description: What this does Fixes #6673. Every single-feature-view materialization on the spark_application batch engine is reported as a failure: Exception: SparkApplication feast-sa-&lt;job-id&gt; not...

Opengraph URL: https://github.com/feast-dev/feast/pull/6700

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8784ea5e-75ac-b503-5570-3164c87b5209
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id85F6:320C6A:4E0F8D:68C9AB:6AFEA26F
html-safe-nonce196bc5156648536c8e8b34750755df10b999be8ecc20802410f36554b1448f28
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUY2OjMyMEM2QTo0RTBGOEQ6NjhDOUFCOjZBRkVBMjZGIiwidmlzaXRvcl9pZCI6Ijc0NjQ1NjA5NDUwMDAyNjAyMDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4e800e26bd684978e5d0ec3e92159dec8638d0961e5428e9ebe51946f2e65380
hovercard-subject-tagpull_request:4193338387
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6700/files
twitter:imagehttps://avatars.githubusercontent.com/u/24850536?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/24850536?s=400&v=4
og:image:altWhat this does Fixes #6673. Every single-feature-view materialization on the spark_application batch engine is reported as a failure: Exception: SparkApplication feast-sa-<job-id> not found ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None95b2753c978240785d6cca00783c00a371b2d7d9879bb32e305170a1b19bd28e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3f25273206cd841171bca0002261ae4c9757d934
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6700/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6700%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6700%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6700/files
Reloadhttps://github.com/feast-dev/feast/pull/6700/files
Reloadhttps://github.com/feast-dev/feast/pull/6700/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
adarshsm:fix/spark-single-fv-materialization-statushttps://github.com/adarshsm/feast/tree/fix/spark-single-fv-materialization-status
Conversation 4 https://github.com/feast-dev/feast/pull/6700
Commits 1 https://github.com/feast-dev/feast/pull/6700/commits
Checks 32 https://github.com/feast-dev/feast/pull/6700/checks
Files changed https://github.com/feast-dev/feast/pull/6700/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6700/files
fix: Report single-feature-view spark_application materialization success https://github.com/feast-dev/feast/pull/6700/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6700/files
abf7dc5 fix: Report single-feature-view spark_application materialization suc… Aug 3, 2026 https://github.com/feast-dev/feast/pull/6700/commits/abf7dc5162cbf6bb51fa5ba7e9bdad51b3b55328
Clear filters https://github.com/feast-dev/feast/pull/6700/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6700/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6700/files
compute.py https://github.com/feast-dev/feast/pull/6700/files#diff-0c005f921289d42567f1e1bc106868b80dab3c789e4e85d1ed8ea9183e05b954
test_spark_application.py https://github.com/feast-dev/feast/pull/6700/files#diff-ada14a0db0ca01897c2df2df0965af804461c2c2241e7e42c5f257c225236131
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/compute_engines/spark_application/compute.pyhttps://github.com/feast-dev/feast/pull/6700/files#diff-0c005f921289d42567f1e1bc106868b80dab3c789e4e85d1ed8ea9183e05b954
View file https://github.com/adarshsm/feast/blob/abf7dc5162cbf6bb51fa5ba7e9bdad51b3b55328/sdk/python/feast/infra/compute_engines/spark_application/compute.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6700/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6700/files#diff-0c005f921289d42567f1e1bc106868b80dab3c789e4e85d1ed8ea9183e05b954
https://github.com/feast-dev/feast/pull/6700/files#diff-0c005f921289d42567f1e1bc106868b80dab3c789e4e85d1ed8ea9183e05b954
https://github.com/feast-dev/feast/pull/6700/files#diff-0c005f921289d42567f1e1bc106868b80dab3c789e4e85d1ed8ea9183e05b954
https://github.com/feast-dev/feast/pull/6700/files#diff-0c005f921289d42567f1e1bc106868b80dab3c789e4e85d1ed8ea9183e05b954
https://github.com/feast-dev/feast/pull/6700/files#diff-0c005f921289d42567f1e1bc106868b80dab3c789e4e85d1ed8ea9183e05b954
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/compute_engines/test_spark_application.pyhttps://github.com/feast-dev/feast/pull/6700/files#diff-ada14a0db0ca01897c2df2df0965af804461c2c2241e7e42c5f257c225236131
View file https://github.com/adarshsm/feast/blob/abf7dc5162cbf6bb51fa5ba7e9bdad51b3b55328/sdk/python/tests/unit/infra/compute_engines/test_spark_application.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6700/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6700/files#diff-ada14a0db0ca01897c2df2df0965af804461c2c2241e7e42c5f257c225236131
https://github.com/feast-dev/feast/pull/6700/files#diff-ada14a0db0ca01897c2df2df0965af804461c2c2241e7e42c5f257c225236131
https://github.com/feast-dev/feast/pull/6700/files#diff-ada14a0db0ca01897c2df2df0965af804461c2c2241e7e42c5f257c225236131
https://github.com/feast-dev/feast/pull/6700/files#diff-ada14a0db0ca01897c2df2df0965af804461c2c2241e7e42c5f257c225236131
https://github.com/feast-dev/feast/pull/6700/files#diff-ada14a0db0ca01897c2df2df0965af804461c2c2241e7e42c5f257c225236131
Please reload this pagehttps://github.com/feast-dev/feast/pull/6700/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.