René's URL Explorer Experiment


Title: docs: Correct what _validate_token claims to do by larrysingleton007 · Pull Request #6689 · feast-dev/feast · GitHub

Open Graph Title: docs: Correct what _validate_token claims to do by larrysingleton007 · Pull Request #6689 · feast-dev/feast

X Title: docs: Correct what _validate_token claims to do by larrysingleton007 · Pull Request #6689 · feast-dev/feast

Description: The Open Source Feature Store for AI/ML. Contribute to feast-dev/feast development by creating an account on GitHub.

Open Graph Description: What this PR does / why we need it OidcTokenParser._validate_token is named validate, its docstring says it validates the token against the OAuth2 server, and the caller logs "Token successful...

X Description: What this PR does / why we need it OidcTokenParser._validate_token is named validate, its docstring says it validates the token against the OAuth2 server, and the caller logs "Token succes...

Opengraph URL: https://github.com/feast-dev/feast/pull/6689

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5f5da2a6-da9a-30ac-79b9-ab8d7bdcee75
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD44:25DC2F:2F1AB7:414BD5:6AFE9994
html-safe-nonce0e83d19d181110b5b80302603d27f7304369df707bbfc1b496ee26d60716b532
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDQ0OjI1REMyRjoyRjFBQjc6NDE0QkQ1OjZBRkU5OTk0IiwidmlzaXRvcl9pZCI6IjMyMjI0ODcxNTA1MDMwNDE0MjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbc6a15b740aa4bd1adccbc2eee4971dc6394153600a056276a73cef03234436f
hovercard-subject-tagpull_request:4180433190
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/6689/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/869fb4c5ccee2f857444a9d204cbf94b3942a01f6357c82ba94a8100b4b45275/feast-dev/feast/pull/6689
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/869fb4c5ccee2f857444a9d204cbf94b3942a01f6357c82ba94a8100b4b45275/feast-dev/feast/pull/6689
og:image:altWhat this PR does / why we need it OidcTokenParser._validate_token is named validate, its docstring says it validates the token against the OAuth2 server, and the caller logs "Token successful...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelarrysingleton007
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6689#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6689
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6689
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6689
Reloadhttps://github.com/feast-dev/feast/pull/6689
Reloadhttps://github.com/feast-dev/feast/pull/6689
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:docs/oidc-validate-token-honestyhttps://github.com/larrysingleton007/feast/tree/docs/oidc-validate-token-honesty
Conversationhttps://github.com/feast-dev/feast/pull/6689
Commits2 (2)https://github.com/feast-dev/feast/pull/6689/commits
Checkshttps://github.com/feast-dev/feast/pull/6689/checks
Files changedhttps://github.com/feast-dev/feast/pull/6689/files
docs: Correct what _validate_token claims to dohttps://github.com/feast-dev/feast/pull/6689#top
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:docs/oidc-validate-token-honestyhttps://github.com/larrysingleton007/feast/tree/docs/oidc-validate-token-honesty
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
Jul 31, 2026https://github.com/feast-dev/feast/pull/6689#issue-5032801718
#6688https://github.com/feast-dev/feast/issues/6688
#6688https://github.com/feast-dev/feast/issues/6688
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
code ownerhttps://github.com/feast-dev/feast/blob/4efb86c688e7609ccdeabe2a8f827d7da11dda6c/CODEOWNERS#L10
July 31, 2026 19:37https://github.com/feast-dev/feast/pull/6689#event-28794346706
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
Jul 31, 2026 https://github.com/feast-dev/feast/pull/6689#ref-issue-5032620729
What is _validate_token meant to verify in the OIDC token parser? #6688 https://github.com/feast-dev/feast/issues/6688
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jul 31, 2026https://github.com/feast-dev/feast/pull/6689#issuecomment-5146802977
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUwNzA2NTcsIm5iZiI6MTc5NTA3MDM1NywicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMTE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTExOVQwNjM5MTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMzg1YTlhYTkyNTYwZmQ0MDc4ZWYyNGNlMDc5ZTYzNmNmYzgxOTIxMDBlZmMzOTFiMGQzMzEyMTFlMjMyNDRlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.xgYRjHPilNYeT5kwIHq5fNDD3aDDhKqtCGr3XX3BeJ4
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6689?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
01da132https://app.codecov.io/gh/feast-dev/feast/commit/01da132e609ed517983f060a89a5e24bde0f1270?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
5a80a2bhttps://app.codecov.io/gh/feast-dev/feast/commit/5a80a2b18ed32fed242f3a915be9faf02a45496f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/feast-dev/feast/pull/6689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Flaghttps://app.codecov.io/gh/feast-dev/feast/pull/6689/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
go-feature-serverhttps://app.codecov.io/gh/feast-dev/feast/pull/6689/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
python-unithttps://app.codecov.io/gh/feast-dev/feast/pull/6689/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Files with missing lineshttps://app.codecov.io/gh/feast-dev/feast/pull/6689?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
...python/feast/permissions/auth/oidc_token_parser.pyhttps://app.codecov.io/gh/feast-dev/feast/pull/6689?src=pr&el=tree&filepath=sdk%2Fpython%2Ffeast%2Fpermissions%2Fauth%2Foidc_token_parser.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9wZXJtaXNzaW9ucy9hdXRoL29pZGNfdG9rZW5fcGFyc2VyLnB5
2 files with indirect coverage changeshttps://app.codecov.io/gh/feast-dev/feast/pull/6689/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Continue to review full report in Codecov by Harnesshttps://app.codecov.io/gh/feast-dev/feast/pull/6689?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6689?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
fef4e78...5a80a2bhttps://app.codecov.io/gh/feast-dev/feast/pull/6689?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
Aug 5, 2026https://github.com/feast-dev/feast/pull/6689#issuecomment-5185947228
@ntkatholehttps://github.com/ntkathole
@franciscojavierarceohttps://github.com/franciscojavierarceo
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
Aug 5, 2026 https://github.com/feast-dev/feast/pull/6689#pullrequestreview-4861167833
View reviewed changes https://github.com/feast-dev/feast/pull/6689/files
sdk/python/feast/permissions/auth/oidc_token_parser.pyhttps://github.com/feast-dev/feast/pull/6689/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
ntkatholehttps://github.com/ntkathole
Aug 5, 2026https://github.com/feast-dev/feast/pull/6689#discussion_r3718083110
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
Aug 5, 2026https://github.com/feast-dev/feast/pull/6689#issuecomment-5191655106
@ntkatholehttps://github.com/ntkathole
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
Aug 12, 2026https://github.com/feast-dev/feast/pull/6689#issuecomment-5274159157
@ntkatholehttps://github.com/ntkathole
@franciscojavierarceohttps://github.com/franciscojavierarceo
#6713https://github.com/feast-dev/feast/pull/6713
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
larrysingleton007https://github.com/larrysingleton007
August 14, 2026 10:11https://github.com/feast-dev/feast/pull/6689#commits-pushed-c64bb4a
https://github.com/larrysingleton007
https://github.com/ntkathole
docs: Correct what _validate_token claims to dohttps://github.com/feast-dev/feast/pull/6689/commits/c64bb4a5ec50910da829f6ce65d7ee41a456cd0c
c64bb4ahttps://github.com/feast-dev/feast/pull/6689/commits/c64bb4a5ec50910da829f6ce65d7ee41a456cd0c
feast-dev#6688https://github.com/feast-dev/feast/issues/6688
https://github.com/larrysingleton007
https://github.com/ntkathole
refactor: Rename _validate_token to _check_discovery_endpointshttps://github.com/feast-dev/feast/pull/6689/commits/5a80a2b18ed32fed242f3a915be9faf02a45496f
5a80a2bhttps://github.com/feast-dev/feast/pull/6689/commits/5a80a2b18ed32fed242f3a915be9faf02a45496f
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
force-pushedhttps://github.com/feast-dev/feast/compare/8d3597be8776e36626339f2874eb31ec9eaca6dc..5a80a2b18ed32fed242f3a915be9faf02a45496f
8d3597bhttps://github.com/feast-dev/feast/commit/8d3597be8776e36626339f2874eb31ec9eaca6dc
5a80a2bhttps://github.com/feast-dev/feast/commit/5a80a2b18ed32fed242f3a915be9faf02a45496f
Compare https://github.com/feast-dev/feast/compare/8d3597be8776e36626339f2874eb31ec9eaca6dc..5a80a2b18ed32fed242f3a915be9faf02a45496f
August 14, 2026 04:41https://github.com/feast-dev/feast/pull/6689#event-29439464808
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
7278dcfhttps://github.com/feast-dev/feast/commit/7278dcf6c61ed62da7fe7a239712af5946dc2102
Aug 14, 2026https://github.com/feast-dev/feast/pull/6689#event-29439470340
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
Aug 14, 2026 https://github.com/feast-dev/feast/pull/6689#ref-pullrequest-5031843245
fix: Reuse IdP-issued client tokens until near expiry #6687 https://github.com/feast-dev/feast/pull/6687
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
August 14, 2026 14:04https://github.com/feast-dev/feast/pull/6689#event-29462191191
HSarwathttps://github.com/HSarwat
Aug 22, 2026 https://github.com/feast-dev/feast/pull/6689#ref-commit-3062505
https://github.com/larrysingleton007
docs: Correct what _validate_token claims to do (https://github.com/HSarwat/feast/commit/3062505cf3463421d607a733eb4d69ee77fdde11
feast-dev#6689https://github.com/feast-dev/feast/pull/6689
)https://github.com/HSarwat/feast/commit/3062505cf3463421d607a733eb4d69ee77fdde11
3062505https://github.com/HSarwat/feast/commit/3062505cf3463421d607a733eb4d69ee77fdde11
feast-dev#6688https://github.com/feast-dev/feast/issues/6688
Michie-hubhttps://github.com/Michie-hub
Aug 31, 2026 https://github.com/feast-dev/feast/pull/6689#ref-commit-c8f3561
https://github.com/larrysingleton007
https://github.com/Michie-hub
docs: Correct what _validate_token claims to do (https://github.com/Michie-hub/feast/commit/c8f3561f3e2d661c7a5c5aeb8e7c96a4b58c91d3
feast-dev#6689https://github.com/feast-dev/feast/pull/6689
)https://github.com/Michie-hub/feast/commit/c8f3561f3e2d661c7a5c5aeb8e7c96a4b58c91d3
c8f3561https://github.com/Michie-hub/feast/commit/c8f3561f3e2d661c7a5c5aeb8e7c96a4b58c91d3
feast-dev#6688https://github.com/feast-dev/feast/issues/6688
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6689
https://github.com/ntkathole
ntkathole https://github.com/ntkathole
https://github.com/feast-dev/feast/pull/6689/files/3460f87d0f6b710b77701520953b061b4ea20432
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
Please reload this pagehttps://github.com/feast-dev/feast/pull/6689
https://github.com/larrysingleton007
https://github.com/codecov-commenter
https://github.com/ntkathole
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.