René's URL Explorer Experiment


Title: fix: Reuse IdP-issued client tokens until near expiry by larrysingleton007 · Pull Request #6687 · feast-dev/feast · GitHub

Open Graph Title: fix: Reuse IdP-issued client tokens until near expiry by larrysingleton007 · Pull Request #6687 · feast-dev/feast

X Title: fix: Reuse IdP-issued client tokens until near expiry by larrysingleton007 · Pull Request #6687 · feast-dev/feast

Description: What this PR does / why we need it This is the client-side sibling of #6683. On the client_secret (client credentials / ROPC) branch, every outbound RPC builds a fresh auth manager and throws away the token it fetched: get_auth_token constructs a new factory, manager, and OIDCDiscoveryService per call (client_auth_token.py). All three interceptors call it per request: the gRPC interceptor on every intercepted call, the Arrow Flight middleware in sending_headers, and the HTTP wrapper on every session reuse. So each request pays a discovery GET plus a token POST against the IdP for a token that is typically valid for an hour. Measured with counting mocks on master: 5 outbound calls produce 5 discovery GETs and 5 token POSTs. Beyond the added latency, a batch loop multiplies IdP load by request count, which can trip provider rate limits. The fix caches issued tokens keyed by the token-request identity (discovery URL, client id and secret, username, password) and reuses each until shortly before expiry, taken from the token's own exp claim with the token response's expires_in as a fallback. After the change the same measurement performs 1 discovery GET and 1 token POST. The cache is module level because the interceptors construct a fresh manager per RPC, so instance state cannot survive between calls. Only the client_secret branch is affected; static tokens, token_env_var, and mounted service account tokens were already cheap and are untouched. A few details worth reviewer attention: token_refresh_margin_seconds (default 30) is exposed on OidcClientAuthConfig rather than hardcoded, following the same request you made on #6683. It rejects non-positive values, since a zero or negative margin would allow reuse right up to or past expiry. It sits on the client config rather than the shared OidcAuthConfig because only clients fetch tokens from the IdP. A token whose expiry cannot be determined (opaque, and no expires_in) is deliberately not cached, preserving today's per-call behavior rather than guessing a lifetime. Errors from the IdP propagate before any cache write, so a failed fetch never poisons the cache. Concurrent misses for the same identity may fetch in parallel and the last write wins. That costs at most a redundant fetch and never returns a wrong-identity token, which is still strictly better than the guaranteed fetch per request it replaces. One interaction worth flagging: HttpSessionManager.get_session re-calls get_auth_token on every session cache hit, with a comment from #5895 explaining it does so "in case it expired". After this change that call returns a cached token rather than a freshly fetched one. The intent still holds, because the cache never returns a token with less than the margin remaining, but the mechanism changes and it seemed better to say so than to let a reviewer find it. Testing: 7 new unit tests covering reuse until expiry, refusal to cache inside the refresh margin, the expires_in fallback for opaque tokens, no caching when expiry is unknowable, cache keying across distinct configs, the configurable margin changing reuse behavior, and rejection of non-positive margins. An autouse fixture resets the module cache around every test so no test inherits or leaks a cached token. 315 permissions tests pass; ruff and mypy are clean. Which issue(s) this PR fixes Fixes #6684

Open Graph Description: What this PR does / why we need it This is the client-side sibling of #6683. On the client_secret (client credentials / ROPC) branch, every outbound RPC builds a fresh auth manager and throws away ...

X Description: What this PR does / why we need it This is the client-side sibling of #6683. On the client_secret (client credentials / ROPC) branch, every outbound RPC builds a fresh auth manager and throws away ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6687

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4fe18ebc-b6a7-131e-9e42-867fa495939c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9214:3FDE19:35B59E:47BA46:6AFE99BA
html-safe-noncee3f2bf12c21455b7ec333d282ded0f5907c5d515038f294231ce9efa88a3eba4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjE0OjNGREUxOTozNUI1OUU6NDdCQTQ2OjZBRkU5OUJBIiwidmlzaXRvcl9pZCI6IjQ5NTM2NTAwMzIxMzQ3NTY3OTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3abdf9b36a5f8ad481357f4bd19b296d6b7280c752f2dd16b2968eff63680dbf
hovercard-subject-tagpull_request:4179617713
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6687/files
twitter:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
og:image:altWhat this PR does / why we need it This is the client-side sibling of #6683. On the client_secret (client credentials / ROPC) branch, every outbound RPC builds a fresh auth manager and throws away ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6687/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6687%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6687%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6687/files
Reloadhttps://github.com/feast-dev/feast/pull/6687/files
Reloadhttps://github.com/feast-dev/feast/pull/6687/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:fix/oidc-client-token-reusehttps://github.com/larrysingleton007/feast/tree/fix/oidc-client-token-reuse
Conversation 17 https://github.com/feast-dev/feast/pull/6687
Commits 1 https://github.com/feast-dev/feast/pull/6687/commits
Checks 23 https://github.com/feast-dev/feast/pull/6687/checks
Files changed https://github.com/feast-dev/feast/pull/6687/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6687/files
fix: Reuse IdP-issued client tokens until near expiry https://github.com/feast-dev/feast/pull/6687/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6687/files
50c228d fix: Reuse IdP-issued client tokens until near expiry larrysingleton007 Aug 14, 2026 https://github.com/feast-dev/feast/pull/6687/commits/50c228da975d12e5d750eaf5e5b1fe32fe748643
Clear filters https://github.com/feast-dev/feast/pull/6687/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6687/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6687/files
.secrets.baseline https://github.com/feast-dev/feast/pull/6687/files#diff-d8447df0cd384602c76086081f13f27ad0b45902297c42da35a6fc51fdf1cec3
auth_model.py https://github.com/feast-dev/feast/pull/6687/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
client_auth_token.py https://github.com/feast-dev/feast/pull/6687/files#diff-3c1c33c046a329fcdab72cf19986a35bfe2d99ee10f37783053950d80363a2a7
grpc_client_auth_interceptor.py https://github.com/feast-dev/feast/pull/6687/files#diff-3b805fbbc14aa2ecd16c323c9c51db655522cbc97d9a45d9cab5d89ed0f16de1
oidc_authentication_client_manager.py https://github.com/feast-dev/feast/pull/6687/files#diff-e7144bf62eedefc68930345ab8aebffd0e2d07f58e0f9274c6046e512660a961
test_oidc_auth_client.py https://github.com/feast-dev/feast/pull/6687/files#diff-749e0458ec58e045e06c3492aea79a0cbca61d01b695e1ab522a7c23c611349b
.secrets.baselinehttps://github.com/feast-dev/feast/pull/6687/files#diff-d8447df0cd384602c76086081f13f27ad0b45902297c42da35a6fc51fdf1cec3
View file https://github.com/larrysingleton007/feast/blob/50c228da975d12e5d750eaf5e5b1fe32fe748643/.secrets.baseline
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/feast-dev/feast/pull/6687/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/auth_model.pyhttps://github.com/feast-dev/feast/pull/6687/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
View file https://github.com/larrysingleton007/feast/blob/50c228da975d12e5d750eaf5e5b1fe32fe748643/sdk/python/feast/permissions/auth_model.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6687/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6687/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
https://github.com/feast-dev/feast/pull/6687/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/client/client_auth_token.pyhttps://github.com/feast-dev/feast/pull/6687/files#diff-3c1c33c046a329fcdab72cf19986a35bfe2d99ee10f37783053950d80363a2a7
View file https://github.com/larrysingleton007/feast/blob/50c228da975d12e5d750eaf5e5b1fe32fe748643/sdk/python/feast/permissions/client/client_auth_token.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6687/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6687/files#diff-3c1c33c046a329fcdab72cf19986a35bfe2d99ee10f37783053950d80363a2a7
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/client/grpc_client_auth_interceptor.pyhttps://github.com/feast-dev/feast/pull/6687/files#diff-3b805fbbc14aa2ecd16c323c9c51db655522cbc97d9a45d9cab5d89ed0f16de1
View file https://github.com/larrysingleton007/feast/blob/50c228da975d12e5d750eaf5e5b1fe32fe748643/sdk/python/feast/permissions/client/grpc_client_auth_interceptor.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6687/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6687/files#diff-3b805fbbc14aa2ecd16c323c9c51db655522cbc97d9a45d9cab5d89ed0f16de1
https://github.com/feast-dev/feast/pull/6687/files#diff-3b805fbbc14aa2ecd16c323c9c51db655522cbc97d9a45d9cab5d89ed0f16de1
https://github.com/feast-dev/feast/pull/6687/files#diff-3b805fbbc14aa2ecd16c323c9c51db655522cbc97d9a45d9cab5d89ed0f16de1
https://github.com/feast-dev/feast/pull/6687/files#diff-3b805fbbc14aa2ecd16c323c9c51db655522cbc97d9a45d9cab5d89ed0f16de1
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/client/oidc_authentication_client_manager.pyhttps://github.com/feast-dev/feast/pull/6687/files#diff-e7144bf62eedefc68930345ab8aebffd0e2d07f58e0f9274c6046e512660a961
View file https://github.com/larrysingleton007/feast/blob/50c228da975d12e5d750eaf5e5b1fe32fe748643/sdk/python/feast/permissions/client/oidc_authentication_client_manager.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6687/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6687/files#diff-e7144bf62eedefc68930345ab8aebffd0e2d07f58e0f9274c6046e512660a961
Please reload this pagehttps://github.com/feast-dev/feast/pull/6687/files
https://github.com/feast-dev/feast/pull/6687/files#diff-e7144bf62eedefc68930345ab8aebffd0e2d07f58e0f9274c6046e512660a961
https://github.com/feast-dev/feast/pull/6687/files#diff-e7144bf62eedefc68930345ab8aebffd0e2d07f58e0f9274c6046e512660a961
Please reload this pagehttps://github.com/feast-dev/feast/pull/6687/files
https://github.com/feast-dev/feast/pull/6687/files#diff-e7144bf62eedefc68930345ab8aebffd0e2d07f58e0f9274c6046e512660a961
https://github.com/feast-dev/feast/pull/6687/files#diff-e7144bf62eedefc68930345ab8aebffd0e2d07f58e0f9274c6046e512660a961
https://github.com/feast-dev/feast/pull/6687/files#diff-e7144bf62eedefc68930345ab8aebffd0e2d07f58e0f9274c6046e512660a961
Please reload this pagehttps://github.com/feast-dev/feast/pull/6687/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6687/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.