René's URL Explorer Experiment


Title: fix: Reuse the OIDC JWKS client across requests by larrysingleton007 · Pull Request #6683 · feast-dev/feast · GitHub

Open Graph Title: fix: Reuse the OIDC JWKS client across requests by larrysingleton007 · Pull Request #6683 · feast-dev/feast

X Title: fix: Reuse the OIDC JWKS client across requests by larrysingleton007 · Pull Request #6683 · feast-dev/feast

Description: What this PR does / why we need it OidcTokenParser._decode_token builds a fresh PyJWKClient on every call. The JWK-set cache lives on the instance, so every authenticated request starts cold and pays a full HTTPS fetch of the JWKS document (TLS handshake included) before signature verification. On a production-shaped deployment that fetch measured 124-196 ms against the IdP, dominating single-entity online reads (server-side p50 247 ms while the online store idled), and because it's blocking I/O on the event loop, concurrent requests serialize behind it: 3 parallel readers measured an exact 3x of single-request latency, and 10 produced load-balancer 502s from a healthy process. The fix builds the client lazily once per parser (the parser is a process singleton created by init_auth_manager), letting PyJWT's JWK-set cache work. Reproducible benchmark against a counting mock JWKS endpoint with real RS256 tokens: 25 authenticated decodes performed 25 JWKS fetches before, 1 after. Details worth reviewer attention: pyjwt now has a >=2.13.0 floor: the reuse makes PyJWT's cache semantics load-bearing, and only 2.13+ keeps the cache through transient fetch failures (2.5-2.12 wipe it on one failed fetch; pre-2.5 has no cache at all, silently reverting the fix). The lockfiles already resolve 2.13.0, so no lock changes. lifespan=300 and timeout=10 are passed explicitly so upgrades can't silently change behavior. The lifespan bounds two staleness windows that were zero with per-request clients and are documented in the code: a key the IdP removed keeps validating, and a rotation that reuses a kid keeps failing, each for at most 300 s. Rotations that mint a new kid (the common case) recover immediately because PyJWKClient.get_signing_key refreshes and retries on a cache miss. Tests pin the behaviors a refactor could silently break: client built with the right JWKS URL and an SSL context matching verify_ssl (mutation testing showed the SSL branch previously had zero coverage), laziness (no construction before the first request, keeping the blocking discovery fetch out of server boot), per-parser scoping, reuse across requests, and recovery after a failed first construction (the parser is a process singleton, so a wedged client would require a restart). Known accepted residuals, for transparency: on the threaded Arrow Flight server a cold-start burst can still build the client more than once (benign, self-heals, and PyJWT's own cold-fetch path has the same property); PyJWT's JWK-set cache is unlocked so simultaneous expiry can trigger redundant refetches (bounded by concurrency). Both are strictly better than the guaranteed fetch-per-request they replace. The client-side token fetch (client_secret flow) has the same per-request pattern and is a natural follow-up. To be precise about the concurrency claim: this removes the accidental serialization behind per-request network I/O; it does not add parallelism to the server. Testing: 311 permissions unit tests pass (including the new lifecycle tests); full unit suite green (2488 passed); ruff and mypy clean. Which issue(s) this PR fixes Fixes #6682

Open Graph Description: What this PR does / why we need it OidcTokenParser._decode_token builds a fresh PyJWKClient on every call. The JWK-set cache lives on the instance, so every authenticated request starts cold and pa...

X Description: What this PR does / why we need it OidcTokenParser._decode_token builds a fresh PyJWKClient on every call. The JWK-set cache lives on the instance, so every authenticated request starts cold and pa...

Opengraph URL: https://github.com/feast-dev/feast/pull/6683

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:09182702-a906-6d67-f2f7-a762fa8171df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1FE:342711:2D5AAE:3C85AE:6AFE989F
html-safe-nonce8870cf79685c344ec1fc60ac8467f9b9bf57fdc0976013cf77f59408a418833b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUZFOjM0MjcxMToyRDVBQUU6M0M4NUFFOjZBRkU5ODlGIiwidmlzaXRvcl9pZCI6IjQ2NDcyMDA0NjA1NDc5ODc2MTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf814268260d3d8cadd43c7cb1b4c7160c69f004bdbf34f4de92e2e3de3e6dd8f
hovercard-subject-tagpull_request:4178712343
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6683/files
twitter:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
og:image:altWhat this PR does / why we need it OidcTokenParser._decode_token builds a fresh PyJWKClient on every call. The JWK-set cache lives on the instance, so every authenticated request starts cold and pa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6683/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6683%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6683%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6683/files
Reloadhttps://github.com/feast-dev/feast/pull/6683/files
Reloadhttps://github.com/feast-dev/feast/pull/6683/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
franciscojavierarceohttps://github.com/franciscojavierarceo
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:fix/oidc-jwks-client-reusehttps://github.com/larrysingleton007/feast/tree/fix/oidc-jwks-client-reuse
Conversation 7 https://github.com/feast-dev/feast/pull/6683
Commits 5 https://github.com/feast-dev/feast/pull/6683/commits
Checks 23 https://github.com/feast-dev/feast/pull/6683/checks
Files changed https://github.com/feast-dev/feast/pull/6683/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6683/files
fix: Reuse the OIDC JWKS client across requests https://github.com/feast-dev/feast/pull/6683/files#top
Show all changes 5 commits https://github.com/feast-dev/feast/pull/6683/files
4b349fc fix: Reuse the OIDC JWKS client across requests larrysingleton007 Jul 31, 2026 https://github.com/feast-dev/feast/pull/6683/commits/4b349fc07ef019ec3d33e9a8a6f44d96d8c96c3a
602feb0 fix: Harden JWKS client reuse from review findings larrysingleton007 Jul 31, 2026 https://github.com/feast-dev/feast/pull/6683/commits/602feb009b7dc468765af85bdc744c3c51d71dc9
c62e946 feat: Make the JWKS cache lifespan and fetch timeout configurable larrysingleton007 Jul 31, 2026 https://github.com/feast-dev/feast/pull/6683/commits/c62e9467ebc13f71f3cf046bc882af2659e146b3
80fdf24 Merge branch 'master' into fix/oidc-jwks-client-reuse larrysingleton007 Jul 31, 2026 https://github.com/feast-dev/feast/pull/6683/commits/80fdf2452927bc83275a57ba6dc553ec636c80e7
1a5226e chore: Update pixi.lock for the pyjwt floor larrysingleton007 Jul 31, 2026 https://github.com/feast-dev/feast/pull/6683/commits/1a5226e4760722016f60ea7f8c5ccbc2cd743323
Clear filters https://github.com/feast-dev/feast/pull/6683/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6683/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6683/files
authz_manager.md https://github.com/feast-dev/feast/pull/6683/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
pixi.lock https://github.com/feast-dev/feast/pull/6683/files#diff-514667ae85a632bc7477f28eb9a990559627589fb6fe88da2732569b2143afb3
pyproject.toml https://github.com/feast-dev/feast/pull/6683/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
oidc_token_parser.py https://github.com/feast-dev/feast/pull/6683/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
auth_model.py https://github.com/feast-dev/feast/pull/6683/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
test_token_parser.py https://github.com/feast-dev/feast/pull/6683/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/getting-started/components/authz_manager.mdhttps://github.com/feast-dev/feast/pull/6683/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
View file https://github.com/larrysingleton007/feast/blob/1a5226e4760722016f60ea7f8c5ccbc2cd743323/docs/getting-started/components/authz_manager.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6683/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6683/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
https://github.com/feast-dev/feast/pull/6683/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
pixi.lockhttps://github.com/feast-dev/feast/pull/6683/files#diff-514667ae85a632bc7477f28eb9a990559627589fb6fe88da2732569b2143afb3
View file https://github.com/larrysingleton007/feast/blob/1a5226e4760722016f60ea7f8c5ccbc2cd743323/pixi.lock
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/feast-dev/feast/pull/6683/files
pyproject.tomlhttps://github.com/feast-dev/feast/pull/6683/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
View file https://github.com/larrysingleton007/feast/blob/1a5226e4760722016f60ea7f8c5ccbc2cd743323/pyproject.toml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6683/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6683/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
https://github.com/feast-dev/feast/pull/6683/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/auth/oidc_token_parser.pyhttps://github.com/feast-dev/feast/pull/6683/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
View file https://github.com/larrysingleton007/feast/blob/1a5226e4760722016f60ea7f8c5ccbc2cd743323/sdk/python/feast/permissions/auth/oidc_token_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6683/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6683/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/pull/6683/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/pull/6683/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/pull/6683/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/auth_model.pyhttps://github.com/feast-dev/feast/pull/6683/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
View file https://github.com/larrysingleton007/feast/blob/1a5226e4760722016f60ea7f8c5ccbc2cd743323/sdk/python/feast/permissions/auth_model.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6683/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6683/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
https://github.com/feast-dev/feast/pull/6683/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
https://github.com/feast-dev/feast/pull/6683/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
https://github.com/feast-dev/feast/pull/6683/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/permissions/auth/test_token_parser.pyhttps://github.com/feast-dev/feast/pull/6683/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
View file https://github.com/larrysingleton007/feast/blob/1a5226e4760722016f60ea7f8c5ccbc2cd743323/sdk/python/tests/unit/permissions/auth/test_token_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6683/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6683/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
https://github.com/feast-dev/feast/pull/6683/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
https://github.com/feast-dev/feast/pull/6683/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
Please reload this pagehttps://github.com/feast-dev/feast/pull/6683/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.