René's URL Explorer Experiment


Title: feat: Pass optional OIDC audience and issuer through the operator by larrysingleton007 · Pull Request #6677 · feast-dev/feast · GitHub

Open Graph Title: feat: Pass optional OIDC audience and issuer through the operator by larrysingleton007 · Pull Request #6677 · feast-dev/feast

X Title: feat: Pass optional OIDC audience and issuer through the operator by larrysingleton007 · Pull Request #6677 · feast-dev/feast

Description: What this PR does / why we need it Follow-up to #6670, requested in review there: expose the new optional OIDC audience and issuer verification fields through the feast-operator. Adds audience and issuer to OidcOptionalSecretProperties, so operators can set them in the referenced OIDC Secret and they flow into the generated feature_store.yaml auth section the same way client_id, client_secret, username, and password already do. When the keys are absent, nothing changes. Also documents the two optional Secret keys in the operator security guide, with a pointer to the main OIDC authorization page for the caveat about token claims versus discovery metadata. Scope note: verify_ssl and ca_cert_path are deliberately not added to the whitelist. They're already exposed as first-class CR fields (verifySSL, caCertConfigMap) that feed the same generated auth section, so whitelisting them would create two sources for the same keys. The Secret bag carries IdP-coupled values (auth_discovery_url, client_id, ...), which is where audience and issuer belong; a first-class CR field for issuer was considered and rejected because the existing issuerUrl field already means the discovery base URL, not the token iss claim. Testing: extended the repo config suite to include both keys in the mocked Secret and assert they arrive in OidcParameters with their values intact, plus the reconcile-level envtest fixtures so the keys go through real Secret extraction and YAML serialization. go build ./... and go test ./internal/controller/... pass. A pre-submit review pass surfaced two things worth calling out: Secret values are YAML-parsed on extraction, so an all-digits audience (a numeric IdP application ID) would arrive as an int, render unquoted, and fail the SDK's Optional[str] validation at server startup. The copy now coerces the two claim keys to strings, with a regression test. If a referenced Secret already contains keys named audience or issuer (previously ignored), they take effect after this change. That and two other operational caveats (the IdP must mint matching claims for Feast's own client token flows, and Secret edits apply on the next reconcile rather than immediately) are documented in the security guide. Deliberately left out: ui_client_id is similarly absent from the whitelist and consumed by the UI server; left for a separate change if wanted, to keep this one to the review request. Which issue(s) this PR fixes Fixes #6676 Related to #6669 (main change in #6670).

Open Graph Description: What this PR does / why we need it Follow-up to #6670, requested in review there: expose the new optional OIDC audience and issuer verification fields through the feast-operator. Adds audience and ...

X Description: What this PR does / why we need it Follow-up to #6670, requested in review there: expose the new optional OIDC audience and issuer verification fields through the feast-operator. Adds audience and ...

Opengraph URL: https://github.com/feast-dev/feast/pull/6677

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:932b0a3c-d86e-d4a0-55d3-8386b4b29e53
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEBE8:281DDB:E12A99:137054F:6AFE9883
html-safe-nonceafebb46cf96191a4be154a64b77e9943cf4977726e5279436de71a8f252e66a1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkU4OjI4MUREQjpFMTJBOTk6MTM3MDU0Rjo2QUZFOTg4MyIsInZpc2l0b3JfaWQiOiI3OTIwNDIxMzQ3Nzk5MjQyODgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac667cd6c983b5571257dd50ee187c7133a1a918fcb6525edb3e964c26b00a2bf6
hovercard-subject-tagpull_request:4170723361
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6677/files
twitter:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
og:image:altWhat this PR does / why we need it Follow-up to #6670, requested in review there: expose the new optional OIDC audience and issuer verification fields through the feast-operator. Adds audience and ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6677/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6677%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6677%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6677/files
Reloadhttps://github.com/feast-dev/feast/pull/6677/files
Reloadhttps://github.com/feast-dev/feast/pull/6677/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:feat/operator-oidc-audience-issuerhttps://github.com/larrysingleton007/feast/tree/feat/operator-oidc-audience-issuer
Conversation 2 https://github.com/feast-dev/feast/pull/6677
Commits 3 https://github.com/feast-dev/feast/pull/6677/commits
Checks 24 https://github.com/feast-dev/feast/pull/6677/checks
Files changed https://github.com/feast-dev/feast/pull/6677/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6677/files
feat: Pass optional OIDC audience and issuer through the operator https://github.com/feast-dev/feast/pull/6677/files#top
Show all changes 3 commits https://github.com/feast-dev/feast/pull/6677/files
28e3609 feat: Pass optional OIDC audience and issuer through the operator larrysingleton007 Jul 30, 2026 https://github.com/feast-dev/feast/pull/6677/commits/28e3609f9c8b764536254d3cc9aa089950dba810
543f9d0 fix: Coerce numeric OIDC audience and issuer Secret values to strings larrysingleton007 Jul 30, 2026 https://github.com/feast-dev/feast/pull/6677/commits/543f9d05334f5eba64ed867334837f4860296cf5
d8ef562 docs: Sharpen operator OIDC audience/issuer docs and fix dead links larrysingleton007 Jul 30, 2026 https://github.com/feast-dev/feast/pull/6677/commits/d8ef562be3ad28322c89a23f52cc7d6c1ab0a1a2
Clear filters https://github.com/feast-dev/feast/pull/6677/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6677/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6677/files
.secrets.baseline https://github.com/feast-dev/feast/pull/6677/files#diff-d8447df0cd384602c76086081f13f27ad0b45902297c42da35a6fc51fdf1cec3
05-security.md https://github.com/feast-dev/feast/pull/6677/files#diff-2c498f3f95bb38d619452f3eeb2bcb9eba77506426fdcffcf45af33d40af31f7
v1_featurestore_oidc_auth.yaml https://github.com/feast-dev/feast/pull/6677/files#diff-2a99aae4d7477e5283ae948062697dcf79777d27d177d5bcc6714db8735759ab
featurestore_controller_oidc_auth_test.go https://github.com/feast-dev/feast/pull/6677/files#diff-1847e001c32834c924350d8ad724d3338cb7a7322fcab7299039fa2297292650
repo_config.go https://github.com/feast-dev/feast/pull/6677/files#diff-fc7f85fbe0916120be56bb8b7209d44ecf8026b963bbdfb4f4907d0b4f9e28b8
repo_config_test.go https://github.com/feast-dev/feast/pull/6677/files#diff-3b7f7a03dd8422844cdbffa8364f371dc981e256fee4ae2c19ae91137380fc79
services_types.go https://github.com/feast-dev/feast/pull/6677/files#diff-97853b3d7540c277dba32574e6ca783d8baac8bdefdf32577ab1300b2d09684f
.secrets.baselinehttps://github.com/feast-dev/feast/pull/6677/files#diff-d8447df0cd384602c76086081f13f27ad0b45902297c42da35a6fc51fdf1cec3
View file https://github.com/larrysingleton007/feast/blob/d8ef562be3ad28322c89a23f52cc7d6c1ab0a1a2/.secrets.baseline
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/feast-dev/feast/pull/6677/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/how-to-guides/feast-operator/05-security.mdhttps://github.com/feast-dev/feast/pull/6677/files#diff-2c498f3f95bb38d619452f3eeb2bcb9eba77506426fdcffcf45af33d40af31f7
View file https://github.com/larrysingleton007/feast/blob/d8ef562be3ad28322c89a23f52cc7d6c1ab0a1a2/docs/how-to-guides/feast-operator/05-security.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6677/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6677/files#diff-2c498f3f95bb38d619452f3eeb2bcb9eba77506426fdcffcf45af33d40af31f7
https://github.com/feast-dev/feast/pull/6677/files#diff-2c498f3f95bb38d619452f3eeb2bcb9eba77506426fdcffcf45af33d40af31f7
https://github.com/feast-dev/feast/pull/6677/files#diff-2c498f3f95bb38d619452f3eeb2bcb9eba77506426fdcffcf45af33d40af31f7
https://github.com/feast-dev/feast/pull/6677/files#diff-2c498f3f95bb38d619452f3eeb2bcb9eba77506426fdcffcf45af33d40af31f7
https://github.com/feast-dev/feast/pull/6677/files#diff-2c498f3f95bb38d619452f3eeb2bcb9eba77506426fdcffcf45af33d40af31f7
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/feast-operator/config/samples/v1_featurestore_oidc_auth.yamlhttps://github.com/feast-dev/feast/pull/6677/files#diff-2a99aae4d7477e5283ae948062697dcf79777d27d177d5bcc6714db8735759ab
View file https://github.com/larrysingleton007/feast/blob/d8ef562be3ad28322c89a23f52cc7d6c1ab0a1a2/infra/feast-operator/config/samples/v1_featurestore_oidc_auth.yaml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6677/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6677/files#diff-2a99aae4d7477e5283ae948062697dcf79777d27d177d5bcc6714db8735759ab
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/feast-operator/internal/controller/featurestore_controller_oidc_auth_test.gohttps://github.com/feast-dev/feast/pull/6677/files#diff-1847e001c32834c924350d8ad724d3338cb7a7322fcab7299039fa2297292650
View file https://github.com/larrysingleton007/feast/blob/d8ef562be3ad28322c89a23f52cc7d6c1ab0a1a2/infra/feast-operator/internal/controller/featurestore_controller_oidc_auth_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6677/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6677/files#diff-1847e001c32834c924350d8ad724d3338cb7a7322fcab7299039fa2297292650
https://github.com/feast-dev/feast/pull/6677/files#diff-1847e001c32834c924350d8ad724d3338cb7a7322fcab7299039fa2297292650
https://github.com/feast-dev/feast/pull/6677/files#diff-1847e001c32834c924350d8ad724d3338cb7a7322fcab7299039fa2297292650
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/feast-operator/internal/controller/services/repo_config.gohttps://github.com/feast-dev/feast/pull/6677/files#diff-fc7f85fbe0916120be56bb8b7209d44ecf8026b963bbdfb4f4907d0b4f9e28b8
View file https://github.com/larrysingleton007/feast/blob/d8ef562be3ad28322c89a23f52cc7d6c1ab0a1a2/infra/feast-operator/internal/controller/services/repo_config.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6677/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6677/files#diff-fc7f85fbe0916120be56bb8b7209d44ecf8026b963bbdfb4f4907d0b4f9e28b8
https://github.com/feast-dev/feast/pull/6677/files#diff-fc7f85fbe0916120be56bb8b7209d44ecf8026b963bbdfb4f4907d0b4f9e28b8
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/feast-operator/internal/controller/services/repo_config_test.gohttps://github.com/feast-dev/feast/pull/6677/files#diff-3b7f7a03dd8422844cdbffa8364f371dc981e256fee4ae2c19ae91137380fc79
View file https://github.com/larrysingleton007/feast/blob/d8ef562be3ad28322c89a23f52cc7d6c1ab0a1a2/infra/feast-operator/internal/controller/services/repo_config_test.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6677/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6677/files#diff-3b7f7a03dd8422844cdbffa8364f371dc981e256fee4ae2c19ae91137380fc79
https://github.com/feast-dev/feast/pull/6677/files#diff-3b7f7a03dd8422844cdbffa8364f371dc981e256fee4ae2c19ae91137380fc79
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L7
infra/feast-operator/internal/controller/services/services_types.gohttps://github.com/feast-dev/feast/pull/6677/files#diff-97853b3d7540c277dba32574e6ca783d8baac8bdefdf32577ab1300b2d09684f
View file https://github.com/larrysingleton007/feast/blob/d8ef562be3ad28322c89a23f52cc7d6c1ab0a1a2/infra/feast-operator/internal/controller/services/services_types.go
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6677/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6677/files#diff-97853b3d7540c277dba32574e6ca783d8baac8bdefdf32577ab1300b2d09684f
https://github.com/feast-dev/feast/pull/6677/files#diff-97853b3d7540c277dba32574e6ca783d8baac8bdefdf32577ab1300b2d09684f
https://github.com/feast-dev/feast/pull/6677/files#diff-97853b3d7540c277dba32574e6ca783d8baac8bdefdf32577ab1300b2d09684f
https://github.com/feast-dev/feast/pull/6677/files#diff-97853b3d7540c277dba32574e6ca783d8baac8bdefdf32577ab1300b2d09684f
Please reload this pagehttps://github.com/feast-dev/feast/pull/6677/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.