René's URL Explorer Experiment


Title: feat: Add optional OIDC token audience and issuer verification by larrysingleton007 · Pull Request #6670 · feast-dev/feast · GitHub

Open Graph Title: feat: Add optional OIDC token audience and issuer verification by larrysingleton007 · Pull Request #6670 · feast-dev/feast

X Title: feat: Add optional OIDC token audience and issuer verification by larrysingleton007 · Pull Request #6670 · feast-dev/feast

Description: What this PR does / why we need it Adds optional audience and issuer verification to the OIDC token parser. Today the parser verifies signature and expiry only, so any validly-signed, unexpired token from the configured IdP authenticates regardless of which resource it was minted for; RBAC role matching is the only remaining gate. Two new OidcAuthConfig fields, audience and issuer, both unset by default: auth: type: oidc client_id: _CLIENT_ID_ auth_discovery_url: https://login.example.com/.well-known/openid-configuration audience: api://feast-feature-server issuer: https://login.example.com/realms/master When set, jwt.decode runs with verify_aud / verify_iss enabled against the configured values, and a mismatched or missing claim rejects the token at authentication. When unset, the decode options are identical to before, so existing deployments see no behavior change; all pre-existing tests are untouched and passing. Opt-in rather than strict-by-default because IdPs commonly mint tokens whose claims differ from their discovery metadata. Entra ID issues v1.0 tokens (iss under sts.windows.net, api:// audience) that are routinely validated against a v2.0 discovery URL, which works because discovery is only used to source JWKS keys. test_oidc_default_supports_v1_tokens_against_v2_discovery pins that setup so a future refactor cannot silently regress it. Operators state expected values explicitly rather than the code inferring them from the discovery document, for the same reason. Testing: 11 new unit tests. Config-to-decode fidelity (the verified decode enables exactly the checks the config provides), end-to-end RS256-signed tokens through the real jwt.decode (match accepted, mismatch rejected, missing claim rejected, default permissive), and the v1/v2 pin. tests/unit/permissions: 307 passing; ruff and mypy clean on the changed files. Docs: the OIDC section of authz_manager.md documents the new options and warns that expected values must match the token's claims, not the discovery document. Not included: the feast-operator's OIDC secret-key whitelist (OidcOptionalSecretProperties) does not yet pass audience/issuer through to the generated feature_store.yaml. Happy to follow up separately if there is interest in exposing these via the operator CRD. Which issue(s) this PR fixes Fixes #6669

Open Graph Description: What this PR does / why we need it Adds optional audience and issuer verification to the OIDC token parser. Today the parser verifies signature and expiry only, so any validly-signed, unexpired tok...

X Description: What this PR does / why we need it Adds optional audience and issuer verification to the OIDC token parser. Today the parser verifies signature and expiry only, so any validly-signed, unexpired tok...

Opengraph URL: https://github.com/feast-dev/feast/pull/6670

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:34268763-fabe-5ffa-c773-4a9c9ae70c37
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC18C:20D634:DFF017:12ABE34:6AFE98B0
html-safe-nonce1d47986ab43e15b928442f06b5787817d9d4795947db6e92a8cad1b16adf046f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMThDOjIwRDYzNDpERkYwMTc6MTJBQkUzNDo2QUZFOThCMCIsInZpc2l0b3JfaWQiOiIxMDEwMTA1MzkxMzE0Mjc4NTc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac01092125e166a9b40f5c4090667e328c6853a649e4e8c0d35eb0de391f393114
hovercard-subject-tagpull_request:4170007854
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6670/files
twitter:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
og:image:altWhat this PR does / why we need it Adds optional audience and issuer verification to the OIDC token parser. Today the parser verifies signature and expiry only, so any validly-signed, unexpired tok...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6670/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6670%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6670%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6670/files
Reloadhttps://github.com/feast-dev/feast/pull/6670/files
Reloadhttps://github.com/feast-dev/feast/pull/6670/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:feat/oidc-optional-audience-issuer-verificationhttps://github.com/larrysingleton007/feast/tree/feat/oidc-optional-audience-issuer-verification
Conversation 5 https://github.com/feast-dev/feast/pull/6670
Commits 2 https://github.com/feast-dev/feast/pull/6670/commits
Checks 23 https://github.com/feast-dev/feast/pull/6670/checks
Files changed https://github.com/feast-dev/feast/pull/6670/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6670/files
feat: Add optional OIDC token audience and issuer verification https://github.com/feast-dev/feast/pull/6670/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6670/files
770abb8 feat: Add optional OIDC token audience and issuer verification larrysingleton007 Jul 30, 2026 https://github.com/feast-dev/feast/pull/6670/commits/770abb8e63f95e7fb5d3edddbcf1d40d93e8acac
67074d0 docs: Document optional OIDC audience and issuer verification larrysingleton007 Jul 30, 2026 https://github.com/feast-dev/feast/pull/6670/commits/67074d03d8b7b2217792135e6a8823e95f6bb080
Clear filters https://github.com/feast-dev/feast/pull/6670/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6670/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6670/files
authz_manager.md https://github.com/feast-dev/feast/pull/6670/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
oidc_token_parser.py https://github.com/feast-dev/feast/pull/6670/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
auth_model.py https://github.com/feast-dev/feast/pull/6670/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
test_token_parser.py https://github.com/feast-dev/feast/pull/6670/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/getting-started/components/authz_manager.mdhttps://github.com/feast-dev/feast/pull/6670/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
View file https://github.com/larrysingleton007/feast/blob/67074d03d8b7b2217792135e6a8823e95f6bb080/docs/getting-started/components/authz_manager.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6670/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6670/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
https://github.com/feast-dev/feast/pull/6670/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
https://github.com/feast-dev/feast/pull/6670/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
https://github.com/feast-dev/feast/pull/6670/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/auth/oidc_token_parser.pyhttps://github.com/feast-dev/feast/pull/6670/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
View file https://github.com/larrysingleton007/feast/blob/67074d03d8b7b2217792135e6a8823e95f6bb080/sdk/python/feast/permissions/auth/oidc_token_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6670/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6670/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/pull/6670/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/pull/6670/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/auth_model.pyhttps://github.com/feast-dev/feast/pull/6670/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
View file https://github.com/larrysingleton007/feast/blob/67074d03d8b7b2217792135e6a8823e95f6bb080/sdk/python/feast/permissions/auth_model.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6670/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6670/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
https://github.com/feast-dev/feast/pull/6670/files#diff-4f9b2e02b768b2046fa09606d5787aead37725be48bd328ce57e928542576093
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/permissions/auth/test_token_parser.pyhttps://github.com/feast-dev/feast/pull/6670/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
View file https://github.com/larrysingleton007/feast/blob/67074d03d8b7b2217792135e6a8823e95f6bb080/sdk/python/tests/unit/permissions/auth/test_token_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6670/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6670/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
https://github.com/feast-dev/feast/pull/6670/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
https://github.com/feast-dev/feast/pull/6670/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
Please reload this pagehttps://github.com/feast-dev/feast/pull/6670/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.