Title: feat: Add plan() support to DynamoDBOnlineStore by casaar97 · Pull Request #6661 · feast-dev/feast · GitHub
Open Graph Title: feat: Add plan() support to DynamoDBOnlineStore by casaar97 · Pull Request #6661 · feast-dev/feast
X Title: feat: Add plan() support to DynamoDBOnlineStore by casaar97 · Pull Request #6661 · feast-dev/feast
Description: What this PR does / why we need it Fixes #6660. DynamoDBOnlineStore doesn't override OnlineStore.plan(), so it inherits the no-op default and feast plan never reports any DynamoDB table changes. SqliteOnlineStore and MilvusOnlineStore already implement plan(); this brings DynamoDB in line. Adds: DynamoDBTable(InfraObject), using the InfraObject proto's CustomInfra field (protos/feast/core/InfraObject.proto), which exists specifically so online stores can add InfraObject support without a core proto change -- no other in-tree store uses it yet. DynamoDBOnlineStore.plan(), returning one DynamoDBTable per feature view (batch and stream). Uses the corrected per-list pattern from #6659 (FeatureView.from_proto() for feature_views, StreamFeatureView.from_proto() for stream_feature_views) rather than applying one function to both, which is what caused the bug in #6658. Scope note: this only changes what feast plan reports. feast apply's diff-based path (FeatureStore._should_use_plan(), which would call InfraObject.update()/teardown()) is gated to the local/sqlite provider only today, so DynamoDBOnlineStore.update()/teardown() -- which already perform the real table creation/deletion -- are completely unaffected. feast apply behavior for DynamoDB does not change. Which issue(s) this PR fixes Fixes #6660 Does this PR introduce a user-facing change? `feast plan` now reports DynamoDB table changes instead of always showing none. Test plan Added sdk/python/tests/unit/infra/online_store/test_dynamodb_plan.py: one table per feature view, stream feature views included (regression guard for the #6658 bug pattern), batch + stream together, empty registry, and a full Infra proto round-trip through the CustomInfra/dotted-class-type path. Confirmed the new tests fail with the expected ImportError before this change, pass after. Ran the full sdk/python/tests/unit/infra/online_store/ directory (210 tests) -- no regressions. ruff check and ruff format --check pass on the changed files.
Open Graph Description: What this PR does / why we need it Fixes #6660. DynamoDBOnlineStore doesn't override OnlineStore.plan(), so it inherits the no-op default and feast plan never reports any DynamoDB table changes...
X Description: What this PR does / why we need it Fixes #6660. DynamoDBOnlineStore doesn't override OnlineStore.plan(), so it inherits the no-op default and feast plan never reports any DynamoDB table cha...
Opengraph URL: https://github.com/feast-dev/feast/pull/6661
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b46b6649-0d0a-eb58-b11c-221b61be1c68 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 987E:6B7A6:F58965:1437AA6:6AFE99CA |
| html-safe-nonce | 873626ab0e79091852383ea33b9a9e6a189b6db3b25bbcbb4add75067f619ad1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODdFOjZCN0E2OkY1ODk2NToxNDM3QUE2OjZBRkU5OUNBIiwidmlzaXRvcl9pZCI6IjczOTY1MjExMzM5NTM5NDgxMDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 11b5199438d1bcd113a25436fb6ea9816b7f5866beede405b0f86061cafb8b05 |
| hovercard-subject-tag | pull_request:4160591821 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6661/files |
| twitter:image | https://avatars.githubusercontent.com/u/22341152?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/22341152?s=400&v=4 |
| og:image:alt | What this PR does / why we need it Fixes #6660. DynamoDBOnlineStore doesn't override OnlineStore.plan(), so it inherits the no-op default and feast plan never reports any DynamoDB table changes... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width