Title: fix: Use matching proto class per feature view list in SqliteOnlineStore.plan() by casaar97 · Pull Request #6659 · feast-dev/feast · GitHub
Open Graph Title: fix: Use matching proto class per feature view list in SqliteOnlineStore.plan() by casaar97 · Pull Request #6659 · feast-dev/feast
X Title: fix: Use matching proto class per feature view list in SqliteOnlineStore.plan() by casaar97 · Pull Request #6659 · feast-dev/feast
Description: What this PR does / why we need it Fixes #6658. SqliteOnlineStore.plan() applies FeatureView.from_proto() uniformly to both desired_registry_proto.feature_views and desired_registry_proto.stream_feature_views. FeatureView is @typechecked, and from_proto's parameter is annotated as FeatureViewProto, so passing a StreamFeatureViewProto (from the stream_feature_views list) raises typeguard.TypeCheckError at runtime -- plan() (and therefore feast plan) fails outright on any repo with at least one StreamFeatureView registered. This uses the matching class per list instead: views = [ FeatureView.from_proto(view) for view in desired_registry_proto.feature_views ] + [ StreamFeatureView.from_proto(view) for view in desired_registry_proto.stream_feature_views ] _table_id() / compute_table_id() / compute_versioned_name() only touch .name, .projection, and .current_version_number (the latter two via getattr with defaults), so a StreamFeatureView instance works the same as a FeatureView instance there -- no other change needed. We ran into this adding plan()/InfraObject support to a custom online store and initially copied this exact pattern from sqlite.py as the only in-tree reference implementation of plan(). Which issue(s) this PR fixes Fixes #6658 Does this PR introduce a user-facing change? Fixed `feast plan` raising a typeguard.TypeCheckError for any repo with a registered StreamFeatureView. Test plan Added sdk/python/tests/unit/infra/online_store/test_sqlite_plan.py with two cases: a registry with only a StreamFeatureView, and one with a batch FeatureView and a StreamFeatureView together. Confirmed both fail with the exact traceback from #6658 on master before this change, and pass after. Ran the full sdk/python/tests/unit/infra/online_store/ directory (206 tests) -- no regressions. ruff check and ruff format --check pass on the changed files.
Open Graph Description: What this PR does / why we need it Fixes #6658. SqliteOnlineStore.plan() applies FeatureView.from_proto() uniformly to both desired_registry_proto.feature_views and desired_registry_proto.stream_fe...
X Description: What this PR does / why we need it Fixes #6658. SqliteOnlineStore.plan() applies FeatureView.from_proto() uniformly to both desired_registry_proto.feature_views and desired_registry_proto.stream_fe...
Opengraph URL: https://github.com/feast-dev/feast/pull/6659
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:899db17b-e8a4-3289-4d59-7d239503a7de |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F42:A7C4D:F242E5:14B0A69:6AFE98A0 |
| html-safe-nonce | dda52c77fd81ddd979217a312c2c7ecd7c7622efda2a926df97534457896ffc7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjQyOkE3QzREOkYyNDJFNToxNEIwQTY5OjZBRkU5OEEwIiwidmlzaXRvcl9pZCI6IjM5NTc2MDMyNDczOTYzOTUxNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 14ece1f4996cf94205731d70156783673a38c0fda666e09c294214021b9fafd3 |
| hovercard-subject-tag | pull_request:4160408063 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6659/files |
| twitter:image | https://avatars.githubusercontent.com/u/22341152?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/22341152?s=400&v=4 |
| og:image:alt | What this PR does / why we need it Fixes #6658. SqliteOnlineStore.plan() applies FeatureView.from_proto() uniformly to both desired_registry_proto.feature_views and desired_registry_proto.stream_fe... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4a10310af51a1bfffbedc4fd81cb582acf0cb0ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width