René's URL Explorer Experiment


Title: fix: Use matching proto class per feature view list in SqliteOnlineStore.plan() by casaar97 · Pull Request #6659 · feast-dev/feast · GitHub

Open Graph Title: fix: Use matching proto class per feature view list in SqliteOnlineStore.plan() by casaar97 · Pull Request #6659 · feast-dev/feast

X Title: fix: Use matching proto class per feature view list in SqliteOnlineStore.plan() by casaar97 · Pull Request #6659 · feast-dev/feast

Description: What this PR does / why we need it Fixes #6658. SqliteOnlineStore.plan() applies FeatureView.from_proto() uniformly to both desired_registry_proto.feature_views and desired_registry_proto.stream_feature_views. FeatureView is @typechecked, and from_proto's parameter is annotated as FeatureViewProto, so passing a StreamFeatureViewProto (from the stream_feature_views list) raises typeguard.TypeCheckError at runtime -- plan() (and therefore feast plan) fails outright on any repo with at least one StreamFeatureView registered. This uses the matching class per list instead: views = [ FeatureView.from_proto(view) for view in desired_registry_proto.feature_views ] + [ StreamFeatureView.from_proto(view) for view in desired_registry_proto.stream_feature_views ] _table_id() / compute_table_id() / compute_versioned_name() only touch .name, .projection, and .current_version_number (the latter two via getattr with defaults), so a StreamFeatureView instance works the same as a FeatureView instance there -- no other change needed. We ran into this adding plan()/InfraObject support to a custom online store and initially copied this exact pattern from sqlite.py as the only in-tree reference implementation of plan(). Which issue(s) this PR fixes Fixes #6658 Does this PR introduce a user-facing change? Fixed `feast plan` raising a typeguard.TypeCheckError for any repo with a registered StreamFeatureView. Test plan Added sdk/python/tests/unit/infra/online_store/test_sqlite_plan.py with two cases: a registry with only a StreamFeatureView, and one with a batch FeatureView and a StreamFeatureView together. Confirmed both fail with the exact traceback from #6658 on master before this change, and pass after. Ran the full sdk/python/tests/unit/infra/online_store/ directory (206 tests) -- no regressions. ruff check and ruff format --check pass on the changed files.

Open Graph Description: What this PR does / why we need it Fixes #6658. SqliteOnlineStore.plan() applies FeatureView.from_proto() uniformly to both desired_registry_proto.feature_views and desired_registry_proto.stream_fe...

X Description: What this PR does / why we need it Fixes #6658. SqliteOnlineStore.plan() applies FeatureView.from_proto() uniformly to both desired_registry_proto.feature_views and desired_registry_proto.stream_fe...

Opengraph URL: https://github.com/feast-dev/feast/pull/6659

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:899db17b-e8a4-3289-4d59-7d239503a7de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F42:A7C4D:F242E5:14B0A69:6AFE98A0
html-safe-noncedda52c77fd81ddd979217a312c2c7ecd7c7622efda2a926df97534457896ffc7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjQyOkE3QzREOkYyNDJFNToxNEIwQTY5OjZBRkU5OEEwIiwidmlzaXRvcl9pZCI6IjM5NTc2MDMyNDczOTYzOTUxNjkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac14ece1f4996cf94205731d70156783673a38c0fda666e09c294214021b9fafd3
hovercard-subject-tagpull_request:4160408063
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6659/files
twitter:imagehttps://avatars.githubusercontent.com/u/22341152?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22341152?s=400&v=4
og:image:altWhat this PR does / why we need it Fixes #6658. SqliteOnlineStore.plan() applies FeatureView.from_proto() uniformly to both desired_registry_proto.feature_views and desired_registry_proto.stream_fe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6659/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6659%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6659%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6659/files
Reloadhttps://github.com/feast-dev/feast/pull/6659/files
Reloadhttps://github.com/feast-dev/feast/pull/6659/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
casaar97:fix/plan-stream-feature-view-typecheckhttps://github.com/casaar97/feast/tree/fix/plan-stream-feature-view-typecheck
Conversation 3 https://github.com/feast-dev/feast/pull/6659
Commits 1 https://github.com/feast-dev/feast/pull/6659/commits
Checks 23 https://github.com/feast-dev/feast/pull/6659/checks
Files changed https://github.com/feast-dev/feast/pull/6659/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6659/files
fix: Use matching proto class per feature view list in SqliteOnlineStore.plan() https://github.com/feast-dev/feast/pull/6659/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6659/files
d972891 fix: use matching proto class per feature view list in SqliteOnlineSt… casaar97 Jul 29, 2026 https://github.com/feast-dev/feast/pull/6659/commits/d97289166d0a0139bd19459a9dd0f03a5c001b38
Clear filters https://github.com/feast-dev/feast/pull/6659/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6659/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6659/files
sqlite.py https://github.com/feast-dev/feast/pull/6659/files#diff-f45e0ee04fc45d6c884e713e4a00d76bb79193672292d93b3e5112f0bad63412
test_sqlite_plan.py https://github.com/feast-dev/feast/pull/6659/files#diff-d025b37dea1827e94f05528f7fe175872744c27b9337b474ab434ce7c0ce6ca6
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/online_stores/sqlite.pyhttps://github.com/feast-dev/feast/pull/6659/files#diff-f45e0ee04fc45d6c884e713e4a00d76bb79193672292d93b3e5112f0bad63412
View file https://github.com/casaar97/feast/blob/d97289166d0a0139bd19459a9dd0f03a5c001b38/sdk/python/feast/infra/online_stores/sqlite.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6659/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6659/files#diff-f45e0ee04fc45d6c884e713e4a00d76bb79193672292d93b3e5112f0bad63412
https://github.com/feast-dev/feast/pull/6659/files#diff-f45e0ee04fc45d6c884e713e4a00d76bb79193672292d93b3e5112f0bad63412
https://github.com/feast-dev/feast/pull/6659/files#diff-f45e0ee04fc45d6c884e713e4a00d76bb79193672292d93b3e5112f0bad63412
https://github.com/feast-dev/feast/pull/6659/files#diff-f45e0ee04fc45d6c884e713e4a00d76bb79193672292d93b3e5112f0bad63412
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/infra/online_store/test_sqlite_plan.pyhttps://github.com/feast-dev/feast/pull/6659/files#diff-d025b37dea1827e94f05528f7fe175872744c27b9337b474ab434ce7c0ce6ca6
View file https://github.com/casaar97/feast/blob/d97289166d0a0139bd19459a9dd0f03a5c001b38/sdk/python/tests/unit/infra/online_store/test_sqlite_plan.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6659/{{ revealButtonHref }}
Please reload this pagehttps://github.com/feast-dev/feast/pull/6659/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.