René's URL Explorer Experiment


Title: fix: Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock by casaar97 · Pull Request #6648 · feast-dev/feast · GitHub

Open Graph Title: fix: Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock by casaar97 · Pull Request #6648 · feast-dev/feast

X Title: fix: Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock by casaar97 · Pull Request #6648 · feast-dev/feast

Description: Fixes #6647 Summary feast_metrics.start_metrics_server() starts a feature-freshness thread in the Gunicorn master process, before Gunicorn forks its worker(s). That thread's first action, with no delay, is update_feature_freshness() → store.list_feature_views(), which lazily builds the registry for the first time. For registry backends needing a lazy DBAPI import (e.g. the SQL registry importing pymysql via SQLAlchemy's create_engine()), this means a thread in the master can be mid-import, holding CPython's per-module import lock, at the exact moment Gunicorn forks a worker. POSIX fork() only duplicates the calling thread into the child process; every other thread in the parent, including this one, simply ceases to exist in the worker. If the fork lands while that thread holds a module's import lock, the lock stays permanently held in the new worker, since there is no longer any thread that can finish the import and release it. The worker's own later attempt to build its registry then deadlocks forever with no error - the process just hangs at "Waiting for application startup.". This is intermittent by nature: it only manifests if the fork lands inside that narrow timing window (see #6647 for the full write-up, including a live py-spy stack trace confirming the exact mechanism). Resource monitoring already avoids this correctly (start_resource_monitoring=not uses_gunicorn plus the post_worker_init hook calling init_worker_monitoring()), but the freshness thread wasn't given the same treatment. This PR applies the identical, already-established pattern: start_metrics_server() gains a start_freshness_monitoring flag, deferred exactly like start_resource_monitoring already is. A new init_worker_freshness_monitoring(store) mirrors init_worker_monitoring(). FeastServeApplication's post_worker_init hook now also calls init_worker_freshness_monitoring(store) after the fork (via a closure capturing store, since the freshness thread needs the store reference, unlike resource monitoring). Test plan Added TestInitWorkerFreshnessMonitoring covering that the new function starts/doesn't start the thread based on the freshness config flag, mirroring the existing init_worker_monitoring behavior. Added test_freshness_monitoring_deferred_same_as_resource_monitoring to TestMetricsYamlConfig, asserting start_freshness_monitoring is always passed identically to start_resource_monitoring from start_server() - a regression guard so this can't silently drift out of sync again. sdk/python/tests/unit/test_metrics.py (89 tests) and sdk/python/tests/unit/test_feature_server.py / test_feature_server_utils.py (92 tests) pass locally. ruff check / ruff format --check pass on all changed files.

Open Graph Description: Fixes #6647 Summary feast_metrics.start_metrics_server() starts a feature-freshness thread in the Gunicorn master process, before Gunicorn forks its worker(s). That thread's first action, with ...

X Description: Fixes #6647 Summary feast_metrics.start_metrics_server() starts a feature-freshness thread in the Gunicorn master process, before Gunicorn forks its worker(s). That thread's first action, w...

Opengraph URL: https://github.com/feast-dev/feast/pull/6648

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0686d82a-2239-8280-baeb-e4ac2bea4d0c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB088:2D5FDF:E7C344:132C318:6AFE98AB
html-safe-noncee12603fc4e91206adc8549de446187a2e32fe53abb8770a654f3a0f27f9cbb1e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDg4OjJENUZERjpFN0MzNDQ6MTMyQzMxODo2QUZFOThBQiIsInZpc2l0b3JfaWQiOiI1MTA4Njc3ODIxNTc2NjgxNjQzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac281325a02f363589c53a7f75796da08a2e2557a4ccb8cb90dd3cea7b3010cdb0
hovercard-subject-tagpull_request:4142788204
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6648/files
twitter:imagehttps://avatars.githubusercontent.com/u/22341152?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/22341152?s=400&v=4
og:image:altFixes #6647 Summary feast_metrics.start_metrics_server() starts a feature-freshness thread in the Gunicorn master process, before Gunicorn forks its worker(s). That thread's first action, with ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6648/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6648%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6648%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6648/files
Reloadhttps://github.com/feast-dev/feast/pull/6648/files
Reloadhttps://github.com/feast-dev/feast/pull/6648/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
jyejarehttps://github.com/jyejare
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
casaar97:fix/freshness-thread-postfork-deadlockhttps://github.com/casaar97/feast/tree/fix/freshness-thread-postfork-deadlock
Conversation 3 https://github.com/feast-dev/feast/pull/6648
Commits 1 https://github.com/feast-dev/feast/pull/6648/commits
Checks 27 https://github.com/feast-dev/feast/pull/6648/checks
Files changed https://github.com/feast-dev/feast/pull/6648/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6648/files
fix: Defer feature-freshness thread to post-fork to avoid Gunicorn deadlock https://github.com/feast-dev/feast/pull/6648/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6648/files
5376751 fix: Defer feature-freshness thread to post-fork to avoid Gunicorn de… Jul 27, 2026 https://github.com/feast-dev/feast/pull/6648/commits/537675154ff8351f05c1c5dfff79adff7a6ede73
Clear filters https://github.com/feast-dev/feast/pull/6648/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6648/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6648/files
feature_server.py https://github.com/feast-dev/feast/pull/6648/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
metrics.py https://github.com/feast-dev/feast/pull/6648/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
test_feature_server.py https://github.com/feast-dev/feast/pull/6648/files#diff-28c8f509b5d19e3c5c6ffe15fa5d7bac9a945beebfefc6cb904df0ca2799c18a
test_metrics.py https://github.com/feast-dev/feast/pull/6648/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/feature_server.pyhttps://github.com/feast-dev/feast/pull/6648/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
View file https://github.com/casaar97/feast/blob/537675154ff8351f05c1c5dfff79adff7a6ede73/sdk/python/feast/feature_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6648/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6648/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/6648/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/6648/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/6648/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/6648/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/6648/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/pull/6648/files#diff-47bf85967b55f577ebd4586f9a93f2cc0c9433270bd67b21ddb33e89fd464167
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/metrics.pyhttps://github.com/feast-dev/feast/pull/6648/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
View file https://github.com/casaar97/feast/blob/537675154ff8351f05c1c5dfff79adff7a6ede73/sdk/python/feast/metrics.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6648/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6648/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6648/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6648/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6648/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/pull/6648/files#diff-e8e6fa91f6e18135b2a3d38dc06b1dc86f3dfdba4599b4c717db58666360d704
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_feature_server.pyhttps://github.com/feast-dev/feast/pull/6648/files#diff-28c8f509b5d19e3c5c6ffe15fa5d7bac9a945beebfefc6cb904df0ca2799c18a
View file https://github.com/casaar97/feast/blob/537675154ff8351f05c1c5dfff79adff7a6ede73/sdk/python/tests/unit/test_feature_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6648/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6648/files#diff-28c8f509b5d19e3c5c6ffe15fa5d7bac9a945beebfefc6cb904df0ca2799c18a
https://github.com/feast-dev/feast/pull/6648/files#diff-28c8f509b5d19e3c5c6ffe15fa5d7bac9a945beebfefc6cb904df0ca2799c18a
https://github.com/feast-dev/feast/pull/6648/files#diff-28c8f509b5d19e3c5c6ffe15fa5d7bac9a945beebfefc6cb904df0ca2799c18a
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_metrics.pyhttps://github.com/feast-dev/feast/pull/6648/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
View file https://github.com/casaar97/feast/blob/537675154ff8351f05c1c5dfff79adff7a6ede73/sdk/python/tests/unit/test_metrics.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6648/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6648/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/pull/6648/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/pull/6648/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
https://github.com/feast-dev/feast/pull/6648/files#diff-2ef2173e03f5713a514f045083032e2a4427222baba628f0273ff5cd1fbc19b6
Please reload this pagehttps://github.com/feast-dev/feast/pull/6648/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.