René's URL Explorer Experiment


Title: fix: Avoid importing feast.feature_store at mcp_server import time by larrysingleton007 · Pull Request #6634 · feast-dev/feast · GitHub

Open Graph Title: fix: Avoid importing feast.feature_store at mcp_server import time by larrysingleton007 · Pull Request #6634 · feast-dev/feast

X Title: fix: Avoid importing feast.feature_store at mcp_server import time by larrysingleton007 · Pull Request #6634 · feast-dev/feast

Description: What this PR does / why we need it: feast/infra/mcp_servers/mcp_server.py imported feast.feature_store.FeatureStore at module load, but used it only for a type annotation on add_mcp_support_to_app. Because the feast.infra.mcp_servers package __init__ eagerly imports mcp_server, importing the package pulled the entire feature_store import graph in as a side effect. Under parallel unit-test collection (pytest -n), that heavy import intermittently raced with an in-progress feature_store import and failed collection of tests/unit/infra/feature_servers/test_mcp_server.py with KeyError: 'feast.infra.mcp_servers.mcp_server'. The tests pass in isolation, so it shows up as a flaky unit-test-python failure. Moving the import under TYPE_CHECKING with a forward-reference annotation removes feature_store from mcp_server's module-load path, so importing mcp_server no longer triggers that graph. Public API and the annotation are unchanged. Which issue(s) this PR fixes: Fixes #6633 Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change test_mcp_server.py passes (23), and feast.infra.mcp_servers still exposes add_mcp_support_to_app and McpFeatureServerConfig. ruff and mypy clean. Misc Release note: NONE. As an outside contributor I can't apply labels, so a maintainer will need to add kind/bug and run ok-to-test.

Open Graph Description: What this PR does / why we need it: feast/infra/mcp_servers/mcp_server.py imported feast.feature_store.FeatureStore at module load, but used it only for a type annotation on add_mcp_support_to_app....

X Description: What this PR does / why we need it: feast/infra/mcp_servers/mcp_server.py imported feast.feature_store.FeatureStore at module load, but used it only for a type annotation on add_mcp_support_to_app....

Opengraph URL: https://github.com/feast-dev/feast/pull/6634

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:954935b8-63b0-b3c1-dc9f-dcd2a4fe751e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A04:84C13:100F705:153C60B:6AFE9E4E
html-safe-nonceec3f6f8f045b12cb32d823e8934f9d18f9decf29918ebd373b63d0075e3b479d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTA0Ojg0QzEzOjEwMEY3MDU6MTUzQzYwQjo2QUZFOUU0RSIsInZpc2l0b3JfaWQiOiIyMDE4ODY1OTEwNjA4OTkzODcwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac69dffc0004185cf8b33ba09a35efd95df052b748f72b3e5a27508c4035bdc425
hovercard-subject-tagpull_request:4113467692
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6634/files
twitter:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
og:image:altWhat this PR does / why we need it: feast/infra/mcp_servers/mcp_server.py imported feast.feature_store.FeatureStore at module load, but used it only for a type annotation on add_mcp_support_to_app....
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6634/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6634%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6634%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6634/files
Reloadhttps://github.com/feast-dev/feast/pull/6634/files
Reloadhttps://github.com/feast-dev/feast/pull/6634/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:fix/mcp-server-import-flakehttps://github.com/larrysingleton007/feast/tree/fix/mcp-server-import-flake
Conversation 1 https://github.com/feast-dev/feast/pull/6634
Commits 1 https://github.com/feast-dev/feast/pull/6634/commits
Checks 23 https://github.com/feast-dev/feast/pull/6634/checks
Files changed https://github.com/feast-dev/feast/pull/6634/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634/files
fix: Avoid importing feast.feature_store at mcp_server import time https://github.com/feast-dev/feast/pull/6634/files#top
Show all changes 1 commit https://github.com/feast-dev/feast/pull/6634/files
47c89b6 fix: Avoid importing feast.feature_store at mcp_server import time larrysingleton007 Jul 23, 2026 https://github.com/feast-dev/feast/pull/6634/commits/47c89b632ecc1a0554ee2489870978261e088268
Clear filters https://github.com/feast-dev/feast/pull/6634/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634/files
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/infra/mcp_servers/mcp_server.pyhttps://github.com/feast-dev/feast/pull/6634/files#diff-de25749bfc4240bbd1f157571567fe01c27bfe4be2824dc37b1ba34279783677
View file https://github.com/larrysingleton007/feast/blob/47c89b632ecc1a0554ee2489870978261e088268/sdk/python/feast/infra/mcp_servers/mcp_server.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6634/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6634/files#diff-de25749bfc4240bbd1f157571567fe01c27bfe4be2824dc37b1ba34279783677
https://github.com/feast-dev/feast/pull/6634/files#diff-de25749bfc4240bbd1f157571567fe01c27bfe4be2824dc37b1ba34279783677
https://github.com/feast-dev/feast/pull/6634/files#diff-de25749bfc4240bbd1f157571567fe01c27bfe4be2824dc37b1ba34279783677
https://github.com/feast-dev/feast/pull/6634/files#diff-de25749bfc4240bbd1f157571567fe01c27bfe4be2824dc37b1ba34279783677
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.