René's URL Explorer Experiment


Title: fix: Avoid importing feast.feature_store at mcp_server import time by larrysingleton007 · Pull Request #6634 · feast-dev/feast · GitHub

Open Graph Title: fix: Avoid importing feast.feature_store at mcp_server import time by larrysingleton007 · Pull Request #6634 · feast-dev/feast

X Title: fix: Avoid importing feast.feature_store at mcp_server import time by larrysingleton007 · Pull Request #6634 · feast-dev/feast

Description: The Open Source Feature Store for AI/ML. Contribute to feast-dev/feast development by creating an account on GitHub.

Open Graph Description: What this PR does / why we need it: feast/infra/mcp_servers/mcp_server.py imported feast.feature_store.FeatureStore at module load, but used it only for a type annotation on add_mcp_support_to_app....

X Description: What this PR does / why we need it: feast/infra/mcp_servers/mcp_server.py imported feast.feature_store.FeatureStore at module load, but used it only for a type annotation on add_mcp_support_to_app....

Opengraph URL: https://github.com/feast-dev/feast/pull/6634

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6c273f0e-a16e-2f17-5d59-b1fa8259d22a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D6E:2BC66C:EEEA80:1476BA8:6AFE980E
html-safe-noncef6e244ef837be3fd54bc0057c1d5c42a2eb3182f6bacdded44d96d81f6272e7d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDZFOjJCQzY2QzpFRUVBODA6MTQ3NkJBODo2QUZFOTgwRSIsInZpc2l0b3JfaWQiOiIzNjY4NzE5Mzc4MDYxNDU1NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca0c0c75b0880ace4740fcf696d9c15ed8cb9c750c59420bab476da2571de9522
hovercard-subject-tagpull_request:4113467692
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/6634/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0954b5dcd65611bbe588f4e031acc16b0a6bca69923035e0c5fb0e1ede33f2b2/feast-dev/feast/pull/6634
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0954b5dcd65611bbe588f4e031acc16b0a6bca69923035e0c5fb0e1ede33f2b2/feast-dev/feast/pull/6634
og:image:altWhat this PR does / why we need it: feast/infra/mcp_servers/mcp_server.py imported feast.feature_store.FeatureStore at module load, but used it only for a type annotation on add_mcp_support_to_app....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelarrysingleton007
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-cache
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6634#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6634
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6634
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6634
Reloadhttps://github.com/feast-dev/feast/pull/6634
Reloadhttps://github.com/feast-dev/feast/pull/6634
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
https://github.com/feast-dev/feast
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:fix/mcp-server-import-flakehttps://github.com/larrysingleton007/feast/tree/fix/mcp-server-import-flake
Conversationhttps://github.com/feast-dev/feast/pull/6634
Commits1 (1)https://github.com/feast-dev/feast/pull/6634/commits
Checkshttps://github.com/feast-dev/feast/pull/6634/checks
Files changedhttps://github.com/feast-dev/feast/pull/6634/files
fix: Avoid importing feast.feature_store at mcp_server import timehttps://github.com/feast-dev/feast/pull/6634#top
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:fix/mcp-server-import-flakehttps://github.com/larrysingleton007/feast/tree/fix/mcp-server-import-flake
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
Jul 23, 2026https://github.com/feast-dev/feast/pull/6634#issue-4955206940
#6633https://github.com/feast-dev/feast/issues/6633
conventional commitshttps://www.conventionalcommits.org/
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
code ownerhttps://github.com/feast-dev/feast/blob/54da19a8d55b323b305b9c224ace2e73a7531fdf/CODEOWNERS#L10
July 23, 2026 03:46https://github.com/feast-dev/feast/pull/6634#event-28361258878
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
Jul 23, 2026 https://github.com/feast-dev/feast/pull/6634#ref-pullrequest-4952471791
fix: Support Entra ID (Azure AD) token claims in OIDC auth #6631 https://github.com/feast-dev/feast/pull/6631
https://github.com/codecov-commenter
codecov-commenterhttps://github.com/codecov-commenter
Jul 23, 2026https://github.com/feast-dev/feast/pull/6634#issuecomment-5054181382
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634
https://private-user-images.githubusercontent.com/152432831/340411587-e90313f4-9d3a-4b63-8b54-cfe14e7ec20d.svg?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3OTUwNzAyNjYsIm5iZiI6MTc5NTA2OTk2NiwicGF0aCI6Ii8xNTI0MzI4MzEvMzQwNDExNTg3LWU5MDMxM2Y0LTlkM2EtNGI2My04YjU0LWNmZTE0ZTdlYzIwZC5zdmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYxMTE5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MTExOVQwNjMyNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZWQ5YmRhMjUwZTMwZDQ1ZWFhN2VlMzliNjk5ODE3OWM3ODkwMDcyZTVjNzQ2NDc3YWNiMjVhMDRjYmIzOTQ5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZzdmclMkJ4bWwifQ.xfw6gFWxIpCHK_RXHIFqap1swEb7CZBOXk2ulT_wK_A
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6634?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
7ae64echttps://app.codecov.io/gh/feast-dev/feast/commit/7ae64ec4471d197fb591a244da2e44d7bb19a760?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
47c89b6https://app.codecov.io/gh/feast-dev/feast/commit/47c89b632ecc1a0554ee2489870978261e088268?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecov GitHub apphttps://github.com/apps/codecov/installations/select_target
https://app.codecov.io/gh/feast-dev/feast/pull/6634?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Flaghttps://app.codecov.io/gh/feast-dev/feast/pull/6634/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
go-feature-serverhttps://app.codecov.io/gh/feast-dev/feast/pull/6634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
python-unithttps://app.codecov.io/gh/feast-dev/feast/pull/6634/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Files with missing lineshttps://app.codecov.io/gh/feast-dev/feast/pull/6634?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
sdk/python/feast/infra/mcp_servers/mcp_server.pyhttps://app.codecov.io/gh/feast-dev/feast/pull/6634?src=pr&el=tree&filepath=sdk%2Fpython%2Ffeast%2Finfra%2Fmcp_servers%2Fmcp_server.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c2RrL3B5dGhvbi9mZWFzdC9pbmZyYS9tY3Bfc2VydmVycy9tY3Bfc2VydmVyLnB5
Continue to review full report in Codecov by Harnesshttps://app.codecov.io/gh/feast-dev/feast/pull/6634?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Click here to learn morehttps://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Codecovhttps://app.codecov.io/gh/feast-dev/feast/pull/6634?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
7ae64ec...47c89b6https://app.codecov.io/gh/feast-dev/feast/pull/6634?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
comment docshttps://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None
Test Analyticshttps://docs.codecov.com/docs/test-analytics
JS Bundle Analysishttps://docs.codecov.com/docs/javascript-bundle-analysis
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Jul 23, 2026https://github.com/feast-dev/feast/pull/6634#event-28362656842
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
Jul 23, 2026 https://github.com/feast-dev/feast/pull/6634#pullrequestreview-4760811680
View reviewed changes https://github.com/feast-dev/feast/pull/6634/files/47c89b632ecc1a0554ee2489870978261e088268
https://github.com/larrysingleton007
https://github.com/ntkathole
fix: Avoid importing feast.feature_store at mcp_server import timehttps://github.com/feast-dev/feast/pull/6634/commits/47c89b632ecc1a0554ee2489870978261e088268
47c89b6https://github.com/feast-dev/feast/pull/6634/commits/47c89b632ecc1a0554ee2489870978261e088268
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
force-pushedhttps://github.com/feast-dev/feast/compare/9578b51324e29e7a46fd7b7dc6021fee03e4d89f..47c89b632ecc1a0554ee2489870978261e088268
9578b51https://github.com/feast-dev/feast/commit/9578b51324e29e7a46fd7b7dc6021fee03e4d89f
47c89b6https://github.com/feast-dev/feast/commit/47c89b632ecc1a0554ee2489870978261e088268
Compare https://github.com/feast-dev/feast/compare/9578b51324e29e7a46fd7b7dc6021fee03e4d89f..47c89b632ecc1a0554ee2489870978261e088268
July 23, 2026 10:11https://github.com/feast-dev/feast/pull/6634#event-28375647374
https://github.com/ntkathole
ntkatholehttps://github.com/ntkathole
ddb2e9ahttps://github.com/feast-dev/feast/commit/ddb2e9ad54d06ed2fd4035d51de6da9729ca7293
Jul 23, 2026https://github.com/feast-dev/feast/pull/6634#event-28375654058
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634
https://github.com/larrysingleton007
larrysingleton007https://github.com/larrysingleton007
July 23, 2026 13:29https://github.com/feast-dev/feast/pull/6634#event-28384330180
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6634
https://github.com/ntkathole
ntkathole https://github.com/ntkathole
https://github.com/feast-dev/feast/pull/6634/files/47c89b632ecc1a0554ee2489870978261e088268
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634
ok-to-test https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aok-to-test
Flaky unit-test collection: KeyError importing feast.infra.mcp_servers.mcp_server under pytest -n https://github.com/feast-dev/feast/issues/6633
Please reload this pagehttps://github.com/feast-dev/feast/pull/6634
https://github.com/larrysingleton007
https://github.com/codecov-commenter
https://github.com/ntkathole
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.