René's URL Explorer Experiment


Title: fix: Support Entra ID (Azure AD) token claims in OIDC auth by larrysingleton007 · Pull Request #6631 · feast-dev/feast · GitHub

Open Graph Title: fix: Support Entra ID (Azure AD) token claims in OIDC auth by larrysingleton007 · Pull Request #6631 · feast-dev/feast

X Title: fix: Support Entra ID (Azure AD) token claims in OIDC auth by larrysingleton007 · Pull Request #6631 · feast-dev/feast

Description: What this PR does / why we need it: The OIDC token parser is written against Keycloak's token shape, and that breaks Microsoft Entra ID (Azure AD) in two independent places. Username extraction accepted only preferred_username or upn. Entra client-credentials (app-only) tokens carry neither, so every machine-to-machine caller was rejected at authentication. This falls back to the calling application's own identity when no human claim is present: azp on v2 tokens, appid on v1, then sub, which every issuer sets. A claim that is present but null or non-string is skipped rather than returned, and a token providing none of the five claims as a string still raises AuthenticationError. Roles were read only from Keycloak's nested resource_access..roles. Entra puts app roles in the top-level roles claim, so the extracted list was always empty and RoleBasedPolicy never matched. This merges the top-level claim into the existing extraction, preserving order and dropping duplicates. Keycloak's default behavior is unchanged: the username fallbacks only fire when preferred_username and upn are both absent, the merge only adds roles, and token validation (signature and expiry) is untouched. One behavior change worth calling out for existing deployments: role resolution now also reads the top-level roles claim for every issuer, not only Entra. An installation whose IdP already emits a top-level roles claim (for example a Keycloak realm with a custom mapper) will see those roles merged into the user's Feast roles. The Keycloak resource_access..roles path itself is unchanged. We run this exact change against an Entra tenant in production as a build-time patch on 0.64. Which issue(s) this PR fixes: Fixes #6630. Supersedes #4934, which requested the roles half and was closed stale. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change New unit tests in sdk/python/tests/unit/permissions/auth/test_token_parser.py cover: preferred_username and upn precedence over the application claims (including directly against appid/sub); azp-only, appid-only, and sub-only tokens each authenticating with that value; tokens whose only identity claims are null or non-string still raising; top-level roles extracted on their own; Keycloak resource_access roles still working; the de-duplicated merge when both shapes are present, including duplicates within the top-level claim; and that identity and roles are read from the signature-verified decode rather than the unverified routing decode. Misc Release note: OIDC authentication now accepts Microsoft Entra ID (Azure AD) tokens. The username falls back to azp, appid, or sub for client-credentials (app-only) tokens, and app roles in the top-level roles claim are merged with Keycloak's resource_access..roles. The PR template here does not have an auto-generated release-note field, so the note is inline above. I can't apply labels as an outside contributor, so a maintainer will need to add kind/bug (and ok-to-test for CI). The last two test: commits are self-contained (a fidelity test plus a fixture extraction) and can be dropped without affecting the fix if a smaller diff is preferred.

Open Graph Description: What this PR does / why we need it: The OIDC token parser is written against Keycloak's token shape, and that breaks Microsoft Entra ID (Azure AD) in two independent places. Username extraction...

X Description: What this PR does / why we need it: The OIDC token parser is written against Keycloak's token shape, and that breaks Microsoft Entra ID (Azure AD) in two independent places. Username extrac...

Opengraph URL: https://github.com/feast-dev/feast/pull/6631

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a7bc5f63-886f-8633-d73e-4c6095f51045
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDC6:FB32B:2FB9AF:4282FC:6AFE99C5
html-safe-nonce6f6af852af1d1f3aedf30e675ecc9ccc05fe295790c5a28e4462cce81edf8aaf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREM2OkZCMzJCOjJGQjlBRjo0MjgyRkM6NkFGRTk5QzUiLCJ2aXNpdG9yX2lkIjoiMTM0MDk5NDAzOTc3OTg1ODg4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf7e647c49c446e02656720df13abd53f24e79d50be45f3523824d8f70c33b18f
hovercard-subject-tagpull_request:4111166688
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6631/files
twitter:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/166439969?s=400&v=4
og:image:altWhat this PR does / why we need it: The OIDC token parser is written against Keycloak's token shape, and that breaks Microsoft Entra ID (Azure AD) in two independent places. Username extraction...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6631/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6631%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6631%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6631/files
Reloadhttps://github.com/feast-dev/feast/pull/6631/files
Reloadhttps://github.com/feast-dev/feast/pull/6631/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
larrysingleton007:fix/6630-entra-id-oidc-claimshttps://github.com/larrysingleton007/feast/tree/fix/6630-entra-id-oidc-claims
Conversation 15 https://github.com/feast-dev/feast/pull/6631
Commits 7 https://github.com/feast-dev/feast/pull/6631/commits
Checks 23 https://github.com/feast-dev/feast/pull/6631/checks
Files changed https://github.com/feast-dev/feast/pull/6631/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6631/files
fix: Support Entra ID (Azure AD) token claims in OIDC auth https://github.com/feast-dev/feast/pull/6631/files#top
Show all changes 7 commits https://github.com/feast-dev/feast/pull/6631/files
5e9c95b fix: Support Entra ID (Azure AD) token claims in OIDC auth larrysingleton007 Jul 22, 2026 https://github.com/feast-dev/feast/pull/6631/commits/5e9c95b635af03c219e3035dd88f88709ed74449
0e55185 docs: Document Entra ID claim support in OIDC authorization larrysingleton007 Jul 22, 2026 https://github.com/feast-dev/feast/pull/6631/commits/0e551851e0109f6a2e0ec02e81f3a1dce9364872
2f52a80 fix: Harden Entra ID OIDC claim handling from review larrysingleton007 Jul 22, 2026 https://github.com/feast-dev/feast/pull/6631/commits/2f52a80753529fd70b98fb0ae00e4f1948c7fbb1
0c689db docs: Add Entra ID token example and group-claim caveat larrysingleton007 Jul 22, 2026 https://github.com/feast-dev/feast/pull/6631/commits/0c689db850725b86ac1918de16689a2d5ad07c24
06afa5b test: Cover OIDC verified-decode sourcing and trim redundant asserts larrysingleton007 Jul 22, 2026 https://github.com/feast-dev/feast/pull/6631/commits/06afa5b000e0c496bf5f31d7b0324b923be253a0
456f740 test: Extract shared OIDC discovery and signing-key fixtures larrysingleton007 Jul 22, 2026 https://github.com/feast-dev/feast/pull/6631/commits/456f740245cb9b2c82a42e38cea91c829f4d964f
4b4c564 fix: Address review nitpicks on Entra OIDC PR larrysingleton007 Jul 23, 2026 https://github.com/feast-dev/feast/pull/6631/commits/4b4c564325c469db248e928ea97cbe15baad62bf
Clear filters https://github.com/feast-dev/feast/pull/6631/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6631/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6631/files
authz_manager.md https://github.com/feast-dev/feast/pull/6631/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
oidc_token_parser.py https://github.com/feast-dev/feast/pull/6631/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
conftest.py https://github.com/feast-dev/feast/pull/6631/files#diff-2a94288ed0a04603d19febd5e48aadf05e92479657cb49d2bad92569faae1314
test_token_parser.py https://github.com/feast-dev/feast/pull/6631/files#diff-cdf3c6901065a40034b2c3dba67dd5171b9fa4551e6f63000bdedc4ee7990964
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L4
docs/getting-started/components/authz_manager.mdhttps://github.com/feast-dev/feast/pull/6631/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
View file https://github.com/larrysingleton007/feast/blob/4b4c564325c469db248e928ea97cbe15baad62bf/docs/getting-started/components/authz_manager.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6631/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6631/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
https://github.com/feast-dev/feast/pull/6631/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
https://github.com/feast-dev/feast/pull/6631/files#diff-69eb482f40654b0071c13601bd14999012b9fd4fdfece0e9f08764d9cffaf731
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/permissions/auth/oidc_token_parser.pyhttps://github.com/feast-dev/feast/pull/6631/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
View file https://github.com/larrysingleton007/feast/blob/4b4c564325c469db248e928ea97cbe15baad62bf/sdk/python/feast/permissions/auth/oidc_token_parser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6631/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6631/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
Please reload this pagehttps://github.com/feast-dev/feast/pull/6631/files
https://github.com/feast-dev/feast/pull/6631/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/pull/6631/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/pull/6631/files#diff-6ee6b90f59ccd6bbfd9c7ff898e9776807b83d81d203cad24fe509784bd85866
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/permissions/auth/conftest.pyhttps://github.com/feast-dev/feast/pull/6631/files#diff-2a94288ed0a04603d19febd5e48aadf05e92479657cb49d2bad92569faae1314
View file https://github.com/larrysingleton007/feast/blob/4b4c564325c469db248e928ea97cbe15baad62bf/sdk/python/tests/unit/permissions/auth/conftest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6631/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6631/files#diff-2a94288ed0a04603d19febd5e48aadf05e92479657cb49d2bad92569faae1314
https://github.com/feast-dev/feast/pull/6631/files#diff-2a94288ed0a04603d19febd5e48aadf05e92479657cb49d2bad92569faae1314
https://github.com/feast-dev/feast/pull/6631/files#diff-2a94288ed0a04603d19febd5e48aadf05e92479657cb49d2bad92569faae1314
Please reload this pagehttps://github.com/feast-dev/feast/pull/6631/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6631/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.