Title: chore: Remove unused jsonschema dependency, declare attrs by lukehsiao · Pull Request #6599 · feast-dev/feast · GitHub
Open Graph Title: chore: Remove unused jsonschema dependency, declare attrs by lukehsiao · Pull Request #6599 · feast-dev/feast
X Title: chore: Remove unused jsonschema dependency, declare attrs by lukehsiao · Pull Request #6599 · feast-dev/feast
Description: What this PR does / why we need it: jsonschema's last consumer was the pre-0.10 repo_config.py, which used it to validate feature_store.yaml. That file was rewritten on pydantic for the 0.10 release in April 2021, so the dependency has been carried unused for roughly five years, surviving the setup.py to pyproject.toml consolidation along the way. Dropping it exposed a real bug: feature_view_projection.py and openlineage/facets.py import attr directly, but attrs was never declared and only arrived transitively via jsonschema -> referencing -> attrs. A clean install without jsonschema fails at import feast. This patch declares attrs explicitly rather than migrating those files to stdlib dataclasses, which would change the runtime behavior of a core class and belongs in its own change. The lock files were recompiled preserving existing pins instead of with make lock-python-dependencies-all, which re-resolves everything to latest and would bury this removal in unrelated churn. jsonschema stays in the minimal and ci locks because mcp requires it; the base locks drop jsonschema, jsonschema-specifications, referencing, and rpds-py. The ci locks also pick up scylla-driver, which the ci extra has required since the ScyllaDB online store landed but was never locked. Tested: recompiled all 12 uv lock files with uv 0.9.25 targeting aarch64-apple-darwin (MACOSX_DEPLOYMENT_TARGET=15.0) to match the platform the checked-in locks were compiled on. The pybuild-deps build locks are untouched because the minimal-sdist package set is unchanged. In a fresh py3.12 venv, feast installs without jsonschema, import feast succeeds, and feast init followed by feast apply works end to end. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Unit tests Integration tests Manual tests Testing is not required for this change
Open Graph Description: What this PR does / why we need it: jsonschema's last consumer was the pre-0.10 repo_config.py, which used it to validate feature_store.yaml. That file was rewritten on pydantic for the 0.10 re...
X Description: What this PR does / why we need it: jsonschema's last consumer was the pre-0.10 repo_config.py, which used it to validate feature_store.yaml. That file was rewritten on pydantic for the 0.1...
Opengraph URL: https://github.com/feast-dev/feast/pull/6599
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8a7d9254-649a-bb2a-ed67-12c0ab6736fe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A43E:199BE7:4747F:5DABA:6A567365 |
| html-safe-nonce | e3c67f5f625a8ecf57b702c1f0878a8cae0713a589fa6e055ce3187cf718707e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDNFOjE5OUJFNzo0NzQ3Rjo1REFCQTo2QTU2NzM2NSIsInZpc2l0b3JfaWQiOiIyMjU2ODU3OTY4Mzg5MDI2NjYxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e9d6483606c8e73d6660f13d3d262ab048c8f52a83ed6b37e1ef38b2ba2d3b86 |
| hovercard-subject-tag | pull_request:4040083356 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6599/files |
| twitter:image | https://avatars.githubusercontent.com/u/7573542?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7573542?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: jsonschema's last consumer was the pre-0.10 repo_config.py, which used it to validate feature_store.yaml. That file was rewritten on pydantic for the 0.10 re... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 19b5ee9431dcfce15ab4b001d626e4e3a6ba1acb7be814813a52bbebd9a86ef5 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | afc01ffdb045f4ff81c6122091366ade7b6166b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width