Title: fix: Use configured timestamp column names in RemoteOnlineStore.online_write_batch by franciscojavierarceo · Pull Request #6596 · feast-dev/feast · GitHub
Open Graph Title: fix: Use configured timestamp column names in RemoteOnlineStore.online_write_batch by franciscojavierarceo · Pull Request #6596 · feast-dev/feast
X Title: fix: Use configured timestamp column names in RemoteOnlineStore.online_write_batch by franciscojavierarceo · Pull Request #6596 · feast-dev/feast
Description: Summary RemoteOnlineStore.online_write_batch hardcoded "event_timestamp" and "created" as column names when building the request body for the feature server. The server-side _convert_arrow_fv_to_proto resolves columns by the feature view's configured batch_source.timestamp_field and batch_source.created_timestamp_column. When those differ from the hardcoded defaults (e.g. "created_at"), the server throws a KeyError. Now uses the feature view's configured column names, falling back to the previous defaults when unset. Adds 3 unit tests covering default columns, custom columns, and empty created_timestamp_column fallback. Closes #6595 Test plan Existing 22 tests in test_remote_online_store.py still pass New TestRemoteOnlineStoreWriteBatch tests verify: Default column names (event_timestamp, created) are used when configured Custom column names (ts, created_at) appear in the request body instead of hardcoded defaults Empty created_timestamp_column falls back to "created" Integration test with a remote feature server and a feature view using non-default timestamp columns 🤖 Generated with Claude Code
Open Graph Description: Summary RemoteOnlineStore.online_write_batch hardcoded "event_timestamp" and "created" as column names when building the request body for the feature server. The server-side _c...
X Description: Summary RemoteOnlineStore.online_write_batch hardcoded "event_timestamp" and "created" as column names when building the request body for the feature server. Th...
Opengraph URL: https://github.com/feast-dev/feast/pull/6596
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:be5c5d0a-efa8-71a0-d7d4-41e048fdcde5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA78:B0BAA:D2D445:11C86B1:6A516954 |
| html-safe-nonce | 039c5611172d18fe7e84e537e02227401b8d1896a5f68ff449328a2ed0568bad |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTc4OkIwQkFBOkQyRDQ0NToxMUM4NkIxOjZBNTE2OTU0IiwidmlzaXRvcl9pZCI6IjU4ODY0NTIwOTYyODMyNzM1NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0ee1bc1dfe6fedc14644d9b9d757114e32660b9c14ed1a34ad75e1b7def416b8 |
| hovercard-subject-tag | pull_request:4024033410 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6596/files |
| twitter:image | https://avatars.githubusercontent.com/u/4163062?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4163062?s=400&v=4 |
| og:image:alt | Summary RemoteOnlineStore.online_write_batch hardcoded "event_timestamp" and "created" as column names when building the request body for the feature server. The server-side _c... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 60eaaf6d4dbaa817031b556aebd8a0a7eeb81b97 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width