Title: fix(operator): Only deploy an online store when it is declared by nikolauspschuetz · Pull Request #6591 · feast-dev/feast · GitHub
Open Graph Title: fix(operator): Only deploy an online store when it is declared by nikolauspschuetz · Pull Request #6591 · feast-dev/feast
X Title: fix(operator): Only deploy an online store when it is declared by nikolauspschuetz · Pull Request #6591 · feast-dev/feast
Description: Closes #6586. Problem The Feast operator always deployed an online store service (including a serving pod), even when the FeatureStore CR did not declare spec.services.onlineStore. This makes it impossible to run a standalone registry or offline store (e.g. the documented federated / shared-registry pattern), and is inconsistent with how registry and offlineStore behave — both are only defaulted when declared. Cause In ApplyDefaultsToStatus (infra/feast-operator/internal/controller/services/util.go), the online-store block force-created the service when nil: if services.OnlineStore == nil { services.OnlineStore = &feastdevv1.OnlineStore{} } // ...defaults always applied... whereas registry and offlineStore are gated behind if services.X != nil. Fix Gate the online-store defaulting behind services.OnlineStore != nil, mirroring the two sibling services. A declared online store still receives all of its defaults (persistence, path, PVC, server, container configs). Tests Added util_test.go with two specs for ApplyDefaultsToStatus: a CR without an online store → Status.Applied.Services.OnlineStore stays nil (fails on master, passes with this change), a CR that declares an online store → it still receives its defaults. Verified with KUBEBUILDER_ASSETS=... go test ./internal/controller/services/ (envtest 1.31.0); go build ./..., go vet, and gofmt are clean. The existing controller tests are unaffected because they declare onlineStore explicitly.
Open Graph Description: Closes #6586. Problem The Feast operator always deployed an online store service (including a serving pod), even when the FeatureStore CR did not declare spec.services.onlineStore. This makes it im...
X Description: Closes #6586. Problem The Feast operator always deployed an online store service (including a serving pod), even when the FeatureStore CR did not declare spec.services.onlineStore. This makes it im...
Opengraph URL: https://github.com/feast-dev/feast/pull/6591
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:3a2462e5-054f-27e3-1ec9-e7d386640406 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A5C:1BCBE4:5AEF96:8157A0:6A50FDF0 |
| html-safe-nonce | 714fbd0404e6fdd31a40f7f59d49e42a5d73ffc29e91352c93e9f6dbce81e223 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTVDOjFCQ0JFNDo1QUVGOTY6ODE1N0EwOjZBNTBGREYwIiwidmlzaXRvcl9pZCI6IjU2OTE0MjczOTgxMjc1MTcxNjgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d6808665a7c334f5453100dc867d21af734de9eb332183e54bd482480eefb715 |
| hovercard-subject-tag | pull_request:4019271172 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6591/files |
| twitter:image | https://avatars.githubusercontent.com/u/8151217?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8151217?s=400&v=4 |
| og:image:alt | Closes #6586. Problem The Feast operator always deployed an online store service (including a serving pod), even when the FeatureStore CR did not declare spec.services.onlineStore. This makes it im... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5266e58c17a510c403505cc811606465e90a881d2007ee7df1c4800d5c659838 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8d836581d020676cc0ef4a83cd2fe17e4af02c3d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width