Title: feat: Apply Intermediate TLS defaults on API fallback and handle transient errors by ugiordan · Pull Request #6587 · feast-dev/feast · GitHub
Open Graph Title: feat: Apply Intermediate TLS defaults on API fallback and handle transient errors by ugiordan · Pull Request #6587 · feast-dev/feast
X Title: feat: Apply Intermediate TLS defaults on API fallback and handle transient errors by ugiordan · Pull Request #6587 · feast-dev/feast
Description: What this PR does / why we need it: Follow-up to #6567. Fixes two issues in the TLS profile integration: Else-only pattern: NewTLSConfigFromProfile was only called in the success branch of the TLS profile fetch. On any error path (non-OpenShift cluster, resource not found), no TLS config was applied, leaving the operator running with Go's bare defaults (no MinVersion, no cipher restrictions). This PR moves NewTLSConfigFromProfile outside the if/else and explicitly falls back to configv1.TLSProfiles[TLSProfileIntermediateType] on all error paths. No transient error handling: The error switch only handled IsNotFound and IsNoMatchError. Transient API errors (ServiceUnavailable, Timeout, TooManyRequests) hit the default case and crashed the operator with os.Exit(1). This PR adds a dedicated case for these errors with a graceful Intermediate fallback. tlsProfileFetched is set to true so the SecurityProfileWatcher self-heals when the API recovers. Additionally: Adds a 10-second context timeout on bootstrap API calls (previously used context.Background() with no deadline). Applies the same transient error handling to the TLS adherence policy fetch. Which issue(s) this PR fixes: Follow-up to #6567. Checks I've made sure the tests are passing. My commits are signed off (git commit -s) My PR title follows conventional commits format Testing Strategy Manual tests Testing is not required for this change Misc The operator Go module builds cleanly with go build ./... from infra/feast-operator/.
Open Graph Description: What this PR does / why we need it: Follow-up to #6567. Fixes two issues in the TLS profile integration: Else-only pattern: NewTLSConfigFromProfile was only called in the success branch of the TL...
X Description: What this PR does / why we need it: Follow-up to #6567. Fixes two issues in the TLS profile integration: Else-only pattern: NewTLSConfigFromProfile was only called in the success branch of the TL...
Opengraph URL: https://github.com/feast-dev/feast/pull/6587
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d6fd72cc-fa41-f8e9-963a-640e7e267f50 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AFF0:2D422D:1014C9F:15A9794:6A520834 |
| html-safe-nonce | 271db81dbdd931439514dd0a2b9ab2fc2d66a805acb7af167a0807a2681a6599 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkYwOjJENDIyRDoxMDE0QzlGOjE1QTk3OTQ6NkE1MjA4MzQiLCJ2aXNpdG9yX2lkIjoiODQxMDk2NjQ4MDU0MDI3MjY5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3ea752c238501fd4976a241628b3fc257553efb95e437fb63bdecc1484d75f12 |
| hovercard-subject-tag | pull_request:4008160597 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6587/files |
| twitter:image | https://avatars.githubusercontent.com/u/8166389?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8166389?s=400&v=4 |
| og:image:alt | What this PR does / why we need it: Follow-up to #6567. Fixes two issues in the TLS profile integration: Else-only pattern: NewTLSConfigFromProfile was only called in the success branch of the TL... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width