Title: test: Stabilize CLI runner subprocess path by franciscojavierarceo · Pull Request #6560 · feast-dev/feast · GitHub
Open Graph Title: test: Stabilize CLI runner subprocess path by franciscojavierarceo · Pull Request #6560 · feast-dev/feast
X Title: test: Stabilize CLI runner subprocess path by franciscojavierarceo · Pull Request #6560 · feast-dev/feast
Description: What changed Normalizes the environment used by CliRunner subprocesses in unit tests. Adds the parent pytest process sys.path entries to PYTHONPATH before invoking feast.cli.cli in a child Python process. Applies the same environment to both subprocess.run(...) and subprocess.Popen(...) helper paths. Why The unit-test workflow flaked on unit-test-python (3.12, ubuntu-latest) while setting up test_push_source_does_not_exist. The parent pytest process had imported Feast successfully, but the child feast apply subprocess failed before the test body with: ModuleNotFoundError: No module named 'google.protobuf.timestamp_pb2' That points at the subprocess import environment rather than the test assertion. Passing through the parent process import path makes the CLI subprocess use the same repo/site-packages view as pytest. Validation uv run ruff check sdk/python/tests/utils/cli_repo_creator.py uv run python -m pytest sdk/python/tests/unit/test_feature_server.py::test_push_source_does_not_exist -q subprocess smoke: from google.protobuf.timestamp_pb2 import Timestamp using CliRunner._subprocess_env() Note: local setup required make install-python-dependencies-ci PYTHON_VERSION=3.12 because this machine does not have a python shim for the Makefile's default version detection.
Open Graph Description: What changed Normalizes the environment used by CliRunner subprocesses in unit tests. Adds the parent pytest process sys.path entries to PYTHONPATH before invoking feast.cli.cli in a child Python ...
X Description: What changed Normalizes the environment used by CliRunner subprocesses in unit tests. Adds the parent pytest process sys.path entries to PYTHONPATH before invoking feast.cli.cli in a child Python ...
Opengraph URL: https://github.com/feast-dev/feast/pull/6560
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:34ae0629-bca9-5e13-a7c4-5f4a16cce675 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CEA6:9B27A:24348FC:3015894:6A520827 |
| html-safe-nonce | fbf9221456aefcb401c7043303340a3d864dd73ae1492c5af3ef7c6f317c769b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUE2OjlCMjdBOjI0MzQ4RkM6MzAxNTg5NDo2QTUyMDgyNyIsInZpc2l0b3JfaWQiOiIyOTA0NTI1OTg4NTE0ODkxODE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 41817d6d770eda1180c5c54551efecd149a94a0423d64130c086257d36fa1ac9 |
| hovercard-subject-tag | pull_request:3942872368 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6560/files |
| twitter:image | https://avatars.githubusercontent.com/u/4163062?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4163062?s=400&v=4 |
| og:image:alt | What changed Normalizes the environment used by CliRunner subprocesses in unit tests. Adds the parent pytest process sys.path entries to PYTHONPATH before invoking feast.cli.cli in a child Python ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width