| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d679f2c9-3ce1-3946-074a-854a2a2be32f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B640:2BFA45:11E8822:1767AF9:6992B257 |
| html-safe-nonce | 4af899ca89076e71b8d4e8329289655d7d252913c6c22be951ff2d25e5cfbfd9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjQwOjJCRkE0NToxMUU4ODIyOjE3NjdBRjk6Njk5MkIyNTciLCJ2aXNpdG9yX2lkIjoiNTEwODE1MjM0NTE4OTA2OTM5OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b100a05f2b8f521ea0580706a5b69bbfa48b242097d491031f91a97d1a7bcda2 |
| hovercard-subject-tag | pull_request:409113235 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/655/files |
| twitter:image | https://avatars.githubusercontent.com/u/15104168?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15104168?s=400&v=4 |
| og:image:alt | What this PR does / why we need it:
This is a split-off off #612 that introduces the model changes made in that PR in a more digestible chunk.
This PR includes:
Removal of Field object
Addition of... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 42c603b9d642c4a9065a51770f75e5e27132fef0e858607f5c9cb7e422831a7b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 848bc6032dcc93a9a7301dcc3f379a72ba13b96e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/655/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F655%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F655%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/655/files |
| Reload | https://github.com/feast-dev/feast/pull/655/files |
| Reload | https://github.com/feast-dev/feast/pull/655/files |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
189
| https://github.com/feast-dev/feast/issues |
|
Pull requests
73
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| zhilingc:split-fields | https://github.com/zhilingc/feast/tree/split-fields |
|
Conversation
68
| https://github.com/feast-dev/feast/pull/655 |
|
Commits
11
| https://github.com/feast-dev/feast/pull/655/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/655/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/655/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/655/files |
|
Split Field model into distinct Feature and Entity objects
| https://github.com/feast-dev/feast/pull/655/files#top |
|
Show all changes
11 commits
| https://github.com/feast-dev/feast/pull/655/files |
|
3c08158
Split Field model into distinct Feature and Entity objects
Apr 26, 2020
| https://github.com/feast-dev/feast/pull/655/commits/3c08158e51d37b5c1ad15a39318df17f7192a5f3 |
|
17904da
Remove TFX fields for entities in testdata
Apr 27, 2020
| https://github.com/feast-dev/feast/pull/655/commits/17904dab1a3761c3e84f03e8e64bc1f036599975 |
|
9bcbabe
Split Field model into distinct Feature and Entity objects
Apr 29, 2020
| https://github.com/feast-dev/feast/pull/655/commits/9bcbabed076856305596f4de9e66c5b946f7e0bc |
|
2c0a86f
Index jointables
Apr 30, 2020
| https://github.com/feast-dev/feast/pull/655/commits/2c0a86fc593d17dd31fe8c7407c4653f21122b6f |
|
4939b6c
Explicitly name tables, remove redundant constructor
Apr 30, 2020
| https://github.com/feast-dev/feast/pull/655/commits/4939b6caa400bdfb6951d6d9f851cffd1ad817b2 |
|
25b8da9
Integrate labels
Apr 30, 2020
| https://github.com/feast-dev/feast/pull/655/commits/25b8da962a46b0f04872c473542f6fb6aa45eb80 |
|
fc6c498
Fix code comments
May 1, 2020
| https://github.com/feast-dev/feast/pull/655/commits/fc6c498b6be2c87713221b660b0f45b928524eab |
|
7031753
Change FeatureSetId to int
May 1, 2020
| https://github.com/feast-dev/feast/pull/655/commits/7031753bdfbce8a0bfc63c1477f537ddbf57492f |
|
fd9a9d7
Retrieve featuresets from repository so that ids are consistent
May 1, 2020
| https://github.com/feast-dev/feast/pull/655/commits/fd9a9d78299ff68c9f3846d9ca7d3f1c88a0b1df |
|
d579424
Add uniqueness constraint to FeatureSets, fix tests
May 1, 2020
| https://github.com/feast-dev/feast/pull/655/commits/d579424b88388bdd33c6d2bd30cfd2e0e5a37b8d |
|
935602e
Remove feature and entity references
May 4, 2020
| https://github.com/feast-dev/feast/pull/655/commits/935602e588f1380f47a5ec2cf628b8bce1175912 |
|
Clear filters
| https://github.com/feast-dev/feast/pull/655/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/655/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/655/files |
|
MetricsRepository.java
| https://github.com/feast-dev/feast/pull/655/files#diff-71cac396c3c37a5805795d4aa7d890daa6a8753d8cc658c82ad235f7751707c6 |
|
JobUpdateTask.java
| https://github.com/feast-dev/feast/pull/655/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
|
Entity.java
| https://github.com/feast-dev/feast/pull/655/files#diff-2a1d5c94a0e77304f056c4de260aa344cdbd0798c75df01740b881c06bce83e5 |
|
Feature.java
| https://github.com/feast-dev/feast/pull/655/files#diff-42b335e317671497444c4f247063b860f46537e6803b311d869ef57c884a342b |
|
FeatureSet.java
| https://github.com/feast-dev/feast/pull/655/files#diff-408a8e7f33c4419fc8357aeee3dae3bac5e351cd995a436b3679d4d3936540e1 |
|
Field.java
| https://github.com/feast-dev/feast/pull/655/files#diff-a376e2ad4bc60ab5b9a351e3b91b1dea65138ca5233fb64e5492be344f9ca6b6 |
|
Job.java
| https://github.com/feast-dev/feast/pull/655/files#diff-e95558185cd29f6683ba92d36d8f88fca53ea9dcf57a23813a257a1462593144 |
|
Metrics.java
| https://github.com/feast-dev/feast/pull/655/files#diff-9dcba28273b583ee947c44e7e13c7f5af3a8f2dd02cb9b0c3bcb4002eb763c5e |
|
JobCoordinatorService.java
| https://github.com/feast-dev/feast/pull/655/files#diff-e00c51ab165ad0121271c6f080f7ec67812bf01ceb58b571f58d735fd6f184ba |
|
SpecService.java
| https://github.com/feast-dev/feast/pull/655/files#diff-77d410df4742593d8bc2f9b7cebc113912c9a9f9a3b832db7e30067c3184196f |
|
JobCoordinatorServiceTest.java
| https://github.com/feast-dev/feast/pull/655/files#diff-e6b95e0f18caa73bbda2401ec5f10d37c38454eaf36b9f0dcef328dbc3e9e671 |
|
JobServiceTest.java
| https://github.com/feast-dev/feast/pull/655/files#diff-cabe7e374d3b1177eb6ead2a4b24e3319d3b26002ab3a78b66c2b9d7136d4417 |
|
SpecServiceTest.java
| https://github.com/feast-dev/feast/pull/655/files#diff-3e5a2daecb252ed55f8f4aeef423a69b3a3582419250ad08856fba54c31b2704 |
|
TestObjectFactory.java
| https://github.com/feast-dev/feast/pull/655/files#diff-ddfb61400b20f1828c0576221155082bbabc7199289b11e9dee4593f59096dc3 |
|
FeatureSet.proto
| https://github.com/feast-dev/feast/pull/655/files#diff-c5efb7d86cd17297328c46032ec7909e7698a4da5f4e64e9860a1cb723d412b1 |
|
entity.py
| https://github.com/feast-dev/feast/pull/655/files#diff-c0f89d7c348e7d395df4f432d417bea219403127ac9e94e0c126bcf707bf39bb |
|
feature_set.py
| https://github.com/feast-dev/feast/pull/655/files#diff-c32f70797a62b07c798f70588ea978ae3b173562af7a42f796df1fe761060c9b |
|
bikeshare_feature_set.yaml
| https://github.com/feast-dev/feast/pull/655/files#diff-ecf304a2383ca6a97badd808ead8cef3b182773f09f6656a0979998b6d351da8 |
|
bikeshare_schema.json
| https://github.com/feast-dev/feast/pull/655/files#diff-6a9d679b37c0842c0498a1927ac7dc0d28fb716e18b7da6157a2df24e89770a1 |
|
test_feature_set.py
| https://github.com/feast-dev/feast/pull/655/files#diff-c6d82f9bebad23ffc7412206b4e42d97401092aad390ba298558d774968e2463 |
| core/src/main/java/feast/core/dao/MetricsRepository.java | https://github.com/feast-dev/feast/pull/655/files#diff-71cac396c3c37a5805795d4aa7d890daa6a8753d8cc658c82ad235f7751707c6 |
|
View file
| https://github.com/feast-dev/feast/blob/3d9bafd12515b872c479cfb0f7369e11eb0663d9/core/src/main/java/feast/core/dao/MetricsRepository.java |
|
Open in desktop
| https://desktop.github.com |
| Please reload this page | https://github.com/feast-dev/feast/pull/655/files |
| core/src/main/java/feast/core/job/JobUpdateTask.java | https://github.com/feast-dev/feast/pull/655/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
|
View file
| https://github.com/zhilingc/feast/blob/935602e588f1380f47a5ec2cf628b8bce1175912/core/src/main/java/feast/core/job/JobUpdateTask.java |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/655/{{ revealButtonHref }} |
|
| https://github.com/feast-dev/feast/pull/655/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
|
| https://github.com/feast-dev/feast/pull/655/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
|
| https://github.com/feast-dev/feast/pull/655/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
|
| https://github.com/feast-dev/feast/pull/655/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
|
| https://github.com/feast-dev/feast/pull/655/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f |
| core/src/main/java/feast/core/model/Entity.java | https://github.com/feast-dev/feast/pull/655/files#diff-2a1d5c94a0e77304f056c4de260aa344cdbd0798c75df01740b881c06bce83e5 |
|
View file
| https://github.com/zhilingc/feast/blob/935602e588f1380f47a5ec2cf628b8bce1175912/core/src/main/java/feast/core/model/Entity.java |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/655/{{ revealButtonHref }} |
| core/src/main/java/feast/core/model/Feature.java | https://github.com/feast-dev/feast/pull/655/files#diff-42b335e317671497444c4f247063b860f46537e6803b311d869ef57c884a342b |
|
View file
| https://github.com/zhilingc/feast/blob/935602e588f1380f47a5ec2cf628b8bce1175912/core/src/main/java/feast/core/model/Feature.java |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/655/{{ revealButtonHref }} |
| Please reload this page | https://github.com/feast-dev/feast/pull/655/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/655/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/655/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |