René's URL Explorer Experiment


Title: fix: Do not pass undeclared feature view columns to ODFV UDFs by Vedant-Agarwal · Pull Request #6527 · feast-dev/feast · GitHub

Open Graph Title: fix: Do not pass undeclared feature view columns to ODFV UDFs by Vedant-Agarwal · Pull Request #6527 · feast-dev/feast

X Title: fix: Do not pass undeclared feature view columns to ODFV UDFs by Vedant-Agarwal · Pull Request #6527 · feast-dev/feast

Description: What An OnDemandFeatureView's UDF (pandas and python modes) was receiving every feature column in the online response, including features from feature views that the ODFV did not list in its sources. This allowed a UDF to silently depend on an undeclared source. This filters the UDF input down to the ODFV's declared sources before the transform runs. Join keys, request-source fields and the declared features are kept; only columns from undeclared feature views are removed. substrait already restricts its inputs through its query plan, so it is left as is. Fixes #6158. Tests Three tests were added in test_on_demand_pandas_transformation.py: pandas mode: the UDF sees its declared feature and the entity join key, but not another requested feature view's column. python mode: the same check with the dict input. two ODFVs: one ODFV's UDF does not see the other ODFV's source column, even when that feature view is present only as the other ODFV's input. Each of these fails on the current code and passes with this change. Functional test results: $ pytest tests/unit/test_on_demand_pandas_transformation.py \ -k "undeclared or other_requested_odfv" 3 passed in 0.52s ruff and mypy are clean. Scope This covers the online path (get_online_features), which is what the issue reports. The offline path (get_historical_features) has the same shape and can be addressed as a follow-up.

Open Graph Description: What An OnDemandFeatureView's UDF (pandas and python modes) was receiving every feature column in the online response, including features from feature views that the ODFV did not list in its so...

X Description: What An OnDemandFeatureView's UDF (pandas and python modes) was receiving every feature column in the online response, including features from feature views that the ODFV did not list in it...

Opengraph URL: https://github.com/feast-dev/feast/pull/6527

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d496494f-8267-ea86-0237-cf2118b3f783
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F0C:2BC66C:F06CE6:149854E:6AFE989A
html-safe-nonce15db103b91c20aface5293221e1d8b0d21b1bb6b0edebf776d8522cd805d861d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjBDOjJCQzY2QzpGMDZDRTY6MTQ5ODU0RTo2QUZFOTg5QSIsInZpc2l0b3JfaWQiOiI5MTkyMjA5NTk0MTk2MDcyNjAyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6587814721415d1ad2e24d8f6ece57fa3ac9249a1b11e1f471c5ae512c488710
hovercard-subject-tagpull_request:3871008882
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/6527/files
twitter:imagehttps://avatars.githubusercontent.com/u/43557509?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43557509?s=400&v=4
og:image:altWhat An OnDemandFeatureView's UDF (pandas and python modes) was receiving every feature column in the online response, including features from feature views that the ODFV did not list in its so...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb3c0f155eafc27e60db6e254d1ffff0e072e9ab3b4018a5ee518797c19d89f86
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4a10310af51a1bfffbedc4fd81cb582acf0cb0ff
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/6527/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6527%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F6527%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/6527/files
Reloadhttps://github.com/feast-dev/feast/pull/6527/files
Reloadhttps://github.com/feast-dev/feast/pull/6527/files
feast-devhttps://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Codehttps://github.com/feast-dev/feast
Issues223 (223)https://github.com/feast-dev/feast/issues
Pull requests143 (143)https://github.com/feast-dev/feast/pulls
Discussionshttps://github.com/feast-dev/feast/discussions
Actionshttps://github.com/feast-dev/feast/actions
Security and quality1 (1)https://github.com/feast-dev/feast/security
Insightshttps://github.com/feast-dev/feast/insights
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
ntkatholehttps://github.com/ntkathole
feast-dev:masterhttps://github.com/feast-dev/feast/tree/master
Vedant-Agarwal:fix/odfv-source-isolationhttps://github.com/Vedant-Agarwal/feast/tree/fix/odfv-source-isolation
Conversation 3 https://github.com/feast-dev/feast/pull/6527
Commits 2 https://github.com/feast-dev/feast/pull/6527/commits
Checks 23 https://github.com/feast-dev/feast/pull/6527/checks
Files changed https://github.com/feast-dev/feast/pull/6527/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6527/files
fix: Do not pass undeclared feature view columns to ODFV UDFs https://github.com/feast-dev/feast/pull/6527/files#top
Show all changes 2 commits https://github.com/feast-dev/feast/pull/6527/files
3ba9ce2 fix: do not pass undeclared feature view columns to ODFV UDFs Vedant-Agarwal Jun 15, 2026 https://github.com/feast-dev/feast/pull/6527/commits/3ba9ce2448737ab88dccd99743b438f9fda5c654
8bb6764 test: cover ODFV source isolation for an aliased source Vedant-Agarwal Jul 21, 2026 https://github.com/feast-dev/feast/pull/6527/commits/8bb6764f9c5c9df4f66a5533262b917572a14d78
Clear filters https://github.com/feast-dev/feast/pull/6527/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6527/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/6527/files
utils.py https://github.com/feast-dev/feast/pull/6527/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
test_on_demand_pandas_transformation.py https://github.com/feast-dev/feast/pull/6527/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/feast/utils.pyhttps://github.com/feast-dev/feast/pull/6527/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
View file https://github.com/Vedant-Agarwal/feast/blob/8bb6764f9c5c9df4f66a5533262b917572a14d78/sdk/python/feast/utils.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6527/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6527/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
Sanjays2402https://github.com/Sanjays2402
Jul 21, 2026https://github.com/feast-dev/feast/pull/6527/files#r3619456489
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/6527/files
Vedant-Agarwalhttps://github.com/Vedant-Agarwal
Jul 21, 2026https://github.com/feast-dev/feast/pull/6527/files#r3623507038
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@Sanjays2402https://github.com/Sanjays2402
Please reload this pagehttps://github.com/feast-dev/feast/pull/6527/files
https://github.com/feast-dev/feast/pull/6527/files#diff-40c97723b8e9de73be769c43e3a3ef5f7623aef7d53aa05d77fcb7ab8d2aa5e0
https://github.com/feast-dev/feast/blob/master/CODEOWNERS#L10
sdk/python/tests/unit/test_on_demand_pandas_transformation.pyhttps://github.com/feast-dev/feast/pull/6527/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
View file https://github.com/Vedant-Agarwal/feast/blob/8bb6764f9c5c9df4f66a5533262b917572a14d78/sdk/python/tests/unit/test_on_demand_pandas_transformation.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/6527/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/6527/files#diff-04091031c46a4830647ac7dabead06ba93dbea0d6b1ae26b9eb5e08f77ba41ee
Please reload this pagehttps://github.com/feast-dev/feast/pull/6527/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.