| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2a991708-d953-8e6c-bfbd-a301c42d2454 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 814E:36C84C:CDCE01:D0792E:697A7D59 |
| html-safe-nonce | f6603dedef6c79d3691f1285c0683ae497251170791a8237e5565bbf3dfb46b9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTRFOjM2Qzg0QzpDRENFMDE6RDA3OTJFOjY5N0E3RDU5IiwidmlzaXRvcl9pZCI6IjE4OTc5MTE2ODU4Mzg2OTk4NjUiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ== |
| visitor-hmac | f803159d987cad8317d66ee91ed087ef94937c442b667ad669e2adf36ff68dc1 |
| hovercard-subject-tag | pull_request:409036336 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/feast-dev/feast/651/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3d8f55f78e347b58ae658026346213df97b8c4eb53a179fe4b8abdf201270791/feast-dev/feast/pull/651 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3d8f55f78e347b58ae658026346213df97b8c4eb53a179fe4b8abdf201270791/feast-dev/feast/pull/651 |
| og:image:alt | What this PR does / why we need it:
This is refactoring aiming to remove a burden on the programmer to get something right.
#575 sought to clear up inconsistencies between uses of Runner#name() (th... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ches |
| hostname | github.com |
| expected-hostname | github.com |
| None | a9d1eabfb8cf0cb510bcf598032681675ad29b7ee4cb3bfb9a0a088a12803628 |
| turbo-cache-control | no-preview |
| go-import | github.com/feast-dev/feast git https://github.com/feast-dev/feast.git |
| octolytics-dimension-user_id | 57027613 |
| octolytics-dimension-user_login | feast-dev |
| octolytics-dimension-repository_id | 161133770 |
| octolytics-dimension-repository_nwo | feast-dev/feast |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 161133770 |
| octolytics-dimension-repository_network_root_nwo | feast-dev/feast |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31bacebc3305d80609c1b175449c3d314bd1a855 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/feast-dev/feast/pull/651#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F651 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F651 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=feast-dev%2Ffeast |
| Reload | https://github.com/feast-dev/feast/pull/651 |
| Reload | https://github.com/feast-dev/feast/pull/651 |
| Reload | https://github.com/feast-dev/feast/pull/651 |
|
feast-dev
| https://github.com/feast-dev |
| feast | https://github.com/feast-dev/feast |
|
Notifications
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Fork
1.2k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Star
6.7k
| https://github.com/login?return_to=%2Ffeast-dev%2Ffeast |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
183
| https://github.com/feast-dev/feast/issues |
|
Pull requests
68
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
0
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
|
Code
| https://github.com/feast-dev/feast |
|
Issues
| https://github.com/feast-dev/feast/issues |
|
Pull requests
| https://github.com/feast-dev/feast/pulls |
|
Discussions
| https://github.com/feast-dev/feast/discussions |
|
Actions
| https://github.com/feast-dev/feast/actions |
|
Security
| https://github.com/feast-dev/feast/security |
|
Insights
| https://github.com/feast-dev/feast/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/feast-dev/feast/pull/651#issue-comment-box |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| agoda-com:job-runner-as-enum | https://github.com/agoda-com/feast/tree/job-runner-as-enum |
|
core: Use Runner enum type instead of string for Job model
| https://github.com/feast-dev/feast/pull/651#top |
| feast-ci-bot | https://github.com/feast-ci-bot |
| feast-dev:master | https://github.com/feast-dev/feast/tree/master |
| agoda-com:job-runner-as-enum | https://github.com/agoda-com/feast/tree/job-runner-as-enum |
|
Conversation
8
| https://github.com/feast-dev/feast/pull/651 |
|
Commits
1
| https://github.com/feast-dev/feast/pull/651/commits |
|
Checks
0
| https://github.com/feast-dev/feast/pull/651/checks |
|
Files changed
| https://github.com/feast-dev/feast/pull/651/files |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| https://github.co/hiddenchars |
| https://github.com/feast-dev/feast/pull/{{ revealButtonHref }} |
|
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 26, 2020 | https://github.com/feast-dev/feast/pull/651#issue-606945748 |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| #575 | https://github.com/feast-dev/feast/pull/575 |
| #575 | https://github.com/feast-dev/feast/pull/575 |
| #578 | https://github.com/feast-dev/feast/pull/578 |
| #575 | https://github.com/feast-dev/feast/pull/575 |
| #578 | https://github.com/feast-dev/feast/pull/578 |
| #650 (comment) | https://github.com/feast-dev/feast/pull/650#discussion_r415132957 |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
|
| https://github.com/ches |
| core: Use Runner enum type instead of string for Job model | https://github.com/feast-dev/feast/pull/651/commits/b3172854b42804022073b8e7a906c073d110e61c |
| b317285 | https://github.com/feast-dev/feast/pull/651/commits/b3172854b42804022073b8e7a906c073d110e61c |
| feast-dev#575 | https://github.com/feast-dev/feast/pull/575 |
| feast-dev#578 | https://github.com/feast-dev/feast/pull/578 |
| https://github.com/ches |
| ches | https://github.com/ches |
| pradithya | https://github.com/pradithya |
| zhilingc | https://github.com/zhilingc |
| code owners | https://github.com/feast-dev/feast/blob/e5bc18c6833f742a954c1325764721b96f31faa1/.github/CODEOWNERS#L5 |
| April 26, 2020 07:39 | https://github.com/feast-dev/feast/pull/651#event-3272654146 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
size/L
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL |
| Apr 26, 2020 | https://github.com/feast-dev/feast/pull/651#event-3272654300 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Apr 26, 2020
| https://github.com/feast-dev/feast/pull/651#ref-pullrequest-606836036 |
|
JobUpdateTask cleanups
#650
| https://github.com/feast-dev/feast/pull/650 |
| https://github.com/ches |
| ches | https://github.com/ches |
| Apr 26, 2020 | https://github.com/feast-dev/feast/pull/651#issuecomment-619502654 |
| @woop | https://github.com/woop |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| woop | https://github.com/woop |
| Apr 26, 2020 | https://github.com/feast-dev/feast/pull/651#event-3272654911 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Apr 26, 2020
| https://github.com/feast-dev/feast/pull/651#pullrequestreview-400471369 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/651/files/b3172854b42804022073b8e7a906c073d110e61c |
| core/src/main/java/feast/core/job/Runner.java | https://github.com/feast-dev/feast/pull/651/files/b3172854b42804022073b8e7a906c073d110e61c#diff-bf787bf8451dca394f3fe37dcb792a28600110b274f0eadfa70a786fee7d68d4 |
| ches | https://github.com/ches |
| Apr 26, 2020 | https://github.com/feast-dev/feast/pull/651#discussion_r415244903 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| https://github.com/ches |
| ches | https://github.com/ches |
|
Apr 26, 2020
| https://github.com/feast-dev/feast/pull/651#pullrequestreview-400471493 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/651/files/b3172854b42804022073b8e7a906c073d110e61c |
| core/src/main/java/feast/core/model/Job.java | https://github.com/feast-dev/feast/pull/651/files/b3172854b42804022073b8e7a906c073d110e61c#diff-e95558185cd29f6683ba92d36d8f88fca53ea9dcf57a23813a257a1462593144 |
| ches | https://github.com/ches |
| Apr 26, 2020 | https://github.com/feast-dev/feast/pull/651#discussion_r415245216 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Apr 27, 2020
| https://github.com/feast-dev/feast/pull/651#pullrequestreview-400635270 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/651/files/b3172854b42804022073b8e7a906c073d110e61c |
| core/src/main/java/feast/core/service/JobService.java | https://github.com/feast-dev/feast/pull/651/files/b3172854b42804022073b8e7a906c073d110e61c#diff-2d7c4b0863b06e44e7186367d8612e7e4b9be9841efb113841b37268f46d2023 |
| woop | https://github.com/woop |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/651#discussion_r415520399 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/651#issuecomment-619731557 |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/651#issuecomment-619740822 |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/651#event-3274086258 |
| https://github.com/woop |
| woop | https://github.com/woop |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/651#issuecomment-619740894 |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/651#event-3274086798 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Apr 27, 2020
| https://github.com/feast-dev/feast/pull/651#pullrequestreview-400644106 |
|
View reviewed changes
| https://github.com/feast-dev/feast/pull/651/files/b3172854b42804022073b8e7a906c073d110e61c |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/651#issuecomment-619741211 |
| ches | https://github.com/gojek/feast/pull/651 |
| woop | https://github.com/gojek/feast/pull/651#pullrequestreview-400644106 |
| here | https://go.k8s.io/bot-commands?repo=gojek%2Ffeast |
| here | https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process |
| OWNERS | https://github.com/gojek/feast/blob/master/OWNERS |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
| https://github.com/feast-ci-bot |
| feast-ci-bot | https://github.com/feast-ci-bot |
| 78b6024 | https://github.com/feast-dev/feast/commit/78b60247d8cf9faad0f230580f8107754ad5f666 |
| Apr 27, 2020 | https://github.com/feast-dev/feast/pull/651#event-3274088713 |
| https://github.com/ches |
| ches | https://github.com/ches |
| April 27, 2020 13:22 | https://github.com/feast-dev/feast/pull/651#event-3275746926 |
| https://github.com/woop |
| woop | https://github.com/woop |
|
Apr 30, 2020
| https://github.com/feast-dev/feast/pull/651#ref-pullrequest-565019695 |
|
Document release steps
#476
| https://github.com/feast-dev/feast/pull/476 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F651 |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
| https://github.com/feast-dev/feast/pull/651/files/b3172854b42804022073b8e7a906c073d110e61c |
|
| https://github.com/pradithya |
|
pradithya
| https://github.com/pradithya |
|
| https://github.com/zhilingc |
|
zhilingc
| https://github.com/zhilingc |
|
| https://github.com/woop |
|
woop
| https://github.com/woop |
|
approved
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Aapproved |
|
lgtm
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Algtm |
|
size/L
| https://github.com/feast-dev/feast/issues?q=state%3Aopen%20label%3Asize%2FL |
| Please reload this page | https://github.com/feast-dev/feast/pull/651 |
|
| https://github.com/ches |
|
| https://github.com/woop |
|
| https://github.com/feast-ci-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |