René's URL Explorer Experiment


Title: JobUpdateTask cleanups by ches · Pull Request #650 · feast-dev/feast · GitHub

Open Graph Title: JobUpdateTask cleanups by ches · Pull Request #650 · feast-dev/feast

X Title: JobUpdateTask cleanups by ches · Pull Request #650 · feast-dev/feast

Description: What this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this code, and found it a bit hard to follow and work with. This is my attempt at improving that. This PR is meant to be reviewed commit-by-commit, it should hopefully make sense quickly that way. Tests are untouched until the final commit and should pass at every step. I have a question or two though that I'll ask inline, so I'm marking this WIP, I may update a bit more based on the answers, especially docstrings where warranted. Which issue(s) this PR fixes: No issue Does this PR introduce a user-facing change?: NONE

Open Graph Description: What this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this cod...

X Description: What this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this...

Opengraph URL: https://github.com/feast-dev/feast/pull/650

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a2ca1422-a9a1-f4a0-0d4a-d16e6e75e263
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE3EC:1DD6:107D3AD:14DBC1F:697D9903
html-safe-noncec28378e243da02e7c6eb0d6ee5ad7fb91aa0319081436df0f031c1b4fdb0c665
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFM0VDOjFERDY6MTA3RDNBRDoxNERCQzFGOjY5N0Q5OTAzIiwidmlzaXRvcl9pZCI6IjY5MTIyMDE3MzIzNjU1ODg3MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacda0fad86f4a89fa49924e181d8804b282a02891aefd4ac63efc7f1a3249224c7
hovercard-subject-tagpull_request:408956150
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/feast-dev/feast/pull/650/files
twitter:imagehttps://avatars.githubusercontent.com/u/13277?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13277?s=400&v=4
og:image:altWhat this PR does / why we need it: Cleanup, this is purely refactoring aiming to make code easier to read, understand, and modify. I've been doing some work—and reviews of work—around this cod...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None60279d4097367e16897439d16d6bbe4180663db828c666eeed2656988ffe59f6
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/feast-dev/feast git https://github.com/feast-dev/feast.git
octolytics-dimension-user_id57027613
octolytics-dimension-user_loginfeast-dev
octolytics-dimension-repository_id161133770
octolytics-dimension-repository_nwofeast-dev/feast
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id161133770
octolytics-dimension-repository_network_root_nwofeast-dev/feast
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7c85641c598ad130c74f7bcc27f58575cac69551
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/feast-dev/feast/pull/650/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F650%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Ffeast-dev%2Ffeast%2Fpull%2F650%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=feast-dev%2Ffeast
Reloadhttps://github.com/feast-dev/feast/pull/650/files
Reloadhttps://github.com/feast-dev/feast/pull/650/files
Reloadhttps://github.com/feast-dev/feast/pull/650/files
feast-dev https://github.com/feast-dev
feasthttps://github.com/feast-dev/feast
Notifications https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Fork 1.2k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Star 6.7k https://github.com/login?return_to=%2Ffeast-dev%2Ffeast
Code https://github.com/feast-dev/feast
Issues 183 https://github.com/feast-dev/feast/issues
Pull requests 67 https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security 0 https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Code https://github.com/feast-dev/feast
Issues https://github.com/feast-dev/feast/issues
Pull requests https://github.com/feast-dev/feast/pulls
Discussions https://github.com/feast-dev/feast/discussions
Actions https://github.com/feast-dev/feast/actions
Security https://github.com/feast-dev/feast/security
Insights https://github.com/feast-dev/feast/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Ffeast-dev%2Ffeast%2Fissues%2Fnew%2Fchoose
feast-ci-bothttps://github.com/feast-ci-bot
masterhttps://github.com/feast-dev/feast/tree/master
JobUpdateTask-cleanuphttps://github.com/feast-dev/feast/tree/JobUpdateTask-cleanup
Conversation 41 https://github.com/feast-dev/feast/pull/650
Commits 7 https://github.com/feast-dev/feast/pull/650/commits
Checks 0 https://github.com/feast-dev/feast/pull/650/checks
Files changed https://github.com/feast-dev/feast/pull/650/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
JobUpdateTask cleanups https://github.com/feast-dev/feast/pull/650/files#top
Show all changes 7 commits https://github.com/feast-dev/feast/pull/650/files
ac1143d core: Clean up repetition in JobUpdateTask ches Apr 25, 2020 https://github.com/feast-dev/feast/pull/650/commits/ac1143dcde7d39f91cec66b60448450856daea79
59f0352 core: Reduce noise of AuditLogger in JobUpdateTask ches Apr 25, 2020 https://github.com/feast-dev/feast/pull/650/commits/59f0352b37d882d03ea1b6a79146566b7854793e
5871d13 core: Simplify JobUpdateTask internal helper calls ches Apr 25, 2020 https://github.com/feast-dev/feast/pull/650/commits/5871d134b2f8d9753d0fed5c4d2888028e28ef97
25b9dcb core: Make isTerminal an instance property of JobStatus ches Apr 25, 2020 https://github.com/feast-dev/feast/pull/650/commits/25b9dcb69d72f08d4391928852f449dac11d0852
b5e0ce8 core: Remove test setup duplication in JobUpdateTaskTest ches Apr 25, 2020 https://github.com/feast-dev/feast/pull/650/commits/b5e0ce8a504bd2aa87615f39a8ba6997d7ebc1d3
15cc078 core: Add unit tests for JobStatus ches Apr 26, 2020 https://github.com/feast-dev/feast/pull/650/commits/15cc078598101279c6107d61bd5a0504a08b2ad6
ded7ca5 core: Refactor JobUpdateTask to use domain model types ches Apr 27, 2020 https://github.com/feast-dev/feast/pull/650/commits/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915
Clear filters https://github.com/feast-dev/feast/pull/650/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
JobUpdateTask.java https://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f
DataflowJobManager.java https://github.com/feast-dev/feast/pull/650/files#diff-0bef9304bcee148647cba5905007be62d3393d60e04daee560dba65bc1272aae
DirectRunnerJobManager.java https://github.com/feast-dev/feast/pull/650/files#diff-e62e308f4e577e691c3719f83e37fedce3af90202f2803fd9e9795fe61883143
Job.java https://github.com/feast-dev/feast/pull/650/files#diff-e95558185cd29f6683ba92d36d8f88fca53ea9dcf57a23813a257a1462593144
JobStatus.java https://github.com/feast-dev/feast/pull/650/files#diff-d80cd248b30f221ad8a435548b47b850cd2806ae20c275fcf3b53ac8a53b813f
JobCoordinatorService.java https://github.com/feast-dev/feast/pull/650/files#diff-e00c51ab165ad0121271c6f080f7ec67812bf01ceb58b571f58d735fd6f184ba
JobService.java https://github.com/feast-dev/feast/pull/650/files#diff-2d7c4b0863b06e44e7186367d8612e7e4b9be9841efb113841b37268f46d2023
JobUpdateTaskTest.java https://github.com/feast-dev/feast/pull/650/files#diff-5169333fcd0df390bca0d06c61c65bff4908348b83fde0a8d79f28473c2957f5
JobStatusTest.java https://github.com/feast-dev/feast/pull/650/files#diff-5dc5d4ac9883ed658e3d6026ffac47eebe3297b13c95ff0a77636236a6ff6741
JobServiceTest.java https://github.com/feast-dev/feast/pull/650/files#diff-cabe7e374d3b1177eb6ead2a4b24e3319d3b26002ab3a78b66c2b9d7136d4417
core/src/main/java/feast/core/job/JobUpdateTask.javahttps://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f
View file https://github.com/feast-dev/feast/blob/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915/core/src/main/java/feast/core/job/JobUpdateTask.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/650/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f
https://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f
https://github.com/feast-dev/feast/pull/650/files#diff-b596a79dd3947d836a7aca8203777ba20202b61059ba2779012f0507473ba13f
woophttps://github.com/woop
Apr 29, 2020https://github.com/feast-dev/feast/pull/650/files#r417389088
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/gojek/feast/blame/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915/core/src/main/java/feast/core/config/FeastProperties.java#L95https://github.com/gojek/feast/blame/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915/core/src/main/java/feast/core/config/FeastProperties.java#L95
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
woophttps://github.com/woop
Apr 29, 2020https://github.com/feast-dev/feast/pull/650/files#r417390645
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
cheshttps://github.com/ches
Apr 29, 2020https://github.com/feast-dev/feast/pull/650/files#r417458011
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
cheshttps://github.com/ches
Apr 25, 2020https://github.com/feast-dev/feast/pull/650/files#r415130044
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@zhilingchttps://github.com/zhilingc
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
zhilingchttps://github.com/zhilingc
Apr 27, 2020https://github.com/feast-dev/feast/pull/650/files#r415472243
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
core/src/main/java/feast/core/job/dataflow/DataflowJobManager.javahttps://github.com/feast-dev/feast/pull/650/files#diff-0bef9304bcee148647cba5905007be62d3393d60e04daee560dba65bc1272aae
View file https://github.com/feast-dev/feast/blob/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915/core/src/main/java/feast/core/job/dataflow/DataflowJobManager.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/650/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/650/files#diff-0bef9304bcee148647cba5905007be62d3393d60e04daee560dba65bc1272aae
https://github.com/feast-dev/feast/pull/650/files#diff-0bef9304bcee148647cba5905007be62d3393d60e04daee560dba65bc1272aae
core/src/main/java/feast/core/job/direct/DirectRunnerJobManager.javahttps://github.com/feast-dev/feast/pull/650/files#diff-e62e308f4e577e691c3719f83e37fedce3af90202f2803fd9e9795fe61883143
View file https://github.com/feast-dev/feast/blob/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915/core/src/main/java/feast/core/job/direct/DirectRunnerJobManager.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/650/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/650/files#diff-e62e308f4e577e691c3719f83e37fedce3af90202f2803fd9e9795fe61883143
https://github.com/feast-dev/feast/pull/650/files#diff-e62e308f4e577e691c3719f83e37fedce3af90202f2803fd9e9795fe61883143
core/src/main/java/feast/core/model/Job.javahttps://github.com/feast-dev/feast/pull/650/files#diff-e95558185cd29f6683ba92d36d8f88fca53ea9dcf57a23813a257a1462593144
View file https://github.com/feast-dev/feast/blob/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915/core/src/main/java/feast/core/model/Job.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/650/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/650/files#diff-e95558185cd29f6683ba92d36d8f88fca53ea9dcf57a23813a257a1462593144
https://github.com/feast-dev/feast/pull/650/files#diff-e95558185cd29f6683ba92d36d8f88fca53ea9dcf57a23813a257a1462593144
core/src/main/java/feast/core/model/JobStatus.javahttps://github.com/feast-dev/feast/pull/650/files#diff-d80cd248b30f221ad8a435548b47b850cd2806ae20c275fcf3b53ac8a53b813f
View file https://github.com/feast-dev/feast/blob/ded7ca59a2bd5b40715af73fdaa4e4f19ad0b915/core/src/main/java/feast/core/model/JobStatus.java
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/feast-dev/feast/pull/650/{{ revealButtonHref }}
https://github.com/feast-dev/feast/pull/650/files#diff-d80cd248b30f221ad8a435548b47b850cd2806ae20c275fcf3b53ac8a53b813f
https://github.com/feast-dev/feast/pull/650/files#diff-d80cd248b30f221ad8a435548b47b850cd2806ae20c275fcf3b53ac8a53b813f
https://github.com/feast-dev/feast/pull/650/files#diff-d80cd248b30f221ad8a435548b47b850cd2806ae20c275fcf3b53ac8a53b813f
cheshttps://github.com/ches
Apr 25, 2020https://github.com/feast-dev/feast/pull/650/files#r415136744
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
zhilingchttps://github.com/zhilingc
Apr 27, 2020https://github.com/feast-dev/feast/pull/650/files#r415472973
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
https://github.com/feast-dev/feast/pull/650/files#diff-d80cd248b30f221ad8a435548b47b850cd2806ae20c275fcf3b53ac8a53b813f
https://github.com/feast-dev/feast/pull/650/files#diff-d80cd248b30f221ad8a435548b47b850cd2806ae20c275fcf3b53ac8a53b813f
Please reload this pagehttps://github.com/feast-dev/feast/pull/650/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.